search for: nouveau_vma_getmap

...+++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c > index cdc3282..191145d 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_bo.c > +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c > @@ -963,6 +963,12 @@ nouveau_vma_getmap(struct nouveau_channel *chan, struct nouveau_bo *nvbo, > struct nouveau_mem *node = mem->mm_node; > int ret; > > + /* If we ever get here for a non-vram mem node that doesn't > + * have pages, we will end up doing a null deref in > + * no...

Op 22-08-13 02:10, Ilia Mirkin schreef: > The code expects non-VRAM mem nodes to have a pages list. If that's not > set, it will do a null deref down the line. Warn on that condition and > return an error. > > See https://bugs.freedesktop.org/show_bug.cgi?id=64774 > > Reported-by: Pasi K?rkk?inen <pasik at iki.fi> > Tested-by: Pasi K?rkk?inen <pasik at

On Wed, Sep 04, 2013 at 08:59:13AM +0200, Maarten Lankhorst wrote: > > When looking into this bug I noticed that nouveau_bo_vma_add needs to have a check for nvbo->page_shift == vma->vm->vmm->spg_shift, > and only if the check is true it should map the page in TTM_PL_TT. Patch below. > Should probably also be cc'd to stable. > How about this patch? Is it ready to

On Thu, Sep 26, 2013 at 02:48:49AM +1000, Ben Skeggs wrote: > > > > Ben/Maarten: Are you guys planning to take a look at this and submit another patch, or.. ? > > > > I tested the two earlier patches from this thread, and they both fixed the problem (hard kernel crash). > > I'm hoping this bug could be finally solved in the kernel.. > > I shall be looking at

On Thu, Sep 26, 2013 at 12:41 AM, Pasi K?rkk?inen <pasik at iki.fi> wrote: > Hello, > > On Wed, Sep 04, 2013 at 08:59:13AM +0200, Maarten Lankhorst wrote: >> Op 04-09-13 05:41, Ben Skeggs schreef: >> > On Thu, Aug 22, 2013 at 5:12 PM, Maarten Lankhorst >> > <maarten.lankhorst at canonical.com> wrote: >> >> Op 22-08-13 02:10, Ilia Mirkin

On Fri, Aug 23, 2013 at 11:20:42PM +0300, Pasi K?rkk?inen wrote: > On Thu, Aug 22, 2013 at 09:12:40AM +0200, Maarten Lankhorst wrote: > > Op 22-08-13 02:10, Ilia Mirkin schreef: > > > The code expects non-VRAM mem nodes to have a pages list. If that's not > > > set, it will do a null deref down the line. Warn on that condition and > > > return an error. >

Op 04-09-13 05:41, Ben Skeggs schreef: > On Thu, Aug 22, 2013 at 5:12 PM, Maarten Lankhorst > <maarten.lankhorst at canonical.com> wrote: >> Op 22-08-13 02:10, Ilia Mirkin schreef: >>> The code expects non-VRAM mem nodes to have a pages list. If that's not >>> set, it will do a null deref down the line. Warn on that condition and >>> return an

On Wed, Aug 28, 2013 at 09:44:15AM +0200, Maarten Lankhorst wrote: > Op 28-08-13 08:29, Pasi K?rkk?inen schreef: > > On Fri, Aug 23, 2013 at 11:20:42PM +0300, Pasi K?rkk?inen wrote: > >> On Thu, Aug 22, 2013 at 09:12:40AM +0200, Maarten Lankhorst wrote: > >>> Op 22-08-13 02:10, Ilia Mirkin schreef: > >>>> The code expects non-VRAM mem nodes to have a

On Tue, Sep 03, 2013 at 04:34:56PM +0200, Maarten Lankhorst wrote: > Op 03-09-13 16:20, Pasi K?rkk?inen schreef: > > On Wed, Aug 28, 2013 at 09:44:15AM +0200, Maarten Lankhorst wrote: > >> Op 28-08-13 08:29, Pasi K?rkk?inen schreef: > >>> On Fri, Aug 23, 2013 at 11:20:42PM +0300, Pasi K?rkk?inen wrote: > >>>> On Thu, Aug 22, 2013 at 09:12:40AM +0200,

On Thu, Aug 22, 2013 at 09:12:40AM +0200, Maarten Lankhorst wrote: > Op 22-08-13 02:10, Ilia Mirkin schreef: > > The code expects non-VRAM mem nodes to have a pages list. If that's not > > set, it will do a null deref down the line. Warn on that condition and > > return an error. > > > > See https://bugs.freedesktop.org/show_bug.cgi?id=64774 > > > >

...gpu/drm/nouveau/nouveau_bo.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c index cdc3282..191145d 100644 --- a/drivers/gpu/drm/nouveau/nouveau_bo.c +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c @@ -963,6 +963,12 @@ nouveau_vma_getmap(struct nouveau_channel *chan, struct nouveau_bo *nvbo, struct nouveau_mem *node = mem->mm_node; int ret; + /* If we ever get here for a non-vram mem node that doesn't + * have pages, we will end up doing a null deref in + * nouveau_vm_map_sg. */ + if (WARN_ON(mem->mem_type != TTM_...

Hello, On Wed, Sep 04, 2013 at 08:59:13AM +0200, Maarten Lankhorst wrote: > Op 04-09-13 05:41, Ben Skeggs schreef: > > On Thu, Aug 22, 2013 at 5:12 PM, Maarten Lankhorst > > <maarten.lankhorst at canonical.com> wrote: > >> Op 22-08-13 02:10, Ilia Mirkin schreef: > >>> The code expects non-VRAM mem nodes to have a pages list. If that's not >

Op 28-08-13 08:29, Pasi K?rkk?inen schreef: > On Fri, Aug 23, 2013 at 11:20:42PM +0300, Pasi K?rkk?inen wrote: >> On Thu, Aug 22, 2013 at 09:12:40AM +0200, Maarten Lankhorst wrote: >>> Op 22-08-13 02:10, Ilia Mirkin schreef: >>>> The code expects non-VRAM mem nodes to have a pages list. If that's not >>>> set, it will do a null deref down the line.

Op 03-09-13 16:20, Pasi K?rkk?inen schreef: > On Wed, Aug 28, 2013 at 09:44:15AM +0200, Maarten Lankhorst wrote: >> Op 28-08-13 08:29, Pasi K?rkk?inen schreef: >>> On Fri, Aug 23, 2013 at 11:20:42PM +0300, Pasi K?rkk?inen wrote: >>>> On Thu, Aug 22, 2013 at 09:12:40AM +0200, Maarten Lankhorst wrote: >>>>> Op 22-08-13 02:10, Ilia Mirkin schreef:

On Thu, Aug 22, 2013 at 5:12 PM, Maarten Lankhorst <maarten.lankhorst at canonical.com> wrote: > Op 22-08-13 02:10, Ilia Mirkin schreef: >> The code expects non-VRAM mem nodes to have a pages list. If that's not >> set, it will do a null deref down the line. Warn on that condition and >> return an error. >> >> See

...org Not tainted 3.8.11-200.fc18.x86_64 #1 LENOVO 2349H2G/2349H2G RIP: 0010:[<ffffffffa01abb7e>] [<ffffffffa01abb7e>] nvc0_vm_map_sg+0x8e/0x110 [nouveau] RSP: 0018:ffff8803298357c8 EFLAGS: 00010206 .. Process Xorg (pid: 1208,..) .. Call Trace: .. nouveau_vm_map_sg+0xc2/0x130 [nouveau] .. nouveau_vma_getmap.isra.11+0x68/0xa0 [nouveau] .. nouveau_bo_move_m2mf.isra.12+0x85/0x140 [nouveau] .. ? nouveau_vm_map_at+0x153/0x1c0 [nouveau] .. nouveau_bo_move+0xa5/0x400 [nouveau] .. ttm_bo_handle_move_mem+0x245/0x610 [ttm] More info from the screenshots above (also attached).. Kernel dmesg from before the cra...