search for: nouveau_hwmon_op

This patch introduces the nouveau_hwmon_ops structure, sets up .is_visible and .read_string operations and adds all the functions for these operations. This is also a preparation for the next patches, where most of the work is being done. This code doesn't interacture with the old one. It's just to make easier the review of all patc...

This patch introduces the nouveau_hwmon_ops structure, sets up .is_visible and .read_string operations and adds all the functions for these operations. This is also a preparation for the next patches, where most of the work is being done. This code doesn't interacture with the old one. It's just to make easier the review of all patc...

This patch introduces the nouveau_hwmon_ops structure, sets up .is_visible and .read_string operations and adds all the functions for these operations. This is also a preparation for the next patches, where most of the work is being done. This code doesn't interacture with the old one. It's just to make easier the review of all patc...

This patch introduces the nouveau_hwmon_ops structure, sets up .is_visible and .read_string operations and adds all the functions for these operations. This is also a preparation for the next patches, where most of the work is being done. This code doesn't interacture with the old one. It's just to make easier the review of all patc...

...return 0444; default: return 0; } Could you drop me a hint? On 18 April 2017 at 09:56, Karol Herbst <karolherbst at gmail.com> wrote: > 2017-04-17 9:47 GMT+02:00 Oscar Salvador <osalvador.vilardaga at gmail.com>: >> This patch introduces the nouveau_hwmon_ops structure, sets up >> .is_visible and .read_string operations and adds all the functions >> for these operations. >> This is also a preparation for the next patches, where most of the >> work is being done. >> This code doesn't interacture with the old one. >&g...

On 26/04/17 19:46, Oscar Salvador wrote: > This patch introduces the nouveau_hwmon_ops structure, sets up > .is_visible and .read_string operations and adds all the functions > for these operations. > This is also a preparation for the next patches, where most of the > work is being done. > This code doesn't interacture with the old one. > It's just to make...

2017-04-17 9:47 GMT+02:00 Oscar Salvador <osalvador.vilardaga at gmail.com>: > This patch introduces the nouveau_hwmon_ops structure, sets up > .is_visible and .read_string operations and adds all the functions > for these operations. > This is also a preparation for the next patches, where most of the > work is being done. > This code doesn't interacture with the old one. > It's just to make...

...e"; + +static int +nouveau_read_string(struct device *dev, enum hwmon_sensor_types type, u32 attr, + int channel, char **buf) +{ + if (type == hwmon_in && attr == hwmon_in_label) { + *buf = input_label; + return 0; + } + + return -EOPNOTSUPP; +} + +static const struct hwmon_ops nouveau_hwmon_ops = { + .is_visible = nouveau_is_visible, + .read = NULL, + .read_string = nouveau_read_string, + .write = NULL, +}; + +static const struct hwmon_chip_info nouveau_chip_info = { + .ops = &nouveau_hwmon_ops, + .info = nouveau_info, +}; #endif int

...int channel, char **buf) Indentation > +{ > + if (type == hwmon_in && attr == hwmon_in_label) { > + *buf = input_label; > + return 0; > + } > + > + return -EOPNOTSUPP; > +} > + > +static const struct hwmon_ops nouveau_hwmon_ops = { > + .is_visible = nouveau_is_visible, > + .read = NULL, > + .read_string = nouveau_read_string, > + .write = NULL, > +}; > + > +static const struct hwmon_chip_info nouveau_chip_info = { > + .ops = &nouveau_hwmon_ops, > + .info...

...const to struct attribute. Kbuild complains. This patchseries replaces the deprecated hwmon_device_register function with the new one hwmon_device_register_with_info. It also does some cleanup. Oscar Salvador (5): nouveau_hwmon: Add config for all sensors and their settings nouveau_hwmon: Add nouveau_hwmon_ops structure with .is_visible/.read_string nouveau_hwmon: Remove old code, add .write/.read operations nouveau_hwmon: Add support for auto_point attributes nouveau_hwmon: Change permissions to numeric drivers/gpu/drm/nouveau/nouveau_hwmon.c | 954 +++++++++++++++++--------------- 1 file c...

...tch statements. v7 -> v8: * Fix warnings This patchseries replaces the deprecated hwmon_device_register function with the new one hwmon_device_register_with_info. It also does some cleanup. Oscar Salvador (5): nouveau/hwmon: Add config for all sensors and their settings nouveau/hwmon: Add nouveau_hwmon_ops structure with .is_visible/.read_string nouveau/hwmon: Remove old code, add .write/.read operations nouveau/hwmon: expose the auto_point and pwm_min/max attrs nouveau/hwmon: Change permissions to numeric drivers/gpu/drm/nouveau/nouveau_hwmon.c | 983 +++++++++++++++----------------- 1...

...rations, and create all functions regarding these operations. 4/ We add support for special attributes like *_auto_point*. 5/ Cleanup: Change permissions to numeric and add me to the author Oscar Salvador (5): nouveau_hwmon: Add config for all sensors and their settings nouveau_hwmon: Add nouveau_hwmon_ops structure with .is_visible/.read_string nouveau_hwmon: Remove old code, add .write/.read operations nouveau_hwmon: Add support for auto_point attributes nouveau_hwmon: Change permissions to numeric drivers/gpu/drm/nouveau/nouveau_hwmon.c | 946 +++++++++++++++++--------------- 1 file c...

...nd moved code into the switch statements. This patchseries replaces the deprecated hwmon_device_register function with the new one hwmon_device_register_with_info. It also does some cleanup. Oscar Salvador (5): nouveau/hwmon: Add config for all sensors and their settings nouveau/hwmon: Add nouveau_hwmon_ops structure with .is_visible/.read_string nouveau/hwmon: Remove old code, add .write/.read operations nouveau/hwmon: expose the auto_point and pwm_min/max attrs nouveau/hwmon: Change permissions to numeric drivers/gpu/drm/nouveau/nouveau_hwmon.c | 979 +++++++++++++++----------------- 1...

..._set in "nouveau_temp_is_visible". This patchseries replaces the deprecated hwmon_device_register function with the new one hwmon_device_register_with_info. It also does some cleanup. Oscar Salvador (5): nouveau_hwmon: Add config for all sensors and their settings nouveau_hwmon: Add nouveau_hwmon_ops structure with .is_visible/.read_string nouveau_hwmon: Remove old code, add .write/.read operations nouveau_hwmon: Add support for auto_point attributes nouveau_hwmon: Change permissions to numeric drivers/gpu/drm/nouveau/nouveau_hwmon.c | 953 +++++++++++++++++--------------- 1 file c...

...lement the code inside nouveau_temp_write This patchseries replaces the deprecated hwmon_device_register function with the new one hwmon_device_register_with_info. It also does some cleanup. Oscar Salvador (5): nouveau/hwmon: Add config for all sensors and their settings nouveau/hwmon: Add nouveau_hwmon_ops structure with .is_visible/.read_string nouveau/hwmon: Remove old code, add .write/.read operations nouveau/hwmon: expose the auto_point and pwm_min/max attrs nouveau/hwmon: Change permissions to numeric drivers/gpu/drm/nouveau/nouveau_hwmon.c | 996 +++++++++++++++++--------------- 1...

...rations, and create all functions regarding these operations. 4/ We add support for special attributes like *_auto_point*. 5/ Cleanup: Change permissions to numeric and add me to the author Oscar Salvador (5): nouveau_hwmon: Add config for all sensors and their settings nouveau_hwmon: Add nouveau_hwmon_ops structure with .is_visible/.read_string nouveau_hwmon: Remove old code, add .write/.read operations nouveau_hwmon: Add support for auto_point attributes nouveau_hwmon: Change permissions to numeric drivers/gpu/drm/nouveau/nouveau_hwmon.c | 955 +++++++++++++++++--------------- 1 file c...

...> > This patchseries replaces the deprecated hwmon_device_register function with the > new one hwmon_device_register_with_info. > It also does some cleanup. > > Oscar Salvador (5): > nouveau/hwmon: Add config for all sensors and their settings > nouveau/hwmon: Add nouveau_hwmon_ops structure with > .is_visible/.read_string > nouveau/hwmon: Remove old code, add .write/.read operations > nouveau/hwmon: expose the auto_point and pwm_min/max attrs > nouveau/hwmon: Change permissions to numeric > > drivers/gpu/drm/nouveau/nouveau_hwmon.c | 979 +...

...sensor_types type, u32 attr, + int channel, long val) +{ + switch (type) { + case hwmon_temp: + return nouveau_temp_write(dev, attr, channel, val); + case hwmon_pwm: + return nouveau_pwm_write(dev, attr, channel, val); + default: + return -EOPNOTSUPP; + } +} + +static const struct hwmon_ops nouveau_hwmon_ops = { + .is_visible = nouveau_is_visible, + .read = nouveau_read, + .read_string = nouveau_read_string, + .write = nouveau_write, +}; + +static const struct hwmon_chip_info nouveau_chip_info = { + .ops = &nouveau_hwmon_ops, + .info = nouveau_info, }; #endif @@ -700,90 +905,36 @@ nouveau_hwmo...

...; + return nouveau_temp_write(dev, attr, channel, val); > + case hwmon_pwm: > + return nouveau_pwm_write(dev, attr, channel, val); > + default: > + return -EOPNOTSUPP; > + } > +} > + > +static const struct hwmon_ops nouveau_hwmon_ops = { > + .is_visible = nouveau_is_visible, > + .read = nouveau_read, > + .read_string = nouveau_read_string, > + .write = nouveau_write, > +}; > + > +static const struct hwmon_chip_info nouveau_chip_info = { > + .ops = &nouveau_hwmon_ops, &g...

...SUPP; + } +} + +static int +nouveau_write(struct device *dev, enum hwmon_sensor_types type, u32 attr, + int channel, long val) +{ + switch (type) { + case hwmon_pwm: + return nouveau_pwm_write(dev, attr, channel, val); + default: + return -EOPNOTSUPP; + } +} + static const struct hwmon_ops nouveau_hwmon_ops = { .is_visible = nouveau_is_visible, - .read = NULL, + .read = nouveau_read, .read_string = nouveau_read_string, - .write = NULL, + .write = nouveau_write, }; static const struct hwmon_chip_info nouveau_chip_info = { @@ -942,8 +792,6 @@ nouveau_hwmon_init(struct drm_device *dev) #if defi...