search for: nouveau_gem_ioctl_new

...TL_DEF_DRV(NOUVEAU_GPUOBJ_FREE, nouveau_abi16_ioctl_gpuobj_free, DRM_AUTH|DRM_RENDER_ALLOW), - DRM_IOCTL_DEF_DRV(NOUVEAU_SVM_INIT, nouveau_svmm_init, DRM_AUTH|DRM_RENDER_ALLOW), - DRM_IOCTL_DEF_DRV(NOUVEAU_SVM_BIND, nouveau_svmm_bind, DRM_AUTH|DRM_RENDER_ALLOW), - DRM_IOCTL_DEF_DRV(NOUVEAU_GEM_NEW, nouveau_gem_ioctl_new, DRM_AUTH|DRM_RENDER_ALLOW), - DRM_IOCTL_DEF_DRV(NOUVEAU_GEM_PUSHBUF, nouveau_gem_ioctl_pushbuf, DRM_AUTH|DRM_RENDER_ALLOW), - DRM_IOCTL_DEF_DRV(NOUVEAU_GEM_CPU_PREP, nouveau_gem_ioctl_cpu_prep, DRM_AUTH|DRM_RENDER_ALLOW), - DRM_IOCTL_DEF_DRV(NOUVEAU_GEM_CPU_FINI, nouveau_gem_ioctl_cpu_fini, DRM_AU...

...au]) from [<bf0bdbd0>] (nouveau_gem_object_open+0x124/0x158 [nouveau]) [ 270.588196] [<bf0bdbd0>] (nouveau_gem_object_open [nouveau]) from [<c02da62c>] (drm_gem_handle_create_tail+0x104/0x19c) [ 270.599025] [<c02da62c>] (drm_gem_handle_create_tail) from [<bf0be138>] (nouveau_gem_ioctl_new+0x90/0x18c [nouveau]) [ 270.609594] [<bf0be138>] (nouveau_gem_ioctl_new [nouveau]) from [<c02db3b8>] (drm_ioctl+0x284/0x440) [ 270.618777] [<c02db3b8>] (drm_ioctl) from [<bf0b6bfc>] (nouveau_drm_ioctl+0x54/0x98 [nouveau]) [ 270.627441] [<bf0b6bfc>] (nouveau_drm_ioct...

...[<00000000ef2537ed>] nouveau_mem_map+0x79/0xd0 [<0000000014ddc0cf>] nouveau_vma_new+0x19d/0x1c0 [<00000000f99888a1>] nouveau_gem_object_open+0xd4/0x140 [<000000009cd25861>] drm_gem_handle_create_tail+0xe3/0x160 [<00000000191784d9>] nouveau_gem_ioctl_new+0x6e/0xd0 [<00000000159678df>] drm_ioctl_kernel+0x8c/0xd0 [<00000000fbaa6154>] drm_ioctl+0x1c4/0x360 [<000000006833fe15>] nouveau_drm_ioctl+0x63/0xb0 Wondering if those are real leaks or just false positives. For now I marked `tags' as kmemleak_not_le...

...0000000000 x4 : 00000000ffffffff [ 16.997860] x3 : 0000000000000004 x2 : 0000000000000005 [ 17.003157] x1 : 0000000000000006 x0 : ffff8001c8b7ce8c [ 17.008456] Call trace: [ 17.011066] nouveau_bo_new+0x450/0x4d0 [nouveau] [ 17.015924] nouveau_gem_new+0xa4/0x148 [nouveau] [ 17.020771] nouveau_gem_ioctl_new+0x48/0xd8 [nouveau] [ 17.025953] drm_ioctl_kernel+0x70/0xd8 [drm] [ 17.030343] drm_ioctl+0x180/0x3e0 [drm] [ 17.034424] nouveau_drm_ioctl+0x6c/0xc8 [nouveau] [ 17.039207] do_vfs_ioctl+0xb0/0x730 [ 17.042771] SyS_ioctl+0x8c/0xa8 [ 17.045991] el0_svc_naked+0x20/0x24 [ 17.049555] -...

.../0x490 [ +0.000010] ttm_bo_init+0x2f/0xa0 [ +0.000009] ? nouveau_bo_invalidate_caches+0x10/0x10 [ +0.000005] nouveau_bo_new+0x416/0x590 [ +0.000007] ? nouveau_bo_invalidate_caches+0x10/0x10 [ +0.000009] ? nouveau_gem_new+0x100/0x100 [ +0.000004] nouveau_gem_new+0x49/0x100 [ +0.000009] nouveau_gem_ioctl_new+0x41/0xc0 [ +0.000009] drm_ioctl_kernel+0x59/0xb0 [ +0.000008] drm_ioctl+0x2c1/0x350 [ +0.000007] ? nouveau_gem_new+0x100/0x100 [ +0.000012] ? _raw_spin_unlock_irqrestore+0x4d/0x90 [ +0.000006] ? preempt_count_sub+0x9b/0xd0 [ +0.000005] ? _raw_spin_unlock_irqrestore+0x6b/0x90 [ +0.0000...

...ouveau_abi16_ioctl_gpuobj_free, DRM_AUTH|DRM_RENDER_ALLOW), > - DRM_IOCTL_DEF_DRV(NOUVEAU_SVM_INIT, nouveau_svmm_init, DRM_AUTH|DRM_RENDER_ALLOW), > - DRM_IOCTL_DEF_DRV(NOUVEAU_SVM_BIND, nouveau_svmm_bind, DRM_AUTH|DRM_RENDER_ALLOW), > - DRM_IOCTL_DEF_DRV(NOUVEAU_GEM_NEW, nouveau_gem_ioctl_new, DRM_AUTH|DRM_RENDER_ALLOW), > - DRM_IOCTL_DEF_DRV(NOUVEAU_GEM_PUSHBUF, nouveau_gem_ioctl_pushbuf, DRM_AUTH|DRM_RENDER_ALLOW), > - DRM_IOCTL_DEF_DRV(NOUVEAU_GEM_CPU_PREP, nouveau_gem_ioctl_cpu_prep, DRM_AUTH|DRM_RENDER_ALLOW), > - DRM_IOCTL_DEF_DRV(NOUVEAU_GEM_CPU_FINI, n...

...x3e0 [ 1143.133957] __get_free_pages+0xd/0x40 [ 1143.133962] kvfree_call_rcu+0x135/0x210 [ 1143.134002] nouveau_fence_unref+0x36/0x50 [nouveau] [ 1143.134045] validate_fini_no_ticket.isra.8+0x138/0x240 [nouveau] [ 1143.134090] nouveau_gem_ioctl_pushbuf+0x10c8/0x1cb0 [nouveau] [ 1143.134136] ? nouveau_gem_ioctl_new+0xc0/0xc0 [nouveau] [ 1143.134159] ? drm_ioctl_kernel+0x91/0xe0 [drm] [ 1143.134170] drm_ioctl_kernel+0x91/0xe0 [drm] [ 1143.134182] drm_ioctl+0x2db/0x380 [drm] [ 1143.134211] ? nouveau_gem_ioctl_new+0xc0/0xc0 [nouveau] [ 1143.134217] ? _raw_spin_unlock_irqrestore+0x47/0x60 [ 1143.134222] ? l...

...me/kas/linux/torvalds/drivers/gpu/drm/nouveau/nouveau_fence.c:423) [drm:drm_vblank_enable] enabling vblank on crtc 0, ret: 0 nouveau_gem_ioctl_pushbuf (/home/kas/linux/torvalds/drivers/gpu/drm/nouveau/nouveau_gem.c:852) [drm:drm_ioctl] pid=3327, dev=0xe200, auth=1, DRM_IOCTL_CRTC_QUEUE_SEQUENCE ? nouveau_gem_ioctl_new (/home/kas/linux/torvalds/drivers/gpu/drm/nouveau/nouveau_gem.c:680) ? drm_ioctl_kernel (/home/kas/linux/torvalds/drivers/gpu/drm/drm_ioctl.c:793) ? nouveau_gem_ioctl_new (/home/kas/linux/torvalds/drivers/gpu/drm/nouveau/nouveau_gem.c:680) drm_ioctl_kernel (/home/kas/linux/torvalds/drivers/gpu/d...

...localdomain kernel: nouveau_bo_sync_for_device+0x80/0xc0 [nouveau] jul 28 17:16:25 localhost.localdomain kernel: nouveau_bo_validate+0x68/0x90 [nouveau] jul 28 17:16:25 localhost.localdomain kernel: nouveau_gem_ioctl_pushbuf+0x84a/0x1500 [nouveau] jul 28 17:16:25 localhost.localdomain kernel: ? nouveau_gem_ioctl_new+0xe0/0xe0 [nouveau] jul 28 17:16:25 localhost.localdomain kernel: ? drm_ioctl_kernel+0xaa/0xf0 [drm] jul 28 17:16:25 localhost.localdomain kernel: ? nouveau_gem_ioctl_new+0xe0/0xe0 [nouveau] jul 28 17:16:25 localhost.localdomain kernel: drm_ioctl_kernel+0xaa/0xf0 [drm] jul 28 17:16:25 localhost....

...80 FS: 00007fb65997f700(0000) GS:ffff9a53f6cc0000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00000001067fdb67 CR3: 000000013d42d000 CR4: 00000000000406e0 Call Trace: nouveau_fence_new+0x42/0xc0 [nouveau] nouveau_gem_ioctl_pushbuf+0xe30/0x1230 [nouveau] ? nouveau_gem_ioctl_new+0xf0/0xf0 [nouveau] drm_ioctl_kernel+0xcc/0x110 [drm] drm_ioctl+0x202/0x390 [drm] ? nouveau_gem_ioctl_new+0xf0/0xf0 [nouveau] nouveau_drm_ioctl+0x91/0xd0 [nouveau] ksys_ioctl+0xa4/0xd0 __x64_sys_ioctl+0x16/0x20 do_syscall_64+0x48/0x140 entry_SYSCALL_64_after_hwframe+0x44/0xa9 RIP: 0033:0x7f...

On Thu, 2018-05-10 at 12:28 +0200, Mike Galbraith wrote: > On Thu, 2018-05-10 at 11:10 +0200, Mike Galbraith wrote: > > Greetings, > > > > When box is earning its keep, nouveau/swiotlb grumble.. a LOT. The > > below is from master.today. > > > > [12594.640959] nouveau 0000:01:00.0: swiotlb buffer is full (sz: 2097152 bytes) > > [12594.693000] nouveau

...+0.000009] ? nouveau_bo_invalidate_caches+0x10/0x10 >> [ +0.000005] nouveau_bo_new+0x416/0x590 >> [ +0.000007] ? nouveau_bo_invalidate_caches+0x10/0x10 >> [ +0.000009] ? nouveau_gem_new+0x100/0x100 >> [ +0.000004] nouveau_gem_new+0x49/0x100 >> [ +0.000009] nouveau_gem_ioctl_new+0x41/0xc0 >> [ +0.000009] drm_ioctl_kernel+0x59/0xb0 >> [ +0.000008] drm_ioctl+0x2c1/0x350 >> [ +0.000007] ? nouveau_gem_new+0x100/0x100 >> [ +0.000012] ? _raw_spin_unlock_irqrestore+0x4d/0x90 >> [ +0.000006] ? preempt_count_sub+0x9b/0xd0 >> [ +0.00000...

Hi Thierry, Thanks for the patch. I applied on top of linux-next-2017-12-14. Different output this time. [ 11.862495] WARNING: CPU: 1 PID: 254 at drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgf100.c:391 gf100_vmm_new_+0x60/0x128 [nouveau] [ 11.863458] tegra-dpaux 155c0000.dpaux: 155c0000.dpaux supply vdd not found, using dummy regulator [ 11.866197] tegra-sor 15580000.sor: failed to probe

...lds/drivers/gpu/drm/nouveau/nouveau_fence.c:423) > [drm:drm_vblank_enable] enabling vblank on crtc 0, ret: 0 > nouveau_gem_ioctl_pushbuf (/home/kas/linux/torvalds/drivers/gpu/drm/nouveau/nouveau_gem.c:852) > [drm:drm_ioctl] pid=3327, dev=0xe200, auth=1, DRM_IOCTL_CRTC_QUEUE_SEQUENCE > ? nouveau_gem_ioctl_new (/home/kas/linux/torvalds/drivers/gpu/drm/nouveau/nouveau_gem.c:680) > ? drm_ioctl_kernel (/home/kas/linux/torvalds/drivers/gpu/drm/drm_ioctl.c:793) > ? nouveau_gem_ioctl_new (/home/kas/linux/torvalds/drivers/gpu/drm/nouveau/nouveau_gem.c:680) > drm_ioctl_kernel (/home/kas/linux/torvalds/d...

...80 FS: 00007fb65997f700(0000) GS:ffff9a53f6cc0000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00000001067fdb67 CR3: 000000013d42d000 CR4: 00000000000406e0 Call Trace: nouveau_fence_new+0x42/0xc0 [nouveau] nouveau_gem_ioctl_pushbuf+0xe30/0x1230 [nouveau] ? nouveau_gem_ioctl_new+0xf0/0xf0 [nouveau] drm_ioctl_kernel+0xcc/0x110 [drm] drm_ioctl+0x202/0x390 [drm] ? nouveau_gem_ioctl_new+0xf0/0xf0 [nouveau] nouveau_drm_ioctl+0x91/0xd0 [nouveau] ksys_ioctl+0xa4/0xd0 __x64_sys_ioctl+0x16/0x20 do_syscall_64+0x48/0x140 entry_SYSCALL_64_after_hwframe+0x44/0xa9 RIP: 0033:0x7f...

...1313.811141] ? nv10_bo_put_tile_region+0x60/0x60 [nouveau] [ 1313.811163] nouveau_bo_new+0x465/0x5e0 [nouveau] [ 1313.811184] ? nv10_bo_put_tile_region+0x60/0x60 [nouveau] [ 1313.811203] nouveau_gem_new+0x66/0x110 [nouveau] [ 1313.811223] ? nouveau_gem_new+0x110/0x110 [nouveau] [ 1313.811241] nouveau_gem_ioctl_new+0x48/0xc0 [nouveau] [ 1313.811249] drm_ioctl_kernel+0x64/0xb0 [drm] [ 1313.811257] drm_ioctl+0x2a4/0x360 [drm] [ 1313.811276] ? nouveau_gem_new+0x110/0x110 [nouveau] [ 1313.811285] ? drm_ioctl+0x5/0x360 [drm] [ 1313.811304] nouveau_drm_ioctl+0x50/0xb0 [nouveau] [ 1313.811308] do_vfs_ioctl+0x9...

Thanks to Thierry for finding this - applying index e14643615698..00eeaaffeae5 100644 --- a/drivers/gpu/drm/nouveau/nvkm/engine/device/base.c +++ b/drivers/gpu/drm/nouveau/nvkm/engine/device/base.c @@ -2369,7 +2369,7 @@ nv13b_chipset = { .imem = gk20a_instmem_new, .ltc = gp100_ltc_new, .mc = gp10b_mc_new, - .mmu = gf100_mmu_new, + .mmu = gp10b_mmu_new,

Accept the DRM_FORMAT_MOD_NVIDIA_16BX2_BLOCK() family of modifiers to handle broken userspace Xorg modesetting and Mesa drivers. Tested with Xorg 1.20 modesetting driver, weston at c46c70dac84a4b3030cd05b380f9f410536690fc, gnome & KDE wayland desktops from Ubuntu 18.04, and sway 1.5 Signed-off-by: James Jones <jajones at nvidia.com> --- drivers/gpu/drm/nouveau/nouveau_display.c | 26

...[ 469.932008] ? nouveau_vma_map+0x44/0x70 [nouveau] [ 469.932011] ttm_bo_handle_move_mem+0x10b/0x4f0 [ttm] [ 469.932013] ttm_bo_validate+0x11b/0x130 [ttm] [ 469.932032] nouveau_bo_validate+0x59/0x90 [nouveau] [ 469.932051] nouveau_gem_ioctl_pushbuf+0x323/0xbd0 [nouveau] [ 469.932069] ? nouveau_gem_ioctl_new+0xe0/0xe0 [nouveau] [ 469.932076] drm_ioctl_kernel+0xaa/0xf0 [drm] [ 469.932081] drm_ioctl+0x1f7/0x390 [drm] [ 469.932099] ? nouveau_gem_ioctl_new+0xe0/0xe0 [nouveau] [ 469.932101] ? try_to_wake_up+0x53/0x5f0 [ 469.932120] nouveau_drm_ioctl+0x63/0xb0 [nouveau] [ 469.932122] do_vfs_ioctl...

The LRU list used for recycling CPU mappings was handling concurrency very poorly. For instance, if an instobj was acquired twice before being released once, it would end up into the LRU list even though there is still a client accessing it. This patch fixes this by properly counting how many clients are currently using a given instobj. While at it, we also raise errors when inconsistencies are