Displaying 20 results from an estimated 23 matches for "nouveau_drm_postclose".
2017 Jul 12
2
[PATCH] drm/nouveau: split nouveau_drm_postclose back in pre/postclose
This patch brings back the old nouveau_drm_preclose and nouveau_drm_postclose
functions for closing down a drm device
Signed-off-by: Tobias Klausmann <tobias.johannes.klausmann at mni.thm.de>
---
drivers/gpu/drm/nouveau/nouveau_drm.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouv...
2017 Mar 08
1
[PATCH 14/24] drm/nouveau: Merge pre/postclose hooks
...dex f0bb7606eb8b..0e26be017de7 100644
--- a/drivers/gpu/drm/nouveau/nouveau_drm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
@@ -881,7 +881,7 @@ nouveau_drm_open(struct drm_device *dev, struct drm_file *fpriv)
}
static void
-nouveau_drm_preclose(struct drm_device *dev, struct drm_file *fpriv)
+nouveau_drm_postclose(struct drm_device *dev, struct drm_file *fpriv)
{
struct nouveau_cli *cli = nouveau_cli(fpriv);
struct nouveau_drm *drm = nouveau_drm(dev);
@@ -897,12 +897,6 @@ nouveau_drm_preclose(struct drm_device *dev, struct drm_file *fpriv)
list_del(&cli->head);
mutex_unlock(&drm->clien...
2017 May 08
1
[PATCH RESEND 1/4] drm/nouveau: Merge pre/postclose hooks
...dex 2b6ac24ce690..ec719df619a6 100644
--- a/drivers/gpu/drm/nouveau/nouveau_drm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
@@ -881,7 +881,7 @@ nouveau_drm_open(struct drm_device *dev, struct drm_file *fpriv)
}
static void
-nouveau_drm_preclose(struct drm_device *dev, struct drm_file *fpriv)
+nouveau_drm_postclose(struct drm_device *dev, struct drm_file *fpriv)
{
struct nouveau_cli *cli = nouveau_cli(fpriv);
struct nouveau_drm *drm = nouveau_drm(dev);
@@ -897,12 +897,6 @@ nouveau_drm_preclose(struct drm_device *dev, struct drm_file *fpriv)
list_del(&cli->head);
mutex_unlock(&drm->clien...
2017 Jul 12
2
[regression drm/noveau] suspend to ram -> BOOM: exception RIP: drm_calc_vbltimestamp_from_scanoutpos+335
On Wed, 2017-07-12 at 07:37 -0400, Ilia Mirkin wrote:
> On Wed, Jul 12, 2017 at 7:25 AM, Mike Galbraith <efault at gmx.de> wrote:
> > On Wed, 2017-07-12 at 11:55 +0200, Mike Galbraith wrote:
> >> On Tue, 2017-07-11 at 14:22 -0400, Ilia Mirkin wrote:
> >> >
> >> > Some display stuff did change for 4.13 for GM20x+ boards. If it's not
> >>
2019 May 27
2
[PATCH 08/13] drm/nouveau: drop DRM_AUTH from DRM_RENDER_ALLOW ioctls
...----
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c
index 22cd45845e07..ff5994c0d429 100644
--- a/drivers/gpu/drm/nouveau/nouveau_drm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
@@ -1045,20 +1045,20 @@ nouveau_drm_postclose(struct drm_device *dev, struct drm_file *fpriv)
static const struct drm_ioctl_desc
nouveau_ioctls[] = {
- DRM_IOCTL_DEF_DRV(NOUVEAU_GETPARAM, nouveau_abi16_ioctl_getparam, DRM_AUTH|DRM_RENDER_ALLOW),
+ DRM_IOCTL_DEF_DRV(NOUVEAU_GETPARAM, nouveau_abi16_ioctl_getparam, DRM_RENDER_ALLOW),
DRM_IO...
2020 Nov 03
4
[PATCH 0/3] drm/nouveau: fix a use-after-free in postclose()
This series fixes a number of use-after-frees in nouveau's postclose()
handler. It was discovered by pointing IGT's core_hotunplug tests at a
nouveau device, but the steps to reproduce it are simple:
1. Open the device file
2. Unbind the driver or remove the device
3. Close the file opened in step 1.
During the device removal, the nouveau_drm structure is de-allocated,
but is
2019 May 22
3
[PATCH 2/2] drm/nouveau: remove open-coded drm_invalid_op()
...);
int nouveau_abi16_ioctl_grobj_alloc(ABI16_IOCTL_ARGS);
diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c
index 22cd45845e07..ed45ad2b72f2 100644
--- a/drivers/gpu/drm/nouveau/nouveau_drm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
@@ -1046,7 +1046,7 @@ nouveau_drm_postclose(struct drm_device *dev, struct drm_file *fpriv)
static const struct drm_ioctl_desc
nouveau_ioctls[] = {
DRM_IOCTL_DEF_DRV(NOUVEAU_GETPARAM, nouveau_abi16_ioctl_getparam, DRM_AUTH|DRM_RENDER_ALLOW),
- DRM_IOCTL_DEF_DRV(NOUVEAU_SETPARAM, nouveau_abi16_ioctl_setparam, DRM_AUTH|DRM_MASTER|DRM_ROOT_...
2019 May 23
0
[PATCH 2/2] drm/nouveau: remove open-coded drm_invalid_op()
...tl_grobj_alloc(ABI16_IOCTL_ARGS);
> diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c
> index 22cd45845e07..ed45ad2b72f2 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_drm.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
> @@ -1046,7 +1046,7 @@ nouveau_drm_postclose(struct drm_device *dev, struct drm_file *fpriv)
> static const struct drm_ioctl_desc
> nouveau_ioctls[] = {
> DRM_IOCTL_DEF_DRV(NOUVEAU_GETPARAM, nouveau_abi16_ioctl_getparam, DRM_AUTH|DRM_RENDER_ALLOW),
> - DRM_IOCTL_DEF_DRV(NOUVEAU_SETPARAM, nouveau_abi16_ioctl_setpara...
2019 Jun 06
0
[PATCH 08/13] drm/nouveau: drop DRM_AUTH from DRM_RENDER_ALLOW ioctls
...rtions(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c
> index 22cd45845e07..ff5994c0d429 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_drm.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
> @@ -1045,20 +1045,20 @@ nouveau_drm_postclose(struct drm_device *dev, struct drm_file *fpriv)
>
> static const struct drm_ioctl_desc
> nouveau_ioctls[] = {
> - DRM_IOCTL_DEF_DRV(NOUVEAU_GETPARAM, nouveau_abi16_ioctl_getparam, DRM_AUTH|DRM_RENDER_ALLOW),
> + DRM_IOCTL_DEF_DRV(NOUVEAU_GETPARAM, nouveau_abi16_ioctl_ge...
2019 Jun 19
0
nouveau: DRM: GPU lockup - switching to software fbcon
...+0xbc/0x150
[10380.560408] nvkm_ioctl_del+0x2f/0x50
[10380.560409] nvkm_ioctl+0xdf/0x177
[10380.560410] nvif_object_fini+0x49/0x60
[10380.560412] nouveau_channel_del+0x89/0x110
[10380.560413] nouveau_abi16_chan_fini.isra.0+0xa0/0x110
[10380.560414] nouveau_abi16_fini+0x2d/0x60
[10380.560416] nouveau_drm_postclose+0x4c/0xe0
[10380.560418] drm_file_free.part.0+0x1e0/0x290
[10380.560420] drm_release+0xa7/0xe0
[10380.591300] __fput+0xc7/0x250
[10380.592291] task_work_run+0x90/0xc0
[10380.593271] do_exit+0x286/0xb10
[10380.594306] do_group_exit+0x33/0xa0
[10380.595333] get_signal+0x12d/0x7e0
[10380.596304...
2019 Nov 26
0
nouveau regression [bisected] hotplug broken on gf108 since 4.1
...+ goto fail_pci; */
ret = drm_dev_register(drm_dev, pent->driver_data);
if (ret)
@@ -1051,6 +1051,7 @@ driver_stub = {
DRIVER_GEM | DRIVER_MODESET | DRIVER_PRIME | DRIVER_RENDER |
DRIVER_KMS_LEGACY_CONTEXT,
+ .load = nouveau_drm_load,
.open = nouveau_drm_open,
.postclose = nouveau_drm_postclose,
.lastclose = nouveau_vga_lastclose,
And with 4.20 that fixes things, on 5.4 I get an oops with this hack
which I've not debugged further since this is not a proper solution.
2018 Apr 16
2
[Bug 106080] New: Time-out in `nvkm_fifo_chan_child_fini()`
...bicoid.molgen.mpg.de kernel: nouveau_channel_del+0x6e/0x110
[nouveau]
Apr 14 02:19:08 bicoid.molgen.mpg.de kernel:
nouveau_abi16_chan_fini.isra.0+0xa1/0xe0 [nouveau]
Apr 14 02:19:08 bicoid.molgen.mpg.de kernel: nouveau_abi16_fini+0x2d/0x70
[nouveau]
Apr 14 02:19:08 bicoid.molgen.mpg.de kernel: nouveau_drm_postclose+0x4b/0xd0
[nouveau]
Apr 14 02:19:08 bicoid.molgen.mpg.de kernel: drm_release+0x264/0x380 [drm]
Apr 14 02:19:08 bicoid.molgen.mpg.de kernel: __fput+0xa6/0x1e0
Apr 14 02:19:08 bicoid.molgen.mpg.de kernel: task_work_run+0x7e/0xa0
Apr 14 02:19:08 bicoid.molgen.mpg.de kernel: do_exit+0x2bc/0xb20
Apr...
2020 Oct 23
0
kvm+nouveau induced lockdep gripe
...974] nvkm_ioctl_del+0x7e/0xa0 [nouveau]
[ 70.135997] nvkm_ioctl+0x10a/0x240 [nouveau]
[ 70.136019] nvif_object_dtor+0x4a/0x60 [nouveau]
[ 70.136040] nvif_client_dtor+0xe/0x40 [nouveau]
[ 70.136085] nouveau_cli_fini+0x7a/0x90 [nouveau]
[ 70.136128] nouveau_drm_postclose+0xaa/0xe0 [nouveau]
[ 70.136150] drm_file_free.part.7+0x273/0x2c0 [drm]
[ 70.136165] drm_release+0x6e/0xf0 [drm]
[ 70.136171] __fput+0xb2/0x260
[ 70.136177] task_work_run+0x73/0xc0
[ 70.136183] exit_to_user_mode_prepare+0x1a5/0x1d0
[ 70.136189]...
2019 Jun 14
2
nouveau: DRM: GPU lockup - switching to software fbcon
5.2.0-rc4-next-20190613
dmesg
nouveau 0000:01:00.0: DRM: GPU lockup - switching to software fbcon
nouveau 0000:01:00.0: fifo: SCHED_ERROR 0a [CTXSW_TIMEOUT]
nouveau 0000:01:00.0: fifo: runlist 0: scheduled for recovery
nouveau 0000:01:00.0: fifo: channel 5: killed
nouveau 0000:01:00.0: fifo: engine 6: scheduled for recovery
nouveau 0000:01:00.0: fifo: engine 0: scheduled for recovery
2018 Dec 07
2
next/master boot bisection: Oops in nouveau driver on jetson-tk1
...dev);
+ drm_dev_put(dev);
nvkm_device_del(&device);
}
@@ -1020,8 +1051,6 @@ driver_stub = {
DRIVER_GEM | DRIVER_MODESET | DRIVER_PRIME | DRIVER_RENDER |
DRIVER_KMS_LEGACY_CONTEXT,
- .load = nouveau_drm_load,
- .unload = nouveau_drm_unload,
.open = nouveau_drm_open,
.postclose = nouveau_drm_postclose,
.lastclose = nouveau_vga_lastclose,
-------------------------------------------------------------------------------
Git bisection log:
-------------------------------------------------------------------------------
git bisect start
# good: [84df9525b0c27f3ebc2ebb1864fa62a97fdedb7d] Linux 4.19...
2020 Oct 24
1
kvm+nouveau induced lockdep gripe
...l+0x7e/0xa0 [nouveau]
> [ 70.135997] nvkm_ioctl+0x10a/0x240 [nouveau]
> [ 70.136019] nvif_object_dtor+0x4a/0x60 [nouveau]
> [ 70.136040] nvif_client_dtor+0xe/0x40 [nouveau]
> [ 70.136085] nouveau_cli_fini+0x7a/0x90 [nouveau]
> [ 70.136128] nouveau_drm_postclose+0xaa/0xe0 [nouveau]
> [ 70.136150] drm_file_free.part.7+0x273/0x2c0 [drm]
> [ 70.136165] drm_release+0x6e/0xf0 [drm]
> [ 70.136171] __fput+0xb2/0x260
> [ 70.136177] task_work_run+0x73/0xc0
> [ 70.136183] exit_to_user_mode_prepare+0x1a5/0x1...
2018 Dec 08
0
next/master boot bisection: Oops in nouveau driver on jetson-tk1
...evice);
> }
>
> @@ -1020,8 +1051,6 @@ driver_stub = {
> DRIVER_GEM | DRIVER_MODESET | DRIVER_PRIME | DRIVER_RENDER |
> DRIVER_KMS_LEGACY_CONTEXT,
>
> - .load = nouveau_drm_load,
> - .unload = nouveau_drm_unload,
> .open = nouveau_drm_open,
> .postclose = nouveau_drm_postclose,
> .lastclose = nouveau_vga_lastclose,
> ----------------------------------------------------------------------------
> ---
>
>
> Git bisection log:
>
> ----------------------------------------------------------------------------
> ---
> git bisect start
> # go...
2018 Dec 10
2
next/master boot bisection: Oops in nouveau driver on jetson-tk1
...@@ -1020,8 +1051,6 @@ driver_stub = {
>> DRIVER_GEM | DRIVER_MODESET | DRIVER_PRIME | DRIVER_RENDER |
>> DRIVER_KMS_LEGACY_CONTEXT,
>>
>> - .load = nouveau_drm_load,
>> - .unload = nouveau_drm_unload,
>> .open = nouveau_drm_open,
>> .postclose = nouveau_drm_postclose,
>> .lastclose = nouveau_vga_lastclose,
>> ----------------------------------------------------------------------------
>> ---
>>
>>
>> Git bisection log:
>>
>> ----------------------------------------------------------------------------
>> --...
2018 Aug 23
3
[PATCH 0/3] drm/nouveau: Fixup module probe to add ->shutdown()
This series is intended to add support for shutting down the GPU on
kernel shutdown/reboot using the ->shutdown() hook, similar to what
amdgpu does. This is mainly intended to workaround a bios issue on the
P50 that was preventing nouveau from initializing the dedicated GM107
GPU on that system properly. You can find more details on this issue in
the patch labeled "Shut down GPU on kernel
2012 Aug 19
0
[PATCH 05/10] drm/nouveau: quiet some static-related sparse noise
...-void
+static void
nouveau_drm_preclose(struct drm_device *dev, struct drm_file *fpriv)
{
struct nouveau_cli *cli = nouveau_cli(fpriv);
@@ -525,7 +525,7 @@ nouveau_drm_preclose(struct drm_device *dev, struct drm_file *fpriv)
mutex_unlock(&drm->client.mutex);
}
-void
+static void
nouveau_drm_postclose(struct drm_device *dev, struct drm_file *fpriv)
{
struct nouveau_cli *cli = nouveau_cli(fpriv);
diff --git a/drivers/gpu/drm/nouveau/nouveau_irq.c b/drivers/gpu/drm/nouveau/nouveau_irq.c
index af0cfe8..9ca8afd 100644
--- a/drivers/gpu/drm/nouveau/nouveau_irq.c
+++ b/drivers/gpu/drm/nouveau/nouve...