search for: nouveau_drm_device_init

...: Thierry Reding <treding at nvidia.com> As part of commit cfea88a4d866 ("drm/nouveau: Start using new drm_dev initialization helpers"), the initialization of the Nouveau DRM device was reworked and along the way the platform driver initialization was left incomplete. Add a call to nouveau_drm_device_init() to make sure all of the structures are properly initialized. Signed-off-by: Thierry Reding <treding at nvidia.com> --- drivers/gpu/drm/nouveau/nouveau_drm.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_dr...

...nnector_add(). One thing to note here is that drm_register_connector has the following at the top: if (!connector->dev->registered) return 0; Before the troublesome commit, when we still had a load callback, this check would not be hit when nouveau_drm_load() (now nouveau_drm_device_init() ran as drm_dev_register does: dev->registered = true; if (dev->driver->load) { ret = dev->driver->load(dev, flags); if (ret) goto err_minors; } So would register the connectors directly from no...

...de <drm/drm_crtc_helper.h> > #include <drm/drm_ioctl.h> > #include <drm/drm_vblank.h> > +#include <drm/drm_managed.h> > > #include <core/gpuobj.h> > #include <core/option.h> > @@ -532,13 +534,8 @@ nouveau_parent = { > static int > nouveau_drm_device_init(struct drm_device *dev) > { > - struct nouveau_drm *drm; > int ret; > - > - if (!(drm = kzalloc(sizeof(*drm), GFP_KERNEL))) > - return -ENOMEM; > - dev->dev_private = drm; > - drm->dev = dev; > + struct nouveau_dr...

...; +#include <drm/drm_drv.h> #include <drm/drm_crtc_helper.h> #include <drm/drm_ioctl.h> #include <drm/drm_vblank.h> +#include <drm/drm_managed.h> #include <core/gpuobj.h> #include <core/option.h> @@ -532,13 +534,8 @@ nouveau_parent = { static int nouveau_drm_device_init(struct drm_device *dev) { - struct nouveau_drm *drm; int ret; - - if (!(drm = kzalloc(sizeof(*drm), GFP_KERNEL))) - return -ENOMEM; - dev->dev_private = drm; - drm->dev = dev; + struct nouveau_drm *drm = nouveau_drm(dev); nvif_parent_ctor(&nouveau_parent, &drm->parent); d...

...| 2 ++ 4 files changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c index 6f6c31a9937b..6be202081077 100644 --- a/drivers/gpu/drm/nouveau/nouveau_drm.c +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c @@ -598,9 +598,15 @@ nouveau_drm_device_init(struct drm_device *dev) goto fail_alloc; } + drm->fence_wq = alloc_workqueue("nouveau_fence_wq", 0, WQ_MAX_ACTIVE); + if (!drm->fence_wq) { + ret = -ENOMEM; + goto fail_sched_wq; + } + ret = nouveau_cli_init(drm, "DRM-master", &drm->master); if (ret) -...

...> > > > diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c > > index 6f6c31a9937b..6be202081077 100644 > > --- a/drivers/gpu/drm/nouveau/nouveau_drm.c > > +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c > > @@ -598,9 +598,15 @@ nouveau_drm_device_init(struct drm_device *dev) > > goto fail_alloc; > > } > > > > + drm->fence_wq = alloc_workqueue("nouveau_fence_wq", 0, WQ_MAX_ACTIVE); > > + if (!drm->fence_wq) { > > + ret = -ENOMEM; > > +...

On 08/12/2018 00:08, Lyude Paul wrote: > uhhhhhhhhhhhhh > didn't we fix this weeks ago? with "drm/nouveau: tegra: Call > nouveau_drm_device_init()" Yes here's the fix from Thierry: https://patchwork.freedesktop.org/patch/263587/ and I can confirm that it does fix the Oops when applied on top of next-20181206 (what I used for the bisection last week): http://lava.baylibre.com:10080/scheduler/job/71109 However the fix does...

Hello, 5.1.0-next-20190517 I'm looking at quite a lot of kmemleak reports coming from drm/nouveau/core/memory, all of which are: unreferenced object 0xffff8deec27c4ac0 (size 16): comm "Web Content", pid 5309, jiffies 4309675011 (age 68.076s) hex dump (first 16 bytes): 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace:

...ster(pdev); - - if (nouveau_atomic) - driver_pci.driver_features |= DRIVER_ATOMIC; - - ret = drm_get_pci_dev(pdev, pent, &driver_pci); - if (ret) { - nvkm_device_del(&device); - return ret; - } - - return 0; -} - static int -nouveau_drm_load(struct drm_device *dev, unsigned long flags) +nouveau_drm_device_init(struct drm_device *dev) { struct nouveau_drm *drm; int ret; @@ -613,7 +546,7 @@ nouveau_drm_load(struct drm_device *dev, unsigned long flags) } static void -nouveau_drm_unload(struct drm_device *dev) +nouveau_drm_device_fini(struct drm_device *dev) { struct nouveau_drm *drm = nouveau_dr...

...vkm_object_init+0x48/0x1b0 [ 2.154144] nvkm_ioctl_new+0x168/0x254 [ 2.154149] nvkm_ioctl+0xd0/0x220 [ 2.154153] nvkm_client_ioctl+0x10/0x1c [ 2.154162] nvif_object_ctor+0xf4/0x22c [ 2.154168] nvif_device_ctor+0x28/0x70 [ 2.154174] nouveau_cli_init+0x150/0x590 [ 2.154180] nouveau_drm_device_init+0x60/0x2a0 [ 2.154187] nouveau_platform_device_create+0x90/0xd0 [ 2.154193] nouveau_platform_probe+0x3c/0x9c [ 2.154200] platform_probe+0x68/0xc0 [ 2.154207] really_probe+0xbc/0x2dc [ 2.154211] __driver_probe_device+0x78/0xe0 [ 2.154216] driver_probe_device+0xd8/0x160 [ 2...

...+0x12/0x20 [nouveau] [ 213.318097] nvif_object_ioctl+0x4f/0x60 [nouveau] [ 213.323460] nvif_object_mthd+0x9f/0x150 [nouveau] [ 213.328822] ? nvif_object_ctor+0x14b/0x1d0 [nouveau] [ 213.334473] nvif_device_ctor+0x61/0x70 [nouveau] [ 213.339749] nouveau_cli_init+0x1a3/0x460 [nouveau] [ 213.345215] ? nouveau_drm_device_init+0x3e/0x780 [nouveau] [ 213.351454] nouveau_drm_device_init+0x77/0x780 [nouveau] [ 213.357479] ? pci_read_config_word+0x27/0x40 [ 213.362337] ? pci_enable_device_flags+0x14f/0x170 [ 213.367705] nouveau_drm_probe+0x132/0x1f0 [nouveau] [ 213.373241] local_pci_probe+0x48/0x80 [ 213.377419] work_for_cpu...

...;] nouveau_conn_reset+0x25/0xc0 [nouveau] [<000000004fd189a2>] nouveau_connector_create+0x3a7/0x610 [nouveau] [<00000000c73343a8>] nv50_display_create+0x343/0x980 [nouveau] [<000000002e2b03c3>] nouveau_display_create+0x51f/0x660 [nouveau] [<00000000c924699b>] nouveau_drm_device_init+0x182/0x7f0 [nouveau] [<00000000cc029436>] nouveau_drm_probe+0x20c/0x2c0 [nouveau] [<000000007e961c3e>] local_pci_probe+0x47/0xa0 [<00000000da14d569>] work_for_cpu_fn+0x1a/0x30 [<0000000028da4805>] process_one_work+0x27c/0x660 [<000000001d415b04>] w...

uhhhhhhhhhhhhh didn't we fix this weeks ago? with "drm/nouveau: tegra: Call nouveau_drm_device_init()" On Fri, 2018-12-07 at 23:31 +0000, Guillaume Tucker wrote: > Please find below an automated bisection report for a kernel Oops > seen during the initialisation of the nouveau GPU driver on > jetson-tk1. > > > All the LAVA test jobs for this bisection can be found here:...

...s+0x2f/0xb0 [ 18.803992] kobject_init_and_add+0x9d/0xf0 [ 18.810117] ttm_mem_global_init+0x12c/0x210 [ttm] [ 18.816853] ttm_bo_global_init+0x4a/0x160 [ttm] [ 18.823420] ttm_bo_device_init+0x39/0x220 [ttm] [ 18.830046] nouveau_ttm_init+0x2c3/0x830 [nouveau] [ 18.836929] nouveau_drm_device_init+0x1b4/0x3f0 [nouveau] <...> [ 19.105336] ================================================================== Fix this error, by not using type_vram as an index if it's negative. Assume default values instead. The error was seen on Nvidia G72 hardware. Signed-off-by: Thomas Zimmerm...

Hi folks, Currently, when the device is removed (or the driver is unbound) the nouveau_drm structure de-allocated. However, it's still accessible from and used by some DRM layer callbacks. For example, file handles can be closed after the device has been removed (physically or otherwise). This series converts the Nouveau device structure to be allocated and de-allocated with the

This series fixes a number of use-after-frees in nouveau's postclose() handler. It was discovered by pointing IGT's core_hotunplug tests at a nouveau device, but the steps to reproduce it are simple: 1. Open the device file 2. Unbind the driver or remove the device 3. Close the file opened in step 1. During the device removal, the nouveau_drm structure is de-allocated, but is

...1/0x260 [nouveau] > [ 70.135578] nvkm_ioctl+0x10a/0x240 [nouveau] > [ 70.135600] nvif_object_ctor+0xeb/0x150 [nouveau] > [ 70.135622] nvif_device_ctor+0x1f/0x60 [nouveau] > [ 70.135668] nouveau_cli_init+0x1ac/0x590 [nouveau] > [ 70.135711] nouveau_drm_device_init+0x68/0x800 [nouveau] > [ 70.135753] nouveau_drm_probe+0xfb/0x200 [nouveau] > [ 70.135761] local_pci_probe+0x42/0x90 > [ 70.135767] pci_device_probe+0xe7/0x1a0 > [ 70.135773] really_probe+0xf7/0x4d0 > [ 70.135779] driver_probe_device+0x5d/0...

On Mon, Dec 10, 2018 at 10:00:08AM +0000, Guillaume Tucker wrote: > On 08/12/2018 00:08, Lyude Paul wrote: > > uhhhhhhhhhhhhh > > didn't we fix this weeks ago? with "drm/nouveau: tegra: Call > > nouveau_drm_device_init()" > > Yes here's the fix from Thierry: > > https://patchwork.freedesktop.org/patch/263587/ > > > and I can confirm that it does fix the Oops when applied on top > of next-20181206 (what I used for the bisection last week): > > http://lava.baylibre.co...

...c 10, 2018 at 02:25:59PM +0000, Mark Brown wrote: > On Mon, Dec 10, 2018 at 10:00:08AM +0000, Guillaume Tucker wrote: > > On 08/12/2018 00:08, Lyude Paul wrote: > > > uhhhhhhhhhhhhh > > > didn't we fix this weeks ago? with "drm/nouveau: tegra: Call > > > nouveau_drm_device_init()" > > > > Yes here's the fix from Thierry: > > > > https://patchwork.freedesktop.org/patch/263587/ > > > > > > and I can confirm that it does fix the Oops when applied on top > > of next-20181206 (what I used for the bisection last wee...

...backtrace: [<000000006933ed2b>] nouveau_conn_reset+0x20/0xb0 [<00000000572e2e30>] nouveau_connector_create+0x356/0x54c [<000000008a6a13cd>] nv50_display_create+0x2fb/0x917 [<000000007fab0a58>] nouveau_display_create+0x3e6/0x600 [<000000008b8644c8>] nouveau_drm_device_init+0x149/0x6b0 [<000000004fd78a1f>] nouveau_drm_probe+0x263/0x2b0 [<00000000357716ef>] pci_device_probe+0xa3/0x110 [<00000000061d40e4>] really_probe+0xd3/0x240 [<000000000ade44b6>] driver_probe_device+0x50/0xc0 [<000000009cd0024c>] device_driver_attach...