search for: nouveau_dri2_finish_swap

Hi, here a set of patches against the nouveau-ddx. This is an extended and revised set, based on Francisco Jerez feedback from autumn last year. [1/9] Makes pageflipping work again on X-Server 1.12rc. It apparently stopped working somewhere around Xorg 1.11+. [2/9] Implements handling of pageflip completion events from the kernel. Francisco Jerez argument against including it was that the

Hi all, the following patch fixes a race-condition in the nouveau ddx which caused frequent x-server crashes for at least 1 user under some loads when OpenGL triple-buffering is enabled, which it is by default on XOrg 1.12 and later. As a side effect, it provides a small optimization for the common case of bufferswap at next vblank. The other way to avoid the race + possible crash is to set

Two "updated" patches, according to Michel Daenzers review. See separate e-mail for details. 01/10: Replaces original 01/09 -- Same code, updated commit message. 10/10: Just for demonstration, not for application to ddx.

...which changed can_exchange behavior - is due to be reverted) --- src/nouveau_dri2.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/nouveau_dri2.c b/src/nouveau_dri2.c index 588735f..3d8d22f 100644 --- a/src/nouveau_dri2.c +++ b/src/nouveau_dri2.c @@ -328,7 +328,8 @@ nouveau_dri2_finish_swap(DrawablePtr draw, unsigned int frame, type = DRI2_EXCHANGE_COMPLETE; DamageRegionAppend(draw, &reg); - if (DRI2CanFlip(draw)) { + if (DRI2CanFlip(draw) && pNv->has_pageflip && + draw->type == DRAWABLE_WINDOW) { type = DRI2_FLIP_COMPLETE; ret = drmmode_...

...and nouveau_exa_scratch. After that xorg stays up long enough to crash in nouveau_exa_share_pixmap_backing, I'm still investigating that. :-) diff --git a/src/nouveau_dri2.c b/src/nouveau_dri2.c index e3445b2..69fcd8c 100644 --- a/src/nouveau_dri2.c +++ b/src/nouveau_dri2.c @@ -684,7 +684,7 @@ nouveau_dri2_finish_swap(DrawablePtr draw, unsigned int frame, /* Reference the back buffer to sync it to vblank */ nouveau_pushbuf_refn(push, &(struct nouveau_pushbuf_refn) { src_bo, - NOUVEAU_BO_VRAM | NOUVEAU_BO_RD + NOUVEAU_BO_APER | NOUVEAU_BO_RD }, 1); if (pNv->Archi...

...lt: on. .TP .BI "Option \*qZaphodHeads\*q \*q" string \*q Specify the randr output(s) to use with zaphod mode for a particular driver diff --git a/src/nouveau_dri2.c b/src/nouveau_dri2.c index 0b3cc38..62333b1 100644 --- a/src/nouveau_dri2.c +++ b/src/nouveau_dri2.c @@ -316,6 +316,9 @@ nouveau_dri2_finish_swap(DrawablePtr draw, unsigned int frame, NOUVEAU_BO_VRAM | NOUVEAU_BO_RD }, 1); + if (pNv->Architecture >= NV_ARCH_C0) + NVC0SyncToVBlank(dst_pix, REGION_EXTENTS(0, &reg)); + else if (pNv->Architecture >= NV_ARCH_50) NV50SyncToVBlank(dst_pix, REGION_EXTE...

...9fe9ac98eac4145" } , { "address": 139806403769020 , "build_id": "96e2a53ee9fec52e0d49af6a11d13b0ee3525e87" , "build_id_offset": 45756 , "function_name": "nouveau_dri2_finish_swap" , "file_name": "/usr/lib64/xorg/modules/drivers/nouveau_drv.so" , "fingerprint": "263fc53c053772a6dee812f56755e0642002d050" } , { "address": 139806403770353 ,...