search for: nouveau_device_create_

....90056190 100644 --- a/drivers/gpu/drm/nouveau/core/include/engine/device.h +++ b/drivers/gpu/drm/nouveau/core/include/engine/device.h @@ -3,12 +3,22 @@ #include <core/device.h> +struct platform_device; + #define nouveau_device_create(p,n,s,c,d,u) \ nouveau_device_create_((p), (n), (s), (c), (d), sizeof(**u), (void **)u) int nouveau_device_create_(struct pci_dev *, u64 name, const char *sname, const char *cfg, const char *dbg, int, void **); +#define nouveau_device_platform_create(p,n,s,c,d,u) \ + nouveau_device_platform_crea...

...make use of these functions. Some older drivers are too dependent on PCI to be properly updated, but all newer code on which future chips may depend should at least be runnable with platform devices. Signed-off-by: Alexandre Courbot <acourbot at nvidia.com> --- Changes since v1: - Refactored nouveau_device_create_() to take an additional bus type argument instead of having two versions of it that duplicate code. - Fixed a typo when substituting pci_resource_* with nv_device_resource_* - Check whether devices are PCI in relevant functions instead of nouveau_drm_load(). drivers/gpu/drm/nouveau/core/engin...

...struct platform_device *platformdev; > > I'm generally wondering if perhaps a better abstraction would be to > store a struct device * here, perhaps with a struct nouveau_device_ops * > or similar to abstract away the differences between PCI and platform > devices. > > nouveau_device_create_() could then take a struct device * and a struct > nouveau_device_ops *, and upcasting can therefore be done within these > operations, rather than sprinkling nv_device_is_pci() code everywhere. At some point I was considering having the bus abstracted as a subdev, but that sounded overkill....

...d really hard to find something wrong with this patch but it seems that you have it polished very nicely. There is one quite minor nit in-line, but I'm not fussed either way. > Signed-off-by: Alexandre Courbot <acourbot at nvidia.com> > --- > Changes since v1: > - Refactored nouveau_device_create_() to take an additional bus type > argument instead of having two versions of it that duplicate code. > - Fixed a typo when substituting pci_resource_* with nv_device_resource_* > - Check whether devices are PCI in relevant functions instead of > nouveau_drm_load(). > > driv...

...with this patch but it > seems that you have it polished very nicely. Great! > There is one quite minor nit in-line, but I'm not fussed either way. > >> Signed-off-by: Alexandre Courbot <acourbot at nvidia.com> >> --- >> Changes since v1: >> - Refactored nouveau_device_create_() to take an additional bus type >> argument instead of having two versions of it that duplicate code. >> - Fixed a typo when substituting pci_resource_* with nv_device_resource_* >> - Check whether devices are PCI in relevant functions instead of >> nouveau_drm_load()...

...> struct pci_dev *pdev; > + struct platform_device *platformdev; I'm generally wondering if perhaps a better abstraction would be to store a struct device * here, perhaps with a struct nouveau_device_ops * or similar to abstract away the differences between PCI and platform devices. nouveau_device_create_() could then take a struct device * and a struct nouveau_device_ops *, and upcasting can therefore be done within these operations, rather than sprinkling nv_device_is_pci() code everywhere. > diff --git a/drivers/gpu/drm/nouveau/nouveau_abi16.c b/drivers/gpu/drm/nouveau/nouveau_abi16.c [...] &...

...5619094d7 100644 --- a/drivers/gpu/drm/nouveau/core/include/engine/device.h +++ b/drivers/gpu/drm/nouveau/core/include/engine/device.h @@ -3,12 +3,22 @@ #include <core/device.h> +struct platform_device; + #define nouveau_device_create(p,n,s,c,d,u) \ nouveau_device_create_((p), (n), (s), (c), (d), sizeof(**u), (void **)u) int nouveau_device_create_(struct pci_dev *, u64 name, const char *sname, const char *cfg, const char *dbg, int, void **); +#define nouveau_device_platform_create(p,n,s,c,d,u) \ + nouveau_device_platform_crea...

...be(struct platform_device *pdev) +struct drm_device * +nouveau_platform_device_create_(struct platform_device *pdev, int size, + void **pobject) { - struct nouveau_device *device; - int ret; + struct drm_device *drm; + int err; - ret = nouveau_device_create(pdev, NOUVEAU_BUS_PLATFORM, + err = nouveau_device_create_(pdev, NOUVEAU_BUS_PLATFORM, nouveau_platform_name(pdev), dev_name(&pdev->dev), nouveau_config, - nouveau_debug, &device); - - ret = drm_platform_init(&driver, pdev); - if (ret) { - nouveau_object_ref(NULL, (struct nouveau_object **)&device); - return re...

This series adds support for probing platform devices on Nouveau, as well as the DT bindings for GK20A. It doesn't enable the GPU yet on Tegra boards since a few extra things need to be supported before that. This version is mostly identical to v2 but fixes an important issue: the drvdata must be set to the drm_device for sysfs to work, so the platform device structure now includes the

...* > +nouveau_platform_device_create_(struct platform_device *pdev, int size, > + void **pobject) > { > - struct nouveau_device *device; > - int ret; > + struct drm_device *drm; > + int err; > > - ret = nouveau_device_create(pdev, NOUVEAU_BUS_PLATFORM, > + err = nouveau_device_create_(pdev, NOUVEAU_BUS_PLATFORM, > nouveau_platform_name(pdev), > dev_name(&pdev->dev), nouveau_config, > - nouveau_debug, &device); > - > - ret = drm_platform_init(&driver, pdev); > - if (ret) { > - nouveau_object_ref(NULL, (struct nouveau...

This patch series is the final (?) step towards the initial support of GK20A, allowing it to be probed and used (currently at a very slow speed, and for offscreen rendering only) on the Jetson TK1 and Venice 2 boards. The main piece if the first patch which adds platform devices probing support to Nouveau. There are probably lots of things that need to be discussed about it, e.g.: * The way the

Hello everyone, GK20A is the Kepler-based GPU used in the upcoming Tegra K1 chips. The following patches perform architectural changes to Nouveau that are necessary to support non-PCI GPUs and add initial support for GK20A. Although the support is still very basic and more user-space changes will be needed to make the full graphics stack run on top of it, we were able to successfully open