search for: nouveau_cli_init

nouveau_abi16_ioctl_channel_alloc() and nouveau_cli_init() simply call their corresponding *_fini() counterpart. This can lead to nouveau_sched_fini() being called without struct nouveau_sched ever being initialized in the first place. Instead of embedding struct nouveau_sched into struct nouveau_cli and struct nouveau_chan_abi16, allocate struct nouvea...

...rivers/gpu/drm/nouveau/nouveau_drm.c @@ -598,9 +598,15 @@ nouveau_drm_device_init(struct drm_device *dev) goto fail_alloc; } + drm->fence_wq = alloc_workqueue("nouveau_fence_wq", 0, WQ_MAX_ACTIVE); + if (!drm->fence_wq) { + ret = -ENOMEM; + goto fail_sched_wq; + } + ret = nouveau_cli_init(drm, "DRM-master", &drm->master); if (ret) - goto fail_wq; + goto fail_fence_wq; ret = nouveau_cli_init(drm, "DRM", &drm->client); if (ret) @@ -670,7 +676,9 @@ nouveau_drm_device_init(struct drm_device *dev) nouveau_cli_fini(&drm->client); fail_...

...} > > > > + drm->fence_wq = alloc_workqueue("nouveau_fence_wq", 0, WQ_MAX_ACTIVE); > > + if (!drm->fence_wq) { > > + ret = -ENOMEM; > > + goto fail_sched_wq; > > + } > > + > > ret = nouveau_cli_init(drm, "DRM-master", &drm->master); > > if (ret) > > - goto fail_wq; > > + goto fail_fence_wq; > > > > ret = nouveau_cli_init(drm, "DRM", &drm->client); > > if (ret) > > @@...

On Fri, 2024-02-02 at 17:14 +0000, Timur Tabi wrote: > On Fri, 2024-02-02 at 01:05 +0100, Danilo Krummrich wrote: > > nouveau_abi16_ioctl_channel_alloc() and nouveau_cli_init() simply call > > their corresponding *_fini() counterpart. This can lead to > > nouveau_sched_fini() being called without struct nouveau_sched ever > > being initialized in the first place. > > Thanks, I've confirmed that these patches do fix the problem. Looks like...

...nvkm_udevice_init+0x60/0x9c [ 2.154140] nvkm_object_init+0x48/0x1b0 [ 2.154144] nvkm_ioctl_new+0x168/0x254 [ 2.154149] nvkm_ioctl+0xd0/0x220 [ 2.154153] nvkm_client_ioctl+0x10/0x1c [ 2.154162] nvif_object_ctor+0xf4/0x22c [ 2.154168] nvif_device_ctor+0x28/0x70 [ 2.154174] nouveau_cli_init+0x150/0x590 [ 2.154180] nouveau_drm_device_init+0x60/0x2a0 [ 2.154187] nouveau_platform_device_create+0x90/0xd0 [ 2.154193] nouveau_platform_probe+0x3c/0x9c [ 2.154200] platform_probe+0x68/0xc0 [ 2.154207] really_probe+0xbc/0x2dc [ 2.154211] __driver_probe_device+0x78/0xe0 [...

...if_vmm_init+0x340/0x340 [nouveau] [ 9.994864] ? nvkm_udevice_rd08+0x90/0x90 [nouveau] [ 10.000056] nvkm_ioctl+0x21e/0x5a0 [nouveau] [ 10.004548] ? yield_to+0x2b2/0x370 [ 10.008257] nvif_object_init+0xef/0x1b0 [nouveau] [ 10.013281] nvif_device_init+0x9/0x40 [nouveau] [ 10.018136] nouveau_cli_init+0x234/0x12f0 [nouveau] [ 10.023253] ? idr_alloc_cyclic+0x6c/0x110 [ 10.027487] ? _cond_resched+0x1d/0x80 [ 10.031366] ? kmem_cache_alloc+0x1f0/0x2d0 [ 10.035790] nouveau_drm_load+0x71/0xec0 [nouveau] [ 10.040735] drm_dev_register+0x1b4/0x330 [ 10.044872] ? pci_enable_device_flags+...

.../0x114 [nouveau] [ 7.403094] ? nvkm_client_map+0xf/0xf [nouveau] [ 7.403382] nvkm_client_ioctl+0x1c/0x22 [nouveau] [ 7.403643] nvif_object_ioctl+0x6f/0xff [nouveau] [ 7.403903] nvif_object_init+0xd4/0x1de [nouveau] [ 7.404164] nvif_device_init+0x21/0x5c [nouveau] [ 7.404453] nouveau_cli_init+0x21f/0xe1f [nouveau] [ 7.404733] ? nouveau_drm_load+0x1d/0xe11 [nouveau] [ 7.405011] nouveau_drm_load+0x54/0xe11 [nouveau] [ 7.405112] ? kernfs_new_node+0x2b/0x8e [ 7.405209] ? kernfs_create_link+0x55/0xcd [ 7.405323] ? drm_dev_register+0x12f/0x2e0 [drm] [ 7.405437] drm_dev...

..._notify+0x30/0x30 [nouveau] ? nvkm_udevice_rd08+0x30/0x30 [nouveau] nvkm_ioctl+0x168/0x240 [nouveau] ? nvif_client_init+0x42/0x110 [nouveau] nvkm_client_ioctl+0x12/0x20 [nouveau] nvif_object_ioctl+0x42/0x50 [nouveau] nvif_object_init+0xc2/0x130 [nouveau] nvif_device_init+0x12/0x30 [nouveau] nouveau_cli_init+0x15e/0x1d0 [nouveau] nouveau_drm_load+0x67/0x8b0 [nouveau] ? sysfs_do_create_link_sd.isra.2+0x70/0xb0 drm_dev_register+0x148/0x1e0 [drm] drm_get_pci_dev+0xa0/0x160 [drm] nouveau_drm_probe+0x1d9/0x260 [nouveau] Daniel

...rm_file *fpriv) get_task_comm(tmpname, current); snprintf(name, sizeof(name), "%s[%d]", tmpname, pid_nr(fpriv->pid)); - if (!(cli = kzalloc(sizeof(*cli), GFP_KERNEL))) - return ret; + if (!(cli = kzalloc(sizeof(*cli), GFP_KERNEL))) { + ret = -ENOMEM; + goto done; + } ret = nouveau_cli_init(drm, name, cli); if (ret) -- 2.17.1

...rm_file *fpriv) get_task_comm(tmpname, current); snprintf(name, sizeof(name), "%s[%d]", tmpname, pid_nr(fpriv->pid)); - if (!(cli = kzalloc(sizeof(*cli), GFP_KERNEL))) - return ret; + if (!(cli = kzalloc(sizeof(*cli), GFP_KERNEL))) { + ret = -ENOMEM; + goto done; + } ret = nouveau_cli_init(drm, name, cli); if (ret) -- 2.17.1

...[<0000000006253ff8>] nvkm_ioctl_new+0x412/0x9a0 [nouveau] [<00000000db03ae9a>] nvkm_ioctl+0x3b4/0xbe0 [nouveau] [<00000000ac40bf7e>] nvif_object_init+0x2df/0x530 [nouveau] [<00000000e98baaae>] nvif_device_init+0x12/0xe0 [nouveau] [<000000006d050b26>] nouveau_cli_init+0x4e7/0x15b0 [nouveau] [<00000000d3f314bc>] nouveau_drm_load+0x118/0x1380 [nouveau] [<000000009823b666>] drm_dev_register+0x2c5/0x5a0 [drm] [<000000001a870888>] drm_get_pci_dev+0x16d/0x4b0 [drm] [<000000004d6e667f>] nouveau_drm_probe+0x459/0x620 [nouveau]...

...[<0000000006253ff8>] nvkm_ioctl_new+0x412/0x9a0 [nouveau] [<00000000db03ae9a>] nvkm_ioctl+0x3b4/0xbe0 [nouveau] [<00000000ac40bf7e>] nvif_object_init+0x2df/0x530 [nouveau] [<00000000e98baaae>] nvif_device_init+0x12/0xe0 [nouveau] [<000000006d050b26>] nouveau_cli_init+0x4e7/0x15b0 [nouveau] [<00000000d3f314bc>] nouveau_drm_load+0x118/0x1380 [nouveau] [<000000009823b666>] drm_dev_register+0x2c5/0x5a0 [drm] [<000000001a870888>] drm_get_pci_dev+0x16d/0x4b0 [drm] [<000000004d6e667f>] nouveau_drm_probe+0x459/0x620 [nouveau]...

...lt;00000000f35056a2>] nvkm_client_ioctl+0x12/0x20 [nouveau] [<000000000f001008>] nvif_object_ioctl+0x4f/0x60 [nouveau] [<0000000098d66807>] nvif_object_ctor+0xfb/0x160 [nouveau] [<00000000fe24934a>] nvif_device_ctor+0x24/0x70 [nouveau] [<00000000878b3286>] nouveau_cli_init+0x1a3/0x460 [nouveau] [<00000000a1578335>] nouveau_drm_device_init+0x77/0x740 [nouveau] [<00000000faef6b28>] nouveau_drm_probe+0x132/0x1f0 [nouveau] Fix nvkm_iccsense_oneinit(), to free stbl.rail post iteration. Signed-off-by: Vamshi K Sthambamkadi <vamshi.k.sthambamkadi at...

...2.154140] nvkm_object_init+0x48/0x1b0 > [ 2.154144] nvkm_ioctl_new+0x168/0x254 > [ 2.154149] nvkm_ioctl+0xd0/0x220 > [ 2.154153] nvkm_client_ioctl+0x10/0x1c > [ 2.154162] nvif_object_ctor+0xf4/0x22c > [ 2.154168] nvif_device_ctor+0x28/0x70 > [ 2.154174] nouveau_cli_init+0x150/0x590 > [ 2.154180] nouveau_drm_device_init+0x60/0x2a0 > [ 2.154187] nouveau_platform_device_create+0x90/0xd0 > [ 2.154193] nouveau_platform_probe+0x3c/0x9c > [ 2.154200] platform_probe+0x68/0xc0 > [ 2.154207] really_probe+0xbc/0x2dc > [ 2.154211] __d...

One very easy to trigger runtime PM leak, along with a rare never before seen runtime PM leak! Lyude Paul (2): drm/nouveau: Fix runtime PM leak in drm_open() drm/nouveau: Fix runtime PM leak in nv50_disp_atomic_commit() drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 +- drivers/gpu/drm/nouveau/nouveau_drm.c | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) -- 2.17.1

...tl+0xf0/0x190 [nouveau] [ 213.312735] nvkm_client_ioctl+0x12/0x20 [nouveau] [ 213.318097] nvif_object_ioctl+0x4f/0x60 [nouveau] [ 213.323460] nvif_object_mthd+0x9f/0x150 [nouveau] [ 213.328822] ? nvif_object_ctor+0x14b/0x1d0 [nouveau] [ 213.334473] nvif_device_ctor+0x61/0x70 [nouveau] [ 213.339749] nouveau_cli_init+0x1a3/0x460 [nouveau] [ 213.345215] ? nouveau_drm_device_init+0x3e/0x780 [nouveau] [ 213.351454] nouveau_drm_device_init+0x77/0x780 [nouveau] [ 213.357479] ? pci_read_config_word+0x27/0x40 [ 213.362337] ? pci_enable_device_flags+0x14f/0x170 [ 213.367705] nouveau_drm_probe+0x132/0x1f0 [nouveau] [ 21...

...40 [nouveau] [ 20.863576] ? nvif_client_init+0x42/0x110 [nouveau] [ 20.865449] nvkm_client_ioctl+0x12/0x20 [nouveau] [ 20.867368] nvif_object_ioctl+0x42/0x50 [nouveau] [ 20.869237] nvif_object_init+0xc2/0x130 [nouveau] [ 20.871141] nvif_device_init+0x12/0x30 [nouveau] [ 20.872994] nouveau_cli_init+0x15e/0x1d0 [nouveau] [ 20.874873] nouveau_drm_load+0x67/0x8b0 [nouveau] [ 20.876674] ? sysfs_do_create_link_sd.isra.2+0x70/0xb0 [ 20.878451] drm_dev_register+0x148/0x1e0 [drm] [ 20.880302] drm_get_pci_dev+0xa0/0x160 [drm] [ 20.882166] nouveau_drm_probe+0x1d9/0x260 [nouveau] This ha...

With linux-next-2017-12-14, I get a crash when nouveau is loaded by systemd-udevd. [ 12.050625] Unable to handle kernel NULL pointer dereference at virtual address 00000058 [ 12.050627] Mem abort info: [ 12.050628] ESR = 0x96000004 [ 12.050630] Exception class = DABT (current EL), IL = 32 bits [ 12.050631] SET = 0, FnV = 0 [ 12.050632] EA = 0, S1PTW = 0 [ 12.050633] Data

...0x260 [nouveau] [ 8.209658] ? nvkm_client_notify+0x30/0x30 [nouveau] [ 8.209692] ? nvkm_udevice_rd08+0x20/0x20 [nouveau] [ 8.209720] nvkm_ioctl+0x100/0x240 [nouveau] [ 8.209747] nvif_object_init+0xbf/0x110 [nouveau] [ 8.209774] nvif_device_init+0xe/0x30 [nouveau] [ 8.209808] nouveau_cli_init+0x1bb/0x560 [nouveau] [ 8.209812] ? kmem_cache_alloc_trace+0x175/0x1e0 [ 8.209846] nouveau_drm_load+0x56/0x900 [nouveau] [ 8.209865] drm_dev_register+0x12f/0x1c0 [drm] [ 8.209874] drm_get_pci_dev+0x93/0x170 [drm] [ 8.209877] ? __pci_set_master+0x42/0x70 [ 8.209911] nouveau_d...

We are working with new desktop that have the NVIDIA NV118 chipset. During boot, the display becomes unusable at the point where the nouveau driver loads. We have reproduced on 4.8, 4.11 and linux master (4.12-rc3). Dmesg log is attached. Is this a known issue? Anything we can do to help? Thanks -------------- next part -------------- An HTML attachment was scrubbed... URL: