search for: notreached

...t;, + "--separator", ":", NULL); + if (r == -1) { + reply_with_error ("%s", err); + free (out); + return NULL; + } + + return filter_convert_old_lvs_output (out); } - return convert_lvm_output (out, "/dev/"); + /*NOTREACHED*/ + assert (false); + return NULL; } /* These were so complex to implement that I ended up auto-generating -- 2.5.0

...> CLEANUP_FREE char *err = NULL; > int r; > + int has_S = test_lvs_has_S_opt (); > + if (has_S < 0) > return NULL; I think this doesn't do the right thing on the second failing call to test_lvs_has_S_opt, because it won't return a protocol error? > + /*NOTREACHED*/ > + assert (false); > + return NULL; > } What's this bit for? It is indeed NOTREACHED, but it seems as if the 3 lines could just be removed. Rest looks fine, so ACK with those fixed. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read...

...perror("dup2 stderr"); #endif /* USE_PIPES */ +#ifdef _CRAY + cray_init_job(s->pw); /* set up cray jid and tmpdir */ +#endif /* _CRAY */ /* Do processing for the child (exec command etc). */ do_child(s, command); /* NOTREACHED */ } +#ifdef _CRAY + signal(WJSIGNAL, cray_job_termination_handler); +#endif /* _CRAY */ #ifdef HAVE_CYGWIN if (is_winnt) cygwin_set_impersonation_token(INVALID_HANDLE_VALUE); @@ -517,7 +527,12 @@ /* record login, etc. similar to login(1) */ #...

...d the user child sshd processes. This patch adds logging the PID of invoked commands for completeness. diff --git a/session.c b/session.c index f3baea2..dd1d0e8 100644 --- a/session.c +++ b/session.c @@ -579,6 +579,7 @@ do_exec_no_pty(Session *s, const char *command) do_child(s, command); /* NOTREACHED */ default: + verbose("command is on pid %ld", (long)pid); break; } @@ -729,6 +730,7 @@ do_exec_pty(Session *s, const char *command) do_child(s, command); /* NOTREACHED */ default: + verbose("command is on pid %ld", (long)pid); break; } -- Bruce Guent...

...perror("dup2 stderr"); #endif /* USE_PIPES */ - +#ifdef _CRAY + cray_init_job(s->pw); /* set up cray jid and tmpdir */ +#endif /* Do processing for the child (exec command etc). */ do_child(s, command); /* NOTREACHED */ } +#ifdef _CRAY + signal(WJSIGNAL, cray_job_termination_handler); +#endif /* _CRAY */ #ifdef HAVE_CYGWIN if (is_winnt) cygwin_set_impersonation_token(INVALID_HANDLE_VALUE); @@ -586,7 +595,12 @@ /* record login, etc. similar to login(1) */ #...

...cess if necessary. */ if (!(flags & EV_EXIT) || have_traps()) { INTOFF; - jp = makejob(cmd, 1); - if (forkshell(jp, cmd, FORK_FG) != 0) - break; - FORCEINTON; + jp = vforkexec(cmd, argv, path, cmdentry.u.index); + break; } shellexec(argv, path, cmdentry.u.index); /* NOTREACHED */ diff --git a/usr/dash/exec.h b/usr/dash/exec.h index 2b318257..423b07e6 100644 --- a/usr/dash/exec.h +++ b/usr/dash/exec.h @@ -58,6 +58,8 @@ struct cmdentry { #define DO_ALTPATH 0x08 /* using alternate path */ #define DO_REGBLTIN 0x10 /* regular built-ins and functions only */ +union node; +...

...*jp; - - if (pipe(pip) < 0) - sh_error("Pipe call failed"); - jp = makejob(n, 1); - if (forkshell(jp, n, FORK_NOJOB) == 0) { - FORCEINTON; - close(pip[0]); - if (pip[1] != 1) { - dup2(pip[1], 1); - close(pip[1]); - } - ifsfree(); - evaltreenr(n, EV_EXIT); - /* NOTREACHED */ + if (pipe(pip) < 0) + sh_error("Pipe call failed"); + jp = makejob(n, 1); + if (forkshell(jp, n, FORK_NOJOB) == 0) { + FORCEINTON; + close(pip[0]); + if (pip[1] != 1) { + dup2(pip[1], 1); + close(pip[1]); } - close(pip[1]); - result->fd = pip[0]; - result->jp =...

...argv, const char *path, int idx) exitstatus = exerrno; TRACE(("shellexec failed for %s, errno %d, suppressint %d\n", argv[0], e, suppressint )); - exerror(EXEXIT, "%s: %s", argv[0], errmsg(e, E_EXEC)); + exerror(EXEND, "%s: %s", argv[0], errmsg(e, E_EXEC)); /* NOTREACHED */ } diff --git a/usr/dash/main.c b/usr/dash/main.c index 6d53e009..6b3a0909 100644 --- a/usr/dash/main.c +++ b/usr/dash/main.c @@ -111,7 +111,7 @@ main(int argc, char **argv) e = exception; s = state; - if (e == EXEXIT || s == 0 || iflag == 0 || shlvl) + if (e == EXEND || e == EXEXIT...

...39,8 +339,15 @@ exitcmd(int argc, char **argv) { if (stoppedjobs()) return 0; - if (argc > 1) - exitstatus = number(argv[1]); + + if (argc > 1) { + int status = number(argv[1]); + + exitstatus = status; + if (savestatus >= 0) + savestatus = status; + } + exraise(EXEXIT); /* NOTREACHED */ } diff --git a/usr/dash/trap.c b/usr/dash/trap.c index 3ff45318..7dd8342f 100644 --- a/usr/dash/trap.c +++ b/usr/dash/trap.c @@ -313,12 +313,17 @@ void dotrap(void) char *p; char *q; int i; - int savestatus; + int status, last_status; if (!pendingsigs) return; - savestatus = exit...

...39,8 +339,15 @@ exitcmd(int argc, char **argv) { if (stoppedjobs()) return 0; - if (argc > 1) - exitstatus = number(argv[1]); + + if (argc > 1) { + int status = number(argv[1]); + + exitstatus = status; + if (savestatus >= 0) + savestatus = status; + } + exraise(EXEXIT); /* NOTREACHED */ } diff --git a/usr/dash/trap.c b/usr/dash/trap.c index 3ff45318..7dd8342f 100644 --- a/usr/dash/trap.c +++ b/usr/dash/trap.c @@ -313,12 +313,17 @@ void dotrap(void) char *p; char *q; int i; - int savestatus; + int status, last_status; if (!pendingsigs) return; - savestatus = exit...

...quired()) packet_disconnect("Password change required but no " @@ -494,6 +493,9 @@ #endif /* USE_PIPES */ /* Do processing for the child (exec command etc). */ +#if defined(USE_PAM) + do_pam_session(s->pw->pw_name, NULL); +#endif /* USE_PAM */ do_child(s, command); /* NOTREACHED */ } @@ -555,7 +557,6 @@ ttyfd = s->ttyfd; #if defined(USE_PAM) - do_pam_session(s->pw->pw_name, s->tty); do_pam_setcred(1); #endif @@ -580,6 +581,9 @@ /* Close the extra descriptor for the pseudo tty. */ close(ttyfd); +#if defined(USE_PAM) + do_pam_session(s->pw-&g...

...if (newlen > 0xa00000) fatal("buffer_append_space: alloc %u not supported", - buffer->alloc); - buffer->buf = xrealloc(buffer->buf, buffer->alloc); + newlen); + buffer->buf = xrealloc(buffer->buf, newlen); + buffer->alloc = newlen; goto restart; /* NOTREACHED */ }

...ROTECT(1); return nX; } SEXP getdim(SEXP vntX) { SEXP vntOut; int m, n; #ifdef DEBUG_GETDIM REprintf("In getdim(x)...\n"); #endif if (GetMatrixDimen(vntX, &m, &n) != 2) { error("'x' is not a two dimensional matrix"); /*NOTREACHED*/ } #ifdef DEBUG_GETDIM REprintf("\tm = %d\n", m); REprintf("\tn = %d\n", n); #endif PROTECT(vntOut = NEW_INTEGER(2)); INTEGER(vntOut)[0] = m; INTEGER(vntOut)[1] = n; UNPROTECT(1); return vntOut; } tests/getdim.R -------------- library(getdim...

...usage(); - if (strchr("eilcmpLRDo", opt)) { /* options with arguments */ + if (strchr("eilcmpLRDor", opt)) { /* options with arguments */ optarg = av[optind] + 2; if (strcmp(optarg, "") == 0) { if (optind >= ac - 1) @@ -481,6 +482,15 @@ /* NOTREACHED */ } add_local_forward(&options, fwd_port, buf, fwd_host_port); + break; + case 'r': + if (sscanf(optarg, "%255[^:]:%u", buf, + &options.proxy_port) != 2) { + fprintf(stderr, "Bad HTTP proxy '%s'.\n", optarg); + usage(); + /* N...

...if (newlen > 0xa00000) fatal("buffer_append_space: alloc %u not supported", - buffer->alloc); - buffer->buf = xrealloc(buffer->buf, buffer->alloc); + newlen); + buffer->buf = xrealloc(buffer->buf, newlen); + buffer->alloc = newlen; goto restart; /* NOTREACHED */ }

Windows usernames are case-insensitive and almost any Unicode character is allowed in a username. The user should be able to login with her username given in any case and not be refused. However, this opens up a security problem in terms of the sshd_config Match rules. The match rules for user and group names have to operate case-insensitive as well, otherwise the user can override her settings

...ouldn't fork: %s", strerror(errno)); + + if (pid == 0) { + permanently_set_uid(pw); + if (geteuid() == 0) + execl(PASSWD_PROGRAM_PATH, PASSWD_PROGRAM_PATH, + pw->pw_name, (char *)NULL); + else + execl(PASSWD_PROGRAM_PATH, PASSWD_PROGRAM_PATH, + (char *)NULL); + + /* NOTREACHED: execl shouldn't return */ + fatal("Couldn't exec %s", PASSWD_PROGRAM_PATH); + exit(1); + } + + if (waitpid(pid, &status, 0) == -1) + fatal("Couldn't wait for child: %s", strerror(errno)); + mysignal(SIGCHLD, old_signal); + + if (WIFEXITED(status) && W...

...ouldn't fork: %s", strerror(errno)); + + if (pid == 0) { + permanently_set_uid(pw); + if (geteuid() == 0) + execl(PASSWD_PROGRAM_PATH, PASSWD_PROGRAM_PATH, + pw->pw_name, (char *)NULL); + else + execl(PASSWD_PROGRAM_PATH, PASSWD_PROGRAM_PATH, + (char *)NULL); + + /* NOTREACHED: execl shouldn't return */ + fatal("Couldn't exec %s", PASSWD_PROGRAM_PATH); + exit(1); + } + + if (waitpid(pid, &status, 0) == -1) + fatal("Couldn't wait for child: %s", strerror(errno)); + mysignal(SIGCHLD, old_signal); + + if (WIFEXITED(status) && W...

...lforwardings", oClearAllForwardings }, { "nohostauthenticationforlocalhost", oNoHostAuthenticationForLocalhost }, + { "connecttimeout", oConnectTimeout }, { NULL, oBadOption } }; @@ -294,6 +296,19 @@ /* don't panic, but count bad options */ return -1; /* NOTREACHED */ + + case oConnectTimeout: + intptr = &options->connection_timeout; +parse_time: + arg = strdelim(&s); + if (!arg || *arg == '\0') + fatal("%.200s line %d: Missing time argument.", filename, linenum); + if ((value = convtime(arg)) == -1) + fatal("%.200s l...

...tart_client(argc, argv); if (ret == -1) ! exit_cleanup(RERR_STARTCLIENT); else ! exit_cleanup(ret); ! return ret; } --- 880,889 ---- ret = start_client(argc, argv); if (ret == -1) ! exit_cleanup(RERR_STARTCLIENT); else ! exit_cleanup(ret); ! ! exit(ret); ! /* NOTREACHED */ } Index: rsync3.txt =================================================================== RCS file: /cvsroot/rsync/rsync3.txt,v retrieving revision 1.3 diff -c -r1.3 rsync3.txt *** rsync3.txt 12 Sep 2001 14:35:39 -0000 1.3 --- rsync3.txt 18 Feb 2002 00:39:34 -0000 *************** *** 192,199 ***...