search for: notbol

...ere's also REG_PEND (non-POSIX, but this impl. supports it) that > allows matching patterns > with embedded NULs. Would that be needed/useful for LLVM? Maybe? If its already there and we are fine using this version of the lib always then we might as well include it. >>> +    // notbol: The match-beginning-of-line operator always fails to match, >>> +    //    unless regex was compiled with NEWLINE flag. >>> +    // noteol:  The match-end-of-line operator always fails to match. >>> +    //    unless regex was compiled with NEWLINE flag. >>> + &...

...st char *regex, unsigned Flags=NOSUB); >> + ~Regex(); >> > > I think this should have an "bool isValid(std::string &Error)" or similar > method, which would return the regex error if one was found during construction. > Ok. > >> + // notbol: The match-beginning-of-line operator always fails to match, >> + // unless regex was compiled with NEWLINE flag. >> + // noteol: The match-end-of-line operator always fails to match. >> + // unless regex was compiled with NEWLINE flag. >> + >> + boo...

...lude it. > I changed the constructor to take StringRef, and now I always use REG_PEND internally, so it works both with char* and std::string (which may not be null-terminated, or may include embedded nuls). You can add a Twine& constructor if needed ;) > >>>> + // notbol: The match-beginning-of-line operator always fails to match, >>>> + // unless regex was compiled with NEWLINE flag. >>>> + // noteol: The match-end-of-line operator always fails to match. >>>> + // unless regex was compiled with NEWLINE flag. >...

...ents just use string compare? > + > + Regex(const char *regex, unsigned Flags=NOSUB); > + ~Regex(); I think this should have an "bool isValid(std::string &Error)" or similar method, which would return the regex error if one was found during construction. > + // notbol: The match-beginning-of-line operator always fails to match, > + // unless regex was compiled with NEWLINE flag. > + // noteol: The match-end-of-line operator always fails to match. > + // unless regex was compiled with NEWLINE flag. > + > + bool matches(const char...

...ged the constructor to take  StringRef, and now I always use REG_PEND > internally, so it works both with char* and std::string (which may not > be null-terminated, or may include embedded nuls). > You can add a Twine& constructor if needed ;) > >> >>>>> +    // notbol: The match-beginning-of-line operator always fails to match, >>>>> +    //    unless regex was compiled with NEWLINE flag. >>>>> +    // noteol:  The match-end-of-line operator always fails to match. >>>>> +    //    unless regex was compiled with NEWLIN...

On 2009-08-24 20:14, Chris Lattner wrote: > On Aug 23, 2009, at 11:59 PM, Török Edwin wrote: >> If LLVM is going to have an integrated regex library I suggest using it >> regardless if the platform has one. >> The LLVM integrated regex library will provide consistent behaviour and >> execution time, the system one will not. > > Hi Edwin, > > Can you propose

On Aug 23, 2009, at 11:59 PM, Török Edwin wrote: > If LLVM is going to have an integrated regex library I suggest using > it > regardless if the platform has one. > The LLVM integrated regex library will provide consistent behaviour > and > execution time, the system one will not. Hi Edwin, Can you propose the openbsd implementation as a patch to lib/support? -Chris