search for: noneo

...on 211122) +++ lib/Driver/Tools.cpp (working copy) @@ -675,7 +675,7 @@ default: // Assume "soft", but warn the user we are guessing. FloatABI = "soft"; - if (Triple.getOS() != llvm::Triple::UnknownOS || + if (Triple.getOS() != llvm::Triple::NoneOS || !Triple.isOSBinFormatMachO()) D.Diag(diag::warn_drv_assuming_mfloat_abi_is) << "soft"; break; @@ -756,7 +756,7 @@ // The backend is hardwired to assume AAPCS for M-class processors, ensure // the frontend matches that. if (Triple.g...

[+llvmdev, -llvm-dev] (Oopsies, llvmdev doesn't have a hyphen in it like all the others do) On 6/17/14, 10:45 AM, Jonathan Roelofs wrote: > [+llvm-dev, cfe-dev] > > Was "Re: [PATCH] ARM: allow inline atomics on Cortex M" > > On 6/17/14, 10:42 AM, Jonathan Roelofs wrote: >> >> >> On 6/17/14, 9:35 AM, Renato Golin wrote: >>> On 17 June 2014

...ion we'd all like to take... I'd rather not make triples more complicated by introducing lots of special cases. Do you know who the right folks are to ask about the SPIR triples? Tim, This patch changes behavior a little for macho_embedded targets (i.e. from OSType::Unknown to OSType::NoneOS). I see that there is existing code to transform triples from things like thumbv7-apple-darwin into thumbv7m-apple-unknown-macho. Do you have an expectation to support users who are using the latter form of triples who would be surprised by the change from thumbv7m-apple-unknown-macho to thumb...

...ore complicated by introducing lots of special cases. >> >> Do you know who the right folks are to ask about the SPIR triples? >> >> >> Tim, >> >> This patch changes behavior a little for macho_embedded targets (i.e. from >> OSType::Unknown to OSType::NoneOS). I see that there is existing code to >> transform triples from things like thumbv7-apple-darwin into >> thumbv7m-apple-unknown-macho. Do you have an expectation to support users >> who are using the latter form of triples who would be surprised by the >> change from thumb...

Hi Jonathan, The main issue with your patch is that it can change user expected behaviour, and I can't tell you what is the expected behaviour in Darwin or BSD. If people usually use "unknown" in triples, this will break their builds. If not, this could break the build of someone who does. My advice is to create a "default" mechanism for the affected targets, something