search for: nondiegetic_channels

...akns for the patch. Here's some comments for now (not done reviewing): 1) You want to use isqrt32() rather than celt_sqrt(), since celt_sqrt() changes behaviour for fixed-point and provides no guarantee about rounding. Thanks! I'll make that change. 2) About these two lines: + if (nondiegetic_channels && 2 != nondiegetic_channels) + return OPUS_UNIMPLEMENTED; Why not just have the condition be: + if (nondiegetic_channels != 2) We should allow either 0 or 2 nondiegetic channels. As a minor detail, I prefer N != 2 than 2 != N. Acknowledged. Also, unless you think it m...

Hello all, Attached is a proposed patch for Opus that allows support for encoding non-diegetic stereo audio as a coupled stream for use with channel mapping 254. It also rejects channel counts that are not (n+1)^2 + 2j, where n is 0 to 14 and j is either 0 or 1 (See IETF public draft doc attached for clarification). Please let me know any suggestions / concerns / comments. Thank you for your

Hi Drew, Thakns for the patch. Here's some comments for now (not done reviewing): 1) You want to use isqrt32() rather than celt_sqrt(), since celt_sqrt() changes behaviour for fixed-point and provides no guarantee about rounding. 2) About these two lines: + if (nondiegetic_channels && 2 != nondiegetic_channels) + return OPUS_UNIMPLEMENTED; Why not just have the condition be: + if (nondiegetic_channels != 2) As a minor detail, I prefer N != 2 than 2 != N. Also, unless you think it may one day make sense to have nondiegetic_channels != 2, I think you sho...

...ng): > > 1) You want to use isqrt32() rather than celt_sqrt(), since celt_sqrt() > changes behaviour for fixed-point and provides no guarantee about > rounding. > > > Thanks! I'll make that change. > > 2) About these two lines: > + if (nondiegetic_channels && 2 != nondiegetic_channels) > + return OPUS_UNIMPLEMENTED; > > Why not just have the condition be: > + if (nondiegetic_channels != 2) > > > We should allow either 0 or 2 nondiegetic channels. > > > As a minor detail, I prefe...

...rt32() rather than celt_sqrt(), since > celt_sqrt() > > changes behaviour for fixed-point and provides no guarantee about > > rounding. > > > > > > Thanks! I'll make that change. > > > > 2) About these two lines: > > + if (nondiegetic_channels && 2 != nondiegetic_channels) > > + return OPUS_UNIMPLEMENTED; > > > > Why not just have the condition be: > > + if (nondiegetic_channels != 2) > > > > > > We should allow either 0 or 2 nondiegetic channels. > > > &...