search for: noinst_ltlibrari

...ibraries (-fPIC compiler option) and non-PIC code for static libraries and executables. Bringing non-PIC code into shared libraries seems to be harmless, though definitely not recommended (it affects dynamic linker internals). To fix this issue, simply turning static noinst_LIBRARIES into libootl noinst_LTLIBRARIES is enough. Libtool then will manage PIC and non-PIC object code automagically. --- flac-1.1.0~/src/flac/Makefile.am 2003-01-25 21:14:42 +0300 +++ flac-1.1.0/src/flac/Makefile.am 2004-02-05 03:52:31 +0300 @@ -41,10 +41,10 @@ flac_LDADD = \ $(NEED_OGGFLAC_LIB) \ - $(top_builddir)/src/share/g...

...le with automake to produce Makefile.in -AUTOMAKE_OPTIONS = foreign - EXTRA_DIST = \ file_utils_flac.h \ metadata_utils.h diff --git a/src/libFLAC/Makefile.am b/src/libFLAC/Makefile.am index 13ab593..aa88100 100644 --- a/src/libFLAC/Makefile.am +++ b/src/libFLAC/Makefile.am @@ -34,6 +34,9 @@ noinst_LTLIBRARIES = libFLAC-static.la if DEBUG DEBUGCFLAGS = -DFLAC__OVERFLOW_DETECT endif + +# FIXME: The following logic should be part of configure, not of Makefile.am + if FLaC__CPU_PPC # The -force_cpusubtype_ALL is needed to insert a ppc64 instruction # into cpu.c with an asm(). diff --git a/src/plugin...

...b/src/plugin_common/Makefile.am index 147ee15..0f557fd 100644 --- a/src/plugin_common/Makefile.am +++ b/src/plugin_common/Makefile.am @@ -17,7 +17,7 @@ AUTOMAKE_OPTIONS = foreign -INCLUDES = -I$(top_srcdir)/include +AM_CPPFLAGS = -I$(top_builddir) -I$(srcdir)/include -I$(top_srcdir)/include noinst_LTLIBRARIES = libplugin_common.la diff --git a/src/plugin_xmms/Makefile.am b/src/plugin_xmms/Makefile.am index b9c4f8b..f96b3ae 100644 --- a/src/plugin_xmms/Makefile.am +++ b/src/plugin_xmms/Makefile.am @@ -31,8 +31,7 @@ noinst_HEADERS = \ tag.h AM_CFLAGS = @OGG_CFLAGS@ @XMMS_CFLAGS@ - -INCLUDES = -I$...

...am index 2f10d53..28940f1 100644 --- a/options/Makefile.am +++ b/options/Makefile.am @@ -17,6 +17,9 @@ include $(top_srcdir)/subdir-rules.mk +EXTRA_DIST = \ + key-option.pod + # liboptions.la contains guestfish code which is used in other # C tools for options parsing and a few other things noinst_LTLIBRARIES = liboptions.la -- 2.23.0

...: Benjamin Otte <otte at gnome.org> Date: Sat Jul 7 17:36:47 2007 +0100 fix test/ build with gtk enabled diff --git a/test/Makefile.am b/test/Makefile.am index a38faf4..a1b7a60 100644 --- a/test/Makefile.am +++ b/test/Makefile.am @@ -1,8 +1,8 @@ SUBDIRS = image sound trace various -noinst_LTLIBRARIES = libswfedit.la if WITH_GTK +noinst_LTLIBRARIES = libswfedit.la noinst_PROGRAMS = swfdec-extract dump parse swfedit swfscript else noinst_PROGRAMS = swfdec-extract dump parse

...#39;.libs/$(@:.lo=.o)'" >> $@ + echo "non_pic_object='$(@:.lo=.o)'" >> $@ + $(NASM) -f $(OBJ_FORMAT) -d OBJ_FORMAT_$(OBJ_FORMAT) -i$(srcdir)/ $< -o .libs/$(@:.lo=.o) + $(NASM) -f $(OBJ_FORMAT) -d OBJ_FORMAT_$(OBJ_FORMAT) -i$(srcdir)/ $< -o $(@:.lo=.o) noinst_LTLIBRARIES = libFLAC-asm.la libFLAC_asm_la_SOURCES = \

Can you see if this fixes the include problem? Rich.

...: Benjamin Otte <otte at gnome.org> Date: Sat Jul 7 17:36:47 2007 +0100 fix test/ build with gtk enabled diff --git a/test/Makefile.am b/test/Makefile.am index a38faf4..a1b7a60 100644 --- a/test/Makefile.am +++ b/test/Makefile.am @@ -1,8 +1,8 @@ SUBDIRS = image sound trace various -noinst_LTLIBRARIES = libswfedit.la if WITH_GTK +noinst_LTLIBRARIES = libswfedit.la noinst_PROGRAMS = swfdec-extract dump parse swfedit swfscript else noinst_PROGRAMS = swfdec-extract dump parse

This patch series modernizes various aspects of the autotools based build system. There is a lot more that could and should be done, but I tried to stay conservative for now and just resolve some of the most obvious issues. Max Horn (5): configure: replace XIPH_C_FIND_ENDIAN by AC_C_BIGENDIAN autogen.sh: replace this by a simple call to autoreconf configure: always print

..., Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + +include $(top_srcdir)/subdir-rules.mk + +generator_built = \ + errnostring-gperf.gperf \ + errnostring.c \ + errnostring.h + +BUILT_SOURCES = \ + $(generator_built) \ + errnostring-gperf.c + +EXTRA_DIST = \ + $(BUILT_SOURCES) + +noinst_LTLIBRARIES = liberrnostring.la + +# Build the errnostring perfect hash code. The generated code has lots +# of warnings so we must compile it in a separate mini-library. +liberrnostring_la_SOURCES = \ + errnostring-gperf.c \ + errnostring.h \ + errnostring.c +liberrnostring_la_CFLAGS = $(GCC_VISIBILITY_HID...

Christian Weisgerber <naddy@mips.inka.de> wrote: > | # nasm build rule: > | %.lo: %.s Even with gmake, this really works only by accident. Automake generates a competing suffix rule, and gmake apparently gives the rule above a higher priority than the suffix rule (or that just happens to be the evaluation order). Matt, since you seem to understand automake, can you come up with

...7 +21,7 @@ STRIP_FPIC = sh $(top_srcdir)/strip_fPIC.sh .nasm.lo: - $(LIBTOOL) --mode=compile $(STRIP_FPIC) $(NASM) -f $(OBJ_FORMAT) -d OBJ_FORMAT_$(OBJ_FORMAT) $< -o $@ + $(LIBTOOL) --mode=compile $(STRIP_FPIC) $(NASM) -f $(OBJ_FORMAT) -d OBJ_FORMAT_$(OBJ_FORMAT) -I $(srcdir)/ $< -o $@ noinst_LTLIBRARIES = libFLAC-asm.la libFLAC_asm_la_SOURCES = \

...estfs_la_LDFLAGS = -version-info $(MAX_PROC_NR):0:$(MAX_PROC_NR) libguestfs_la_SOURCES = \ guestfs.c \ guestfs.h \ - guestfs_protocol.c \ - guestfs_protocol.h \ guestfs-actions.h \ guestfs-actions.c \ guestfs-bindtests.c \ gettext.h +# Make libguestfs include the convenience library. +noinst_LTLIBRARIES = libprotocol.la +libguestfs_la_LIBADD = libprotocol.la + libguestfs_la_CFLAGS = -Wall -DGUESTFS_DEFAULT_PATH='"$(libdir)/guestfs"' if HAVE_RPCGEN -- 1.6.4.378.g88f2f >From ab84f9a78034249f37861e00e474018b8f750df2 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering...

...gt; +# the header file is compatible. The plugin does nothing very > +# interesting, it's mainly a compile test. > +TESTS += \ > + test-ansi-c.sh > +# check_LTLIBRARIES won't build a shared library (see automake manual). > +# So we have to do this and add a dependency. > +noinst_LTLIBRARIES += test-ansi-c-plugin.la > +test-ansi-c.sh: test-ansi-c-plugin.la > + > +test_ansi_c_plugin_la_SOURCES = \ > + test-ansi-c-plugin.c \ > + $(top_srcdir)/include/nbdkit-plugin.h > +test_ansi_c_plugin_la_CPPFLAGS = \ > + -std=c90 -pedantic \ > + -I$(top_srcdir)/include > +...

...h.sh \ test-swap.sh \ test-shutdown.sh \ $(NULL) @@ -282,6 +284,25 @@ test_socket_activation_CPPFLAGS = \ $(NULL) test_socket_activation_CFLAGS = $(WARNINGS_CFLAGS) +# check_LTLIBRARIES won't build a shared library (see automake manual). +# So we have to do this and add a dependency. +noinst_LTLIBRARIES += \ + test-flush-plugin.la \ + $(NULL) +test-flush.sh: test-flush-plugin.la + +test_flush_plugin_la_SOURCES = \ + test-flush-plugin.c \ + $(top_srcdir)/include/nbdkit-plugin.h \ + $(NULL) +test_flush_plugin_la_CPPFLAGS = -I$(top_srcdir)/include +test_flush_plugin_la_CFLAGS = $(WARNINGS_CFLAGS) +...

...mon_la_LIBADD = \ + $(top_builddir)/src/libguestfs.la \ + $(top_builddir)/src/libutils.la \ + $(LIBXML2_LIBS) \ + $(LTLIBINTL) + guestfish_SOURCES = \ $(generator_built) \ $(SHARED_SOURCE_FILES) \ @@ -159,7 +182,7 @@ guestfish_LDADD = \ -lm # Make guestfish use the convenience libraries. -noinst_LTLIBRARIES = libcmds.la librc_protocol.la +noinst_LTLIBRARIES = libcmds.la librc_protocol.la libfishcommon.la guestfish_LDADD += libcmds.la librc_protocol.la ../gnulib/lib/libgnu.la if HAVE_RPCGEN diff --git a/format/Makefile.am b/format/Makefile.am index 6c22beb..6eabd8a 100644 --- a/format/Makefile.am...

...file.am | 3 ++- fish/Makefile.am | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/common/protocol/Makefile.am b/common/protocol/Makefile.am index cfac2d8d375f..778758209d4c 100644 --- a/common/protocol/Makefile.am +++ b/common/protocol/Makefile.am @@ -34,7 +34,8 @@ noinst_LTLIBRARIES = libprotocol.la # warnings here. libprotocol_la_SOURCES = guestfs_protocol.c guestfs_protocol.h libprotocol_la_CFLAGS = \ - -Wall -Wno-unused -fno-strict-aliasing $(GCC_VISIBILITY_HIDDEN) + -Wall -Wno-unused -fno-strict-aliasing $(GCC_VISIBILITY_HIDDEN) \ + $(RPC_CFLAGS) if HAVE_RPCGEN...

...nclude. Fixes commit 05a8c47b9be8a6b8ffc091eab461fece9d40dcd0. Thanks: Nir Soffer. --- tests/Makefile.am | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/Makefile.am b/tests/Makefile.am index 80b5c6d..86bef71 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -553,6 +553,7 @@ noinst_LTLIBRARIES += \ test_layers_plugin_la_SOURCES = \ test-layers-plugin.c \ $(top_srcdir)/include/nbdkit-plugin.h +test_layers_plugin_la_CPPFLAGS = -I$(top_srcdir)/include test_layers_plugin_la_CFLAGS = $(WARNINGS_CFLAGS) # For use of the -rpath option, see: # https://lists.gnu.org/archive/html/libtool...

...een mistaken. Sorry for the confusion. :-( Indeed, this works: --- src/libFLAC/i386/Makefile.am.orig Sat Jun 9 21:48:49 2001 +++ src/libFLAC/i386/Makefile.am Sat Jun 9 21:49:05 2001 @@ -1,5 +1,6 @@ # nasm build rule: -%.lo: %.s +SUFFIXES = .s .lo +.s.lo: $(NASM) -f elf -d ELF $< -o $@ noinst_LTLIBRARIES = libFLAC-asm.la -- Christian "naddy" Weisgerber naddy@mips.inka.de

Small remark: > diff --git a/src/libFLAC/Makefile.am b/src/libFLAC/Makefile.am > index 13ab593..aa88100 100644 > --- a/src/libFLAC/Makefile.am > +++ b/src/libFLAC/Makefile.am > @@ -34,6 +34,9 @@ noinst_LTLIBRARIES = libFLAC-static.la > if DEBUG > DEBUGCFLAGS = -DFLAC__OVERFLOW_DETECT > endif > + > +# FIXME: The following logic should be part of configure, not of Makefile.am > + > if FLaC__CPU_PPC > # The -force_cpusubtype_ALL is needed to insert a ppc64 instruction > # into cpu.c...