Displaying 5 results from an estimated 5 matches for "noaliasatfunctionentry".
2013 May 27
2
[LLVMdev] Mixing noalias and regular arguments
...;AllocaInst>(V) || isNoAliasCall(V) || isNoAliasArgument(V));
+}
Extra parens?
The name "canNotAliasDiffArgument" works, but it's named for what we
need the function to do in its sole caller. Thinking about what it does
without a specific caller in mind, I might think of
"noaliasAtFunctionEntry", as it indicates that the object was noalias if
you assume no instructions in the function have had the chance to run
yet (to make aliasing copies).
+/// isNoAliasArgument - Return true if this is an argument with the noalias
+/// attribute.
+bool isNoAliasArgument(const Value *V);
Hold o...
2013 May 27
0
[LLVMdev] Mixing noalias and regular arguments
Regarding the name, I'm not sure noaliasAtFunctionEntry makes sense, for two reasons:
a) The pointer involved may not be defined at entry.
b) We already have something which is similar in spirit - IsIdentifiedObject. That covers the 3 cases I have in the new function, but also two additional ones: GlobalValues which are not GlobalAliases, and byval ar...
2013 May 27
1
[LLVMdev] Mixing noalias and regular arguments
Kuperstein, Michael M wrote:
> Regarding the name, I'm not sure noaliasAtFunctionEntry makes sense, for two reasons:
> a) The pointer involved may not be defined at entry.
Right, I thought of that too.
> b) We already have something which is similar in spirit - IsIdentifiedObject. That covers the 3 cases I have in the new function, but also two additional ones: GlobalValues w...
2013 May 27
0
[LLVMdev] Mixing noalias and regular arguments
Thanks Nick!
Can you just check sanity before I commit?
(Or suggest a better name for the function...)
-----Original Message-----
From: Nick Lewycky [mailto:nicholas at mxc.ca]
Sent: Sunday, May 26, 2013 09:54
To: Kuperstein, Michael M
Cc: LLVMdev at cs.uiuc.edu
Subject: Re: [LLVMdev] Mixing noalias and regular arguments
Kuperstein, Michael M wrote:
> Ping?
Pong! Sorry for the slow review,
2013 May 26
2
[LLVMdev] Mixing noalias and regular arguments
Kuperstein, Michael M wrote:
> Ping?
Pong! Sorry for the slow review, I had this patch starred but hadn't got
around to it. Yes, the rationale and implementation are correct.
> (Is there a code owner for AA, btw?)
(It falls back on the more general code owner who is Chris Lattner in
this case, "Everything not covered by someone else".)
+/// isNoAliasArgument - Return true