search for: no_weak

> 1. In a CHECK-DAG group, don't let the matches for patterns overlap. > 2. Add a new CHECK-DAG-N directive, where N is some integer, to express > that a pattern must have N non-overlapping matches. I think #1 is much more intuitive and easy to describe/document than #2. Changing the meaning of DAG in that way is highly unlikely to affect any existing test, IMO. And if it does, my

Hi, Using FileCheck, I have not found a way to make a group of CHECK-DAG directives match multiple occurrences of a string. For example, I naively thought the following would match successfully: ``` $ cat checks.txt // CHECK: start // CHECK-DAG: foo // CHECK-DAG: foo // CHECK-DAG: bar // CHECK-NEXT: end $ cat input.txt start foo bar foo end $ FileCheck --input-file=input.txt checks.txt

...so there should be only one directive, so it really doesn't matter which of these directives we use. S5. Incorrect pattern with same match ------------------------------------- For example, projects/compiler-rt/test/profile/instrprof-visibility.cpp has: ``` // COV-DAG: {{.*}}|{{ *}}1|#ifndef NO_WEAK ... // COV-DAG: {{.*}}|{{ *}}1|#ifndef NO_WEAK ``` The "1" does not appear in first occurrence in the actual output. Let's assume the actual output is correct and the first pattern is incorrect. If overlapping is permitted, the first pattern matches the intended line for the second...