search for: no_compare_perms

Displaying 4 results from an estimated 4 matches for "no_compare_perms".

2015 Jan 02
2
(no subject)
Hi, we needed these changes when we had to build a guest image compatible with a starting guest image but not backed by it in any way? We needed some tool to check our progress, comparing original and? rebuilt (from scratch) images, and virt-diff seemed the best option, but? we had to soften the comparison to reduce the noise in the output. I added some options to ignore certain informations when
2015 Jan 05
2
Re: [PATCH] virt-diff: add additional ignore options
...t; index 6a374af..426184e 100644 > --- a/diff/diff.c > +++ b/diff/diff.c > @@ -66,6 +66,11 @@ static int enable_extra_stats = 0; > static int enable_times = 0; > static int enable_uids = 0; > static int enable_xattrs = 0; > +static int no_compare_xattrs = 0; > +static int no_compare_perms = 0; > +static int no_compare_extra_stats = 0; > +static int no_compare_times = 0; > +static int no_compare_uids = 0; Instead of "no_compare_XXXX", I'd name them "compare_XXX" defaulting to 1, as avoids some mind twisting in expressions like: if (!no_compare_perm...
2015 Jan 02
0
[PATCH] virt-diff: add additional ignore options
...-) diff --git a/diff/diff.c b/diff/diff.c index 6a374af..426184e 100644 --- a/diff/diff.c +++ b/diff/diff.c @@ -66,6 +66,11 @@ static int enable_extra_stats = 0; static int enable_times = 0; static int enable_uids = 0; static int enable_xattrs = 0; +static int no_compare_xattrs = 0; +static int no_compare_perms = 0; +static int no_compare_extra_stats = 0; +static int no_compare_times = 0; +static int no_compare_uids = 0; static int time_t_output = 0; static int time_relative = 0; /* 1 = seconds, 2 = days */ static const char *checksum = NULL; @@ -125,6 +130,11 @@ usage (int status) "...
2015 Jan 06
0
Re: [PATCH] virt-diff: add additional ignore options
...if we are ignoring them. I think we wanted to see all them anyway to get confirmation that things worked they way we intended. > Instead of "no_compare_XXXX", I'd name them "compare_XXX" defaulting > to 1, as avoids some mind twisting in expressions like: > if (!no_compare_perms) ... So what the argument should look like when invoked ? virt-diff --compare-xattrs=0 ? What you suggest should be the name of the argument to show all the compare=False informations ? > > "len" in _list structs indicates the number of items in the list > itself, so I'd a...