search for: nmi_shootdown_cpus

...te_gate_lower. The IDT entry helpers are required because: * Is it unsafe to attempt a disable/update/re-enable cycle on the NMI or MCE IDT entries. * We need to be able to update NMI handlers without changing the IST entry. As a result, the new behaviour of the kexec_crash path is: nmi_shootdown_cpus() will: * Disable the crashing cpus NMI/MCE interrupt stack tables. Disabling the stack tables removes race conditions which would lead to corrupt exception frames and infinite loops. As this pcpu is never planning to execute a sysret back to a pv vcpu, the update is safe from a...

.../xen/arch/x86/crash.c Wed Sep 30 08:20:55 2009 +0000 @@ -25,6 +25,7 @@ #include <public/xen.h> #include <asm/shared.h> #include <asm/hvm/support.h> +#include <asm/hpet.h> static atomic_t waiting_for_crash_ipi; static unsigned int crashing_cpu; @@ -83,6 +84,9 @@ nmi_shootdown_cpus(); + if ( hpet_broadcast_is_available() ) + hpet_disable_legacy_broadcast(); + disable_IO_APIC(); hvm_cpu_down(); diff -r 6472342c8ab0 -r 5215da46d60f xen/arch/x86/hpet.c --- a/xen/arch/x86/hpet.c Wed Sep 30 08:51:21 2009 +0100 +++ b/xen/arch/x86/hpet.c Wed Sep 30 08:20:55 2...

...of the alternative options pointed out there: remove CPUs from the online map in __stop_this_cpu() (and hence doing so in stop_this_cpu() is no longer needed). Signed-off-by: Jan Beulich <jbeulich@suse.com> --- a/xen/arch/x86/crash.c +++ b/xen/arch/x86/crash.c @@ -61,9 +61,6 @@ static void nmi_shootdown_cpus(void) local_irq_disable(); - if ( hpet_broadcast_is_available() ) - hpet_disable_legacy_broadcast(); - crashing_cpu = smp_processor_id(); local_irq_count(crashing_cpu) = 0; --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -783,7 +783,11 @@ void hpet_disable(void...

...restore them during shutdown. This should cover the majority of cases where the secondary kernel might not come up because timer interrupts don''t work. Signed-off-by: Jan Beulich <jbeulich@suse.com> --- a/xen/arch/x86/crash.c +++ b/xen/arch/x86/crash.c @@ -96,6 +96,7 @@ static void nmi_shootdown_cpus(void) #endif disable_IO_APIC(); + hpet_disable(); } void machine_crash_shutdown(void) --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -566,7 +566,7 @@ void hpet_broadcast_resume(void) if ( !hpet_events ) return; - hpet_resume(); + hpet_resume(NULL);...

Avi, Hope this series is okay now. Thanks for the testing