search for: nirsof

...ke this: > > 1. We create a base image - this will be used for all disks container images. > > $ cat Dockerfile.kubevirt-img > FROM alpine > RUN apk add qemu-img > > $ podman build -t kubevirt-img -f Dockerfile.kubevirt-img . > ... > > You pull this from quay.io/nirsof/kubevirt-img. > > 2. Create a disk container image, based on the base image > > $ cat Dockerfile.kubevirt-fedora-cloud-disk > FROM quay.io/nirsof/kubevirt-fimg > COPY disk.qcow2 /disk.qcow2 > CMD ["qemu-img", "convert", "-p", "-f", &quo...

...r to convert the disk to the target PV. It can work like this: 1. We create a base image - this will be used for all disks container images. $ cat Dockerfile.kubevirt-img FROM alpine RUN apk add qemu-img $ podman build -t kubevirt-img -f Dockerfile.kubevirt-img . ... You pull this from quay.io/nirsof/kubevirt-img. 2. Create a disk container image, based on the base image $ cat Dockerfile.kubevirt-fedora-cloud-disk FROM quay.io/nirsof/kubevirt-fimg COPY disk.qcow2 /disk.qcow2 CMD ["qemu-img", "convert", "-p", "-f", "qcow2", "-O", &quo...

KubeVirt is a custom resource (a kind of plugin) for Kubernetes which adds support for running virtual machines. As part of this they have the same problems as everyone else of how to import large disk images into the system for pets, templates, etc. As part of the project they've defined a format for embedding a disk image into a container (unclear why? perhaps so these can be distributed

On Mon, Nov 18, 2019 at 1:05 AM Nir Soffer <nirsof@gmail.com> wrote: > > If waiting for the disk to become OK times out, try to remove it. This > is likely to fail. Daniel, do you think this can succeed? > --- > v2v/rhv-upload-plugin.py | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/v2v...

How about this variation of your patch? It fixes the problem from a fresh git checkout for me. Rich.

Daniel, please review this one. On Mon, Nov 18, 2019 at 1:04 AM Nir Soffer <nirsof@gmail.com> wrote: > > Checking status more frequently save a couple of seconds. Here is > an example flow tested with oVirt upload_disk.py example: > > With 5 seconds wait: > > Created disk in 11.085111 seconds > Created transfer in 1.857502 seconds > > With 1 secon...

On Sun, Aug 19, 2018 at 12:43 AM Richard W.M. Jones <rjones@redhat.com> wrote: > From: Nir Soffer <nirsof@gmail.com> > > synopsis.c was defined as dependency of the nbdkit program, but it > should be define as dependency of main.c. Otherwise "make" fail with: > > main.c:180:10: fatal error: synopsis.c: No such file or directory > #include "synopsis.c" >...

I was trying to find some documentation for this field and the best I could find is: https://github.com/oVirt/vdsm/blob/master/lib/vdsm/storage/constants.py What do the numbers mean? The comments in the file indicate that strings are valid too (eg. DISKTYPE=OVFS). Also this patch as written will affect -o vdsm mode too (another deprecated-ish mode where we write directly to the Storage

The optimization to start the transfer on the local host makes sense only when using the rhv-direct=true option. When using a proxy, let the engine choose a host. --- v2v/rhv-upload-plugin.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py index 8805e3552..1404ed1f5 100644 --- a/v2v/rhv-upload-plugin.py +++

On Wed, Nov 20, 2019 at 1:19 AM Nir Soffer <nirsof@gmail.com> wrote: > > Extract a cancel_transfer() function, so we can cancel a transfer in > plugin handlers without keeping the transfer_service around. > > Fixes a NameError when starting a transfer fails: > > During handling of the above exception, another exception o...

http was missing in emulate_zero, so the code would fail with NameError. This can happen only when communicating with old imageio versions not supporting the "zero" feature. Testing with qemu-img 2.12 show that we never send emulated zero request because of the highestwrite mechanism, but it can break with older qemu-img-rhev used on RHEL. --- v2v/rhv-upload-plugin.py | 2 ++ 1 file

On Thu, Jun 14, 2018 at 09:24:48PM +0300, Nir Soffer wrote: > On Thu, Jun 14, 2018 at 9:16 PM Nir Soffer <nirsof@gmail.com> wrote: > > + headers = {"Content-Type": "application/json", > > + "Content-Length", str(len(buf))} There were a few Python syntax errors such as this one. They can be found by running: make -C v2v check TESTS=test-v2v-pyt...

On Mon, Nov 18, 2019 at 1:04 AM Nir Soffer <nirsof@gmail.com> wrote: > > When request failed, we paused the transfer. This is not needed since > our intent it to cancel the transfer. > > When closing after failure, we canceled the transfer and removed the > disk. This is not needed since the transfer owns the disk and will >...

On Mon, Jun 18, 2018 at 08:55:13PM +0300, Nir Soffer wrote: > On Mon, Jun 18, 2018 at 1:37 PM Richard W.M. Jones <rjones@redhat.com> > wrote: > > > On Thu, Jun 14, 2018 at 09:24:48PM +0300, Nir Soffer wrote: > > > On Thu, Jun 14, 2018 at 9:16 PM Nir Soffer <nirsof@gmail.com> wrote: > > > > + headers = {"Content-Type": "application/json", > > > > + "Content-Length", str(len(buf))} > > > > There were a few Python syntax errors such as this one. They > > can be found by...

When sending request with small or no payload, it is simpler and possibly more efficient to use the high level HTTPSConnection.request(), instead of the lower level APIs. The only reason to use the lower level APIs is to avoid copying the payload, or on python 2, to use a bigger buffer size when streaming a file-like object. --- v2v/rhv-upload-plugin.py | 35 ++++++++++++++++-------------------

Replace 'iff' with 'if'. Signed-off-by: Nir Soffer <nirsof@gmail.com> --- docs/nbdkit-plugin.pod | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/nbdkit-plugin.pod b/docs/nbdkit-plugin.pod index 4b364f3..b96664f 100644 --- a/docs/nbdkit-plugin.pod +++ b/docs/nbdkit-plugin.pod @@ -348,7 +348,7 @@ handle supports writes. If...

On Mon, Mar 12, 2018 at 9:13 AM Nir Soffer <nirsof@gmail.com> wrote: > On Fri, Mar 9, 2018 at 4:25 PM Richard W.M. Jones <rjones@redhat.com> > wrote: > >> It has to be said it would be really convenient to have a 'zero' >> and/or 'trim' method of some sort. >> > > 'trim' means disca...

On Sun, Mar 25, 2018 at 1:36 AM Nir Soffer <nirsof@gmail.com> wrote: > On Thu, Mar 22, 2018 at 5:25 PM Richard W.M. Jones <rjones@redhat.com> > wrote: > >> PROBLEMS: >> - -of qcow2 does not work, with multiple problems >> * needs to set NBD size to something larger than virtual size >> > > How i...

On Mon, Jun 25, 2018 at 8:30 PM Nir Soffer <nirsof@gmail.com> wrote: > http was missing in emulate_zero, so the code would fail with NameError. > This can happen only when communicating with old imageio versions not > supporting the "zero" feature. > > Testing with qemu-img 2.12 show that we never send emulated zero req...

On Sat, Jun 30, 2018 at 1:39 AM Nir Soffer <nirsof@gmail.com> wrote: > The optimization to start the transfer on the local host makes sense > only when using the rhv-direct=true option. When using a proxy, let the > engine choose a host. > This avoids the issues with running on host from another dc[1] or host in maintenance mode[2]...