search for: nfeth

On Sun, Nov 24, 2019 at 03:03:52PM -0800, Jakub Kicinski wrote: > On Sun, 24 Nov 2019 16:48:35 -0500, Michael S. Tsirkin wrote: > > diff --git a/arch/m68k/emu/nfeth.c b/arch/m68k/emu/nfeth.c > > index a4ebd2445eda..8e06e7407854 100644 > > --- a/arch/m68k/emu/nfeth.c > > +++ b/arch/m68k/emu/nfeth.c > > @@ -167,7 +167,7 @@ static int nfeth_xmit(struct sk_buff *skb, struct net_device *dev) > > return 0; > > } > > &gt...

On Sun, 24 Nov 2019 16:48:35 -0500, Michael S. Tsirkin wrote: > diff --git a/arch/m68k/emu/nfeth.c b/arch/m68k/emu/nfeth.c > index a4ebd2445eda..8e06e7407854 100644 > --- a/arch/m68k/emu/nfeth.c > +++ b/arch/m68k/emu/nfeth.c > @@ -167,7 +167,7 @@ static int nfeth_xmit(struct sk_buff *skb, struct net_device *dev) > return 0; > } > > -static void nfeth_tx_timeout(str...

...ix/m68k/478-serial.diff (.) IGNORED bugfix/m68k/atari-rom-isa.diff (.) IGNORED bugfix/m68k/atari-ethernec.diff (.) IGNORED bugfix/m68k/unnecessary-m68k_memoffset.diff (.) IGNORED bugfix/m68k/atari-aranym.diff (.) IGNORED bugfix/m68k/ethernec-work.diff (.) IGNORED bugfix/m68k/nfeth-virt_to_phys.diff (.) IGNORED bugfix/m68k/ethernec-kill-ETHERNEC_USE_POLL.diff (.) IGNORED bugfix/m68k/m68k-generic-io.diff (.) IGNORED bugfix/m68k/m68k-mvme-scsi-rename.diff (.) IGNORED bugfix/m68k/m68k-53c700-scsi.diff (.) IGNORED bugfix/m68k/via-pmu68k-dead-code.diff (.) IG...

...r This allows incrementing the correct timeout statistic without any mess. Down the road, devices can learn to reset just the specific queue. The patch was generated with the following script: #/usr/bin/perl use strict; use warnings; our $^I = '.bak'; my @work = ( ["arch/m68k/emu/nfeth.c", "nfeth_tx_timeout"], ["arch/um/drivers/net_kern.c", "uml_net_tx_timeout"], ["arch/um/drivers/vector_kern.c", "vector_net_tx_timeout"], ["arch/xtensa/platforms/iss/network.c", "iss_net_tx_timeout"], ["drivers/char/pc...

...r This allows incrementing the correct timeout statistic without any mess. Down the road, devices can learn to reset just the specific queue. The patch was generated with the following script: #/usr/bin/perl use strict; use warnings; our $^I = '.bak'; my @work = ( ["arch/m68k/emu/nfeth.c", "nfeth_tx_timeout"], ["arch/um/drivers/net_kern.c", "uml_net_tx_timeout"], ["arch/um/drivers/vector_kern.c", "vector_net_tx_timeout"], ["arch/xtensa/platforms/iss/network.c", "iss_net_tx_timeout"], ["drivers/char/pc...

On Sun, Nov 24, 2019 at 03:03:52PM -0800, Jakub Kicinski wrote: > On Sun, 24 Nov 2019 16:48:35 -0500, Michael S. Tsirkin wrote: > > diff --git a/arch/m68k/emu/nfeth.c b/arch/m68k/emu/nfeth.c > > index a4ebd2445eda..8e06e7407854 100644 > > --- a/arch/m68k/emu/nfeth.c > > +++ b/arch/m68k/emu/nfeth.c > > @@ -167,7 +167,7 @@ static int nfeth_xmit(struct sk_buff *skb, struct net_device *dev) > > return 0; > > } > > &gt...

...- Adding the netdev patch produced by Michael (many thanks). - Using this stucture into virtnet and remove some stupid warn messages. Julio Faracco (2): netdev: pass the stuck queue to the timeout handler drivers: net: virtio_net: Implement a dev_watchdog handler arch/m68k/emu/nfeth.c | 2 +- arch/um/drivers/net_kern.c | 2 +- arch/um/drivers/vector_kern.c | 2 +- arch/xtensa/platforms/iss/network.c | 2 +- drivers/char/pcmcia/synclink_cs.c | 2 +- drivers/infiniband/ulp/ipoib/ipoib_main.c...

...- Adding the netdev patch produced by Michael (many thanks). - Using this stucture into virtnet and remove some stupid warn messages. Julio Faracco (2): netdev: pass the stuck queue to the timeout handler drivers: net: virtio_net: Implement a dev_watchdog handler arch/m68k/emu/nfeth.c | 2 +- arch/um/drivers/net_kern.c | 2 +- arch/um/drivers/vector_kern.c | 2 +- arch/xtensa/platforms/iss/network.c | 2 +- drivers/char/pcmcia/synclink_cs.c | 2 +- drivers/infiniband/ulp/ipoib/ipoib_main.c...

...rtio patch by Julio. That patch itself isn't ready yet though, so not included. Other drivers compiled only. Michael S. Tsirkin (3): netdev: pass the stuck queue to the timeout handler mlx4: use new txqueue timeout argument netronome: use the new txqueue timeout argument arch/m68k/emu/nfeth.c | 2 +- arch/um/drivers/net_kern.c | 2 +- arch/um/drivers/vector_kern.c | 2 +- arch/xtensa/platforms/iss/network.c | 2 +- drivers/char/pcmcia/synclink_cs.c | 2 +- drivers/infiniband/ulp/ipoib/...

...rtio patch by Julio. That patch itself isn't ready yet though, so not included. Other drivers compiled only. Michael S. Tsirkin (3): netdev: pass the stuck queue to the timeout handler mlx4: use new txqueue timeout argument netronome: use the new txqueue timeout argument arch/m68k/emu/nfeth.c | 2 +- arch/um/drivers/net_kern.c | 2 +- arch/um/drivers/vector_kern.c | 2 +- arch/xtensa/platforms/iss/network.c | 2 +- drivers/char/pcmcia/synclink_cs.c | 2 +- drivers/infiniband/ulp/ipoib/...

...rtio patch by Julio. That patch itself isn't ready yet though, so not included. Other drivers compiled only. Michael S. Tsirkin (3): netdev: pass the stuck queue to the timeout handler mlx4: use new txqueue timeout argument netronome: use the new txqueue timeout argument arch/m68k/emu/nfeth.c | 2 +- arch/um/drivers/net_kern.c | 2 +- arch/um/drivers/vector_kern.c | 2 +- arch/xtensa/platforms/iss/network.c | 2 +- drivers/char/pcmcia/synclink_cs.c | 2 +- drivers/infiniband/ulp/ipoib/...

...rtio patch by Julio. That patch itself isn't ready yet though, so not included. Other drivers compiled only. Michael S. Tsirkin (3): netdev: pass the stuck queue to the timeout handler mlx4: use new txqueue timeout argument netronome: use the new txqueue timeout argument arch/m68k/emu/nfeth.c | 2 +- arch/um/drivers/net_kern.c | 2 +- arch/um/drivers/vector_kern.c | 2 +- arch/xtensa/platforms/iss/network.c | 2 +- drivers/char/pcmcia/synclink_cs.c | 2 +- drivers/infiniband/ulp/ipoib/...

...rtio patch by Julio. That patch itself isn't ready yet though, so not included. Other drivers compiled only. Michael S. Tsirkin (3): netdev: pass the stuck queue to the timeout handler mlx4: use new txqueue timeout argument netronome: use the new txqueue timeout argument arch/m68k/emu/nfeth.c | 2 +- arch/um/drivers/net_kern.c | 2 +- arch/um/drivers/vector_kern.c | 2 +- arch/xtensa/platforms/iss/network.c | 2 +- drivers/char/pcmcia/synclink_cs.c | 2 +- drivers/infiniband/ulp/ipoib/...

...rtio patch by Julio. That patch itself isn't ready yet though, so not included. Other drivers compiled only. Michael S. Tsirkin (3): netdev: pass the stuck queue to the timeout handler mlx4: use new txqueue timeout argument netronome: use the new txqueue timeout argument arch/m68k/emu/nfeth.c | 2 +- arch/um/drivers/net_kern.c | 2 +- arch/um/drivers/vector_kern.c | 2 +- arch/xtensa/platforms/iss/network.c | 2 +- drivers/char/pcmcia/synclink_cs.c | 2 +- drivers/infiniband/ulp/ipoib/...

...the road, devices can learn to reset just the specific queue. > > > > The patch was generated with the following script: > > > > use strict; > > use warnings; > > > > our $^I = '.bak'; > > > > my @work = ( > > ["arch/m68k/emu/nfeth.c", "nfeth_tx_timeout"], > > ["arch/um/drivers/net_kern.c", "uml_net_tx_timeout"], > > ["arch/um/drivers/vector_kern.c", "vector_net_tx_timeout"], > > ["arch/xtensa/platforms/iss/network.c", "iss_net_tx_timeout&...

...do_tx_timeout? It's not hard - just need to be careful to fix all callers. I got the list of files and functions by grepping for ndo_tx_timeout. The massaged it with the following script. #/usr/bin/perl use strict; use warnings; our $^I = '.bak'; my @work = ( ["arch/m68k/emu/nfeth.c", "nfeth_tx_timeout"], ["arch/um/drivers/net_kern.c", "uml_net_tx_timeout"], ["arch/um/drivers/vector_kern.c", "vector_net_tx_timeout"], ["arch/xtensa/platforms/iss/network.c", "iss_net_tx_timeout"], ["drivers/char/pc...

...t; all callers. I got the list of files and functions by grepping > for ndo_tx_timeout. The massaged it with the following script. > > > > > #/usr/bin/perl > > use strict; > use warnings; > > our $^I = '.bak'; > > my @work = ( > ["arch/m68k/emu/nfeth.c", "nfeth_tx_timeout"], > ["arch/um/drivers/net_kern.c", "uml_net_tx_timeout"], > ["arch/um/drivers/vector_kern.c", "vector_net_tx_timeout"], > ["arch/xtensa/platforms/iss/network.c", "iss_net_tx_timeout"], > [&...

Hi Michael, Em sex., 22 de nov. de 2019 ?s 07:31, Michael S. Tsirkin <mst at redhat.com> escreveu: > > On Thu, Nov 21, 2019 at 10:36:36PM -0300, Julio Faracco wrote: > > Driver virtio_net is not handling error events for TX provided by > > dev_watchdog. This event is reached when transmission queue is having > > problems to transmit packets. This could happen for any

Hi Michael, Em sex., 22 de nov. de 2019 ?s 07:31, Michael S. Tsirkin <mst at redhat.com> escreveu: > > On Thu, Nov 21, 2019 at 10:36:36PM -0300, Julio Faracco wrote: > > Driver virtio_net is not handling error events for TX provided by > > dev_watchdog. This event is reached when transmission queue is having > > problems to transmit packets. This could happen for any

This allows incrementing the correct timeout statistic without any mess. Down the road, devices can learn to reset just the specific queue. The patch was generated with the following script: use strict; use warnings; our $^I = '.bak'; my @work = ( ["arch/m68k/emu/nfeth.c", "nfeth_tx_timeout"], ["arch/um/drivers/net_kern.c", "uml_net_tx_timeout"], ["arch/um/drivers/vector_kern.c", "vector_net_tx_timeout"], ["arch/xtensa/platforms/iss/network.c", "iss_net_tx_timeout"], ["drivers/char/pc...