search for: nfchostport

...dk/nbdkit-vddk-plugin.pod @@ -8,7 +8,7 @@ nbdkit-vddk-plugin - nbdkit VMware VDDK plugin [vm=moref=ID] [server=HOSTNAME] [user=USERNAME] [password=PASSWORD | password=- | password=+FILENAME] [cookie=COOKIE] [thumbprint=THUMBPRINT] - [port=PORT] [nfchostport=PORT] + [port=PORT] [nfchostport=PORT] [single-link=true] [snapshot=MOREF] [transports=MODE:MODE:...] nbdkit vddk --dump-plugin @@ -128,6 +128,11 @@ Optional. The port on the VCenter/ESXi host. Defaults to 443. Optional (required for remote connections). The hostna...

...a/v2v/cmdline.ml +++ b/v2v/cmdline.ml @@ -69,24 +69,6 @@ let parse_cmdline () = let output_password = ref None in let output_storage = ref None in let password_file = ref None in - let vddk_config = ref None in - let vddk_cookie = ref None in - let vddk_libdir = ref None in - let vddk_nfchostport = ref None in - let vddk_port = ref None in - let vddk_snapshot = ref None in - let vddk_thumbprint = ref None in - let vddk_transports = ref None in - let vddk_vimapiver = ref None in - let vdsm_vm_uuid = ref None in - let vdsm_ovf_output = ref None in (* default "." *) - - let v...

...gt; @@ -69,24 +69,6 @@ let parse_cmdline () = > let output_password = ref None in > let output_storage = ref None in > let password_file = ref None in > - let vddk_config = ref None in > - let vddk_cookie = ref None in > - let vddk_libdir = ref None in > - let vddk_nfchostport = ref None in > - let vddk_port = ref None in > - let vddk_snapshot = ref None in > - let vddk_thumbprint = ref None in > - let vddk_transports = ref None in > - let vddk_vimapiver = ref None in > - let vdsm_vm_uuid = ref None in > - let vdsm_ovf_output = ref None in (*...

..."INPUT FROM VDDK\" in the virt-v2v(1) manual.") in + (* List of passthrough parameters. *) + let passthrus = + [ "config", (fun { vddk_config } -> vddk_config); + "cookie", (fun { vddk_cookie } -> vddk_cookie); + "nfchostport", (fun { vddk_nfchostport } -> vddk_nfchostport); + "port", (fun { vddk_port } -> vddk_port); + "snapshot", (fun { vddk_snapshot } -> vddk_snapshot); + "thumbprint", (fun { vddk_thumbprint } -> vddk_thumbprint); +...

This patch isn't quite complete (see ‘assert false’). Currently we have a bunch of ad hoc options like --vddk* and --vdsm* (and proposed to add --rhv*) to handle extra parameters for input and output modes/transports. This complicates the command line parsing and also the clarity of the command line (becauseit's not very obvious which options apply to which side of the conversion).

...n.pod >@@ -8,7 +8,7 @@ nbdkit-vddk-plugin - nbdkit VMware VDDK plugin > [vm=moref=ID] [server=HOSTNAME] [user=USERNAME] > [password=PASSWORD | password=- | password=+FILENAME] > [cookie=COOKIE] [thumbprint=THUMBPRINT] >- [port=PORT] [nfchostport=PORT] >+ [port=PORT] [nfchostport=PORT] [single-link=true] > [snapshot=MOREF] [transports=MODE:MODE:...] > nbdkit vddk --dump-plugin > >@@ -128,6 +128,11 @@ Optional. The port on the VCenter/ESXi host. Defaults to 443. > Optional (required for remote co...

...(List.assoc "config" vddk_options) with Not_found -> None in + let cookie = + try Some (List.assoc "cookie" vddk_options) with Not_found -> None in + let libdir = + try Some (List.assoc "libdir" vddk_options) with Not_found -> None in + let nfchostport = + try Some (List.assoc "nfchostport" vddk_options) with Not_found -> None in + let port = + try Some (List.assoc "port" vddk_options) with Not_found -> None in + let snapshot = + try Some (List.assoc "snapshot" vddk_options) with Not_found...

Proposed small change to the command line of virt-v2v when specifying that you want VDDK mode. Rich.

...tput_conn = ref None in let output_format = ref None in let output_name = ref None in let output_storage = ref None in let password_file = ref None in - let vddk = ref None in let vddk_config = ref None in let vddk_cookie = ref None in + let vddk_libdir = ref None in let vddk_nfchostport = ref None in let vddk_port = ref None in let vddk_snapshot = ref None in @@ -191,6 +192,8 @@ let parse_cmdline () = s_"Libvirt URI"; [ M"if" ], Getopt.String ("format", set_string_option_once "-if" input_...

v6 was here: https://www.redhat.com/archives/libguestfs/2018-March/msg00126.html This makes a number of significant changes: - Input and output options now use a uniform set of -io and -oo parameters. - For -o rhv-upload, we use ‘-oo rhv-cafile=/tmp/ca.pem’ etc. The ‘--rhv*’ options have been dropped. - Rearranges the documentation. - As before includes (untested) support for zero,

...a/plugins/vddk/nbdkit-vddk-plugin.pod +++ b/plugins/vddk/nbdkit-vddk-plugin.pod @@ -4,7 +4,7 @@ nbdkit-vddk-plugin - nbdkit VMware VDDK plugin =head1 SYNOPSIS - nbdkit vddk file=FILENAME + nbdkit vddk [file=]FILENAME [config=FILENAME] [cookie=COOKIE] [libdir=LIBRARY] [nfchostport=PORT] [single-link=true] [password=PASSWORD | password=- | password=+FILENAME @@ -135,6 +135,9 @@ If a VM has multiple disks, nbdkit can only serve one at a time. To serve more than one you must run multiple copies of nbdkit. (See L</NOTES> below). +C<file=> is a magi...

...out regardless of 32- or 64-bit platform is probably > saner. See above about ssh_options_set. > > +++ b/plugins/vddk/vddk.c > > @@ -271,10 +271,8 @@ vddk_config (const char *key, const char *value) > > return -1; > > } > > else if (strcmp (key, "nfchostport") == 0) { > > - if (sscanf (value, "%d", &nfc_host_port) != 1) { > > - nbdkit_error ("cannot parse nfchostport: %s", value); > > + if (nbdkit_parse_int ("nfchostport", value, &nfc_host_port) == -1) > > return -1; &...

...return -1; - } } else { diff --git a/plugins/vddk/vddk.c b/plugins/vddk/vddk.c index 8ea05b1..2e56b4a 100644 --- a/plugins/vddk/vddk.c +++ b/plugins/vddk/vddk.c @@ -271,10 +271,8 @@ vddk_config (const char *key, const char *value) return -1; } else if (strcmp (key, "nfchostport") == 0) { - if (sscanf (value, "%d", &nfc_host_port) != 1) { - nbdkit_error ("cannot parse nfchostport: %s", value); + if (nbdkit_parse_int ("nfchostport", value, &nfc_host_port) == -1) return -1; - } } else if (strcmp (key, &quo...

...0; > +static unsigned long timeout = 0; Again, a 32-bit timeout regardless of 32- or 64-bit platform is probably saner. > +++ b/plugins/vddk/vddk.c > @@ -271,10 +271,8 @@ vddk_config (const char *key, const char *value) > return -1; > } > else if (strcmp (key, "nfchostport") == 0) { > - if (sscanf (value, "%d", &nfc_host_port) != 1) { > - nbdkit_error ("cannot parse nfchostport: %s", value); > + if (nbdkit_parse_int ("nfchostport", value, &nfc_host_port) == -1) > return -1; > - } Is '...

...are all optional. +Do not use these options unless you know what you are doing. These +are all optional. =item B<-ip> filename @@ -1894,6 +1895,7 @@ Other options that you might need to add in rare circumstances include I<-io vddk-config>, I<-io vddk-cookie>, I<-io vddk-nfchostport>, I<-io vddk-port>, I<-io vddk-snapshot>, and I<-io vddk-transports>, which are all explained in the L<nbdkit-vddk-plugin(1)> documentation. +Do not use these options unless you know what you are doing. =head2 VDDK: DEBUGGING VDDK FAILURES -- 2.19.0.rc0

I suppose we may as well implement the only other flag too ... It's not clear what this does, something like O_DIRECT I imagine. Rich.

...dk/vddk.c @@ -91,9 +91,9 @@ static char *config = NULL; /* config */ static const char *cookie = NULL; /* cookie */ static const char *filename = NULL; /* file */ static char *libdir = NULL; /* libdir */ -static int nfc_host_port = 0; /* nfchostport */ +static uint16_t nfc_host_port = 0; /* nfchostport */ static char *password = NULL; /* password */ -static int port = 0; /* port */ +static uint16_t port = 0; /* port */ static const char *server_name = NULL; /* server */ static...

This series (except the last one) changes virt-v2v to use nbdkit for several input modes: -i vmx -it vddk: No change in functionality, as this already uses nbdkit-vddk-plugin, but the code is refactored for the other modes to use. -i libvirtxml: Use nbdkit-curl-plugin instead of qemu curl. vCenter: Use nbdkit-curl-plugin instead of qemu curl. xen: Use nbdkit-ssh-plugin instead of qemu

The first patch was previously posted here: https://www.redhat.com/archives/libguestfs/2017-December/msg00018.html That patch hasn't changed except that I made the ‘input_transport’ variable type-safe. The second patch adds a significant new mode for liberating data from VMware: the ability to copy VMs over SSH directly from ESXi hypervisors. Although this requires enabling SSH access (a

...+ b/plugins/vddk/nbdkit-vddk-plugin.pod > @@ -4,7 +4,7 @@ nbdkit-vddk-plugin - nbdkit VMware VDDK plugin > > =head1 SYNOPSIS > > - nbdkit vddk file=FILENAME > + nbdkit vddk [file=]FILENAME > [config=FILENAME] [cookie=COOKIE] [libdir=LIBRARY] > [nfchostport=PORT] [single-link=true] > [password=PASSWORD | password=- | password=+FILENAME > @@ -135,6 +135,9 @@ If a VM has multiple disks, nbdkit can only serve one at a time. To > serve more than one you must run multiple copies of nbdkit. (See > L</NOTES> below). >...