search for: nf_hook_slow

On Fri, 07 Jan 2005 17:05:59 +0000 David Woodhouse <dwmw2@infradead.org> wrote: > On Sat, 2004-12-18 at 08:50 +0100, Andi Kleen wrote: > > It's not really an oops, just a warning that stack space got quiet > > tight. > > > > The problem seems to be that the br netfilter code is nesting far too > > deeply and recursing several times. Looks like a design

Hi, This is a second try to fix the long chain call lengths in netfilter. The difference with the previous patch is that I got rid of the extra argument. I somehow didn't see it could be done without using the 'int *ret2' argument. A comment on the number of arguments to nf_hook_slow: I don't think the number of arguments should be decreased. For the bridge-nf code, f.e., the indev argument does not equal (*pskb)->dev (this is an answer to a question of Rusty in the old thread). A comment on the argument change of nf_hook_slow (sk_buff * to sk_buff **) and the bad influ...

...voke2() gets a tail-call > > >whereas invoke() does not. Hmmm... > > > > Apparently support for indirect tail-calls was added to gcc 3.4. > > Good data point. > > I've been trying to figure out ways to decrease the number of > args that get sent to nf_hook_slow but this would require > some API changes unfortunately. > > One idea goes like this, we create little descriptors of the form: > > struct nf_hook_desc { > int (*okfn)(struct sk_buff *); > int pf; > int hook; > }; > > Then NF_HOOK*() callsites do so...

...000 00000000 c0475e9c Call Trace: [<c0345127>] ip_nat_in+0x29/0x88 [<c0359b4d>] br_nf_pre_routing_finish+0x0/0x2c0 [<c0359b4d>] br_nf_pre_routing_finish+0x0/0x2c0 [<c030d562>] nf_iterate+0x3f/0x6d [<c0359b4d>] br_nf_pre_routing_finish+0x0/0x2c0 [<c030d5d7>] nf_hook_slow+0x47/0xba [<c0359b4d>] br_nf_pre_routing_finish+0x0/0x2c0 [<c035685b>] br_handle_frame_finish+0x0/0xca [<c035a446>] br_nf_pre_routing+0x35d/0x37a [<c035685b>] br_handle_frame_finish+0x0/0xca [<c035a454>] br_nf_pre_routing+0x36b/0x37a [<c030d562>] nf_iterate...

...r_nf_post_routing+0x102/0x1d0 [<c05c22b0>] br_nf_dev_queue_xmit+0x0/0x50 [<c05bbda0>] br_dev_queue_push_xmit+0x0/0x140 [<c04f0eab>] nf_iterate+0x6b/0xa0 [<c05bbda0>] br_dev_queue_push_xmit+0x0/0x140 [<c05bbda0>] br_dev_queue_push_xmit+0x0/0x140 [<c04f0f4e>] nf_hook_slow+0x6e/0x120 [<c05bbda0>] br_dev_queue_push_xmit+0x0/0x140 [<c05bbf40>] br_forward_finish+0x60/0x70 [<c05bbda0>] br_dev_queue_push_xmit+0x0/0x140 [<c05c1b71>] br_nf_forward_finish+0x71/0x130 [<c05bbee0>] br_forward_finish+0x0/0x70 [<c05c1d20>] br_nf_forward_i...

...c9167d70>] br_forward_finish+0x0/0x70 [bridge] [<c9168a30>] br_handle_frame_finish+0x0/0x130 [bridge] [<c0145899>] kmem_cache_alloc+0x69/0x70 [<c916d132>] br_nf_pre_routing+0x1b2/0x480 [bridge] [<c9168990>] br_pass_frame_up_finish+0x0/0x20 [bridge] [<c029631e>] nf_hook_slow+0x6e/0x100 [<c0296018>] nf_iterate+0x78/0x90 [<c9168a30>] br_handle_frame_finish+0x0/0x130 [bridge] [<c9168a30>] br_handle_frame_finish+0x0/0x130 [bridge] [<c029631e>] nf_hook_slow+0x6e/0x100 [<c9168a30>] br_handle_frame_finish+0x0/0x130 [bridge] [<c9168d59&gt...

...9/0x510 Apr 02 14:20:59 helium kernel: ? find_next_bit+0x18/0x20 Apr 02 14:20:59 helium kernel: ? pcpu_alloc+0x2ce/0x630 Apr 02 14:20:59 helium kernel: ? ip6_finish_output+0xab/0x1c0 Apr 02 14:20:59 helium kernel: nft_do_chain_netdev+0x66/0x250 [nf_tables_netdev] Apr 02 14:20:59 helium kernel: nf_hook_slow+0x2a/0xb0 Apr 02 14:20:59 helium kernel: __netif_receive_skb_core+0x820/0xa80 Apr 02 14:20:59 helium kernel: __netif_receive_skb+0x18/0x60 Apr 02 14:20:59 helium kernel: process_backlog+0x9f/0x160 Apr 02 14:20:59 helium kernel: net_rx_action+0x242/0x3d0 Apr 02 14:20:59 helium kernel: __do_soft...

...p_nat_in+0x4a/0xc1 [<c035d274>] br_nf_pre_routing_finish+0x0/0x34e [<c035d274>] br_nf_pre_routing_finish+0x0/0x34e [<c0302017>] nf_iterate+0x6f/0x87 [<c035d274>] br_nf_pre_routing_finish+0x0/0x34e [<c035d274>] br_nf_pre_routing_finish+0x0/0x34e [<c030209a>] nf_hook_slow+0x6b/0x102 [<c035d274>] br_nf_pre_routing_finish+0x0/0x34e [<c035958e>] br_handle_frame_finish+0x0/0x109 [<c035db86>] br_nf_pre_routing+0x276/0x449 [<c035d274>] br_nf_pre_routing_finish+0x0/0x34e [<c0302017>] nf_iterate+0x6f/0x87 [<c035958e>] br_handle_fram...

...sh+0x328/0x360 [bridge] [ 5445.385984] [<ffffffffa0396b96>] br_nf_pre_routing+0x356/0x370 [bridge] [ 5445.393255] [<ffffffff815165d5>] nf_iterate+0x85/0xc0 [ 5445.400827] [<ffffffffa038ffd0>] ? br_handle_local_finish+0x50/0x50 [bridge] [ 5445.408643] [<ffffffff81516686>] nf_hook_slow+0x76/0x130 [ 5445.416438] [<ffffffffa038ffd0>] ? br_hanlde_local_finish+0x50/0x50 [bridge] [ 5445.424202] [<ffffffffa0390424>] br_handle_frame+0x1b4/0x260 [bridge] [ 5445.431824] [<ffffffffa0390270>] ? br_hanlde_frame_finish+0x2a0/0x2a0 [bridge] [ 5445.446876] [<ffffffff814...

...d74/2000> Trace; c01f79f1 <ipt_do_table+241/38c> Trace; c01cfc5c <ip_forward_finish+0/54> Trace; c01f9841 <ipt_hook+21/28> Trace; c01c8228 <nf_iterate+30/84> Trace; c01cfc5c <ip_forward_finish+0/54> Trace; c01cfc5c <ip_forward_finish+0/54> Trace; c01c84dd <nf_hook_slow+b5/144> Trace; c01cfc5c <ip_forward_finish+0/54> Trace; c01cfc06 <ip_forward+196/1ec> Trace; c01cfc5c <ip_forward_finish+0/54> Trace; c01ceedc <ip_rcv_finish+0/1a4> Trace; c01cf050 <ip_rcv_finish+174/1a4> Trace; c01ceedc <ip_rcv_finish+0/1a4> Trace; c01c8516 &...

https://bugzilla.netfilter.org/show_bug.cgi?id=1742 Bug ID: 1742 Summary: using nfqueue breaks SCTP connection (tracking) Product: libnetfilter_queue Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 Component: libnetfilter_queue Assignee:

...idge] [<ffffffffa04faedb>] ? br_nf_pre_routing+0x48b/0x7b0 [bridge] [<ffffffff8143ba57>] ? __kfree_skb+0x47/0xa0 [<ffffffff814734f9>] ? nf_iterate+0x69/0xb0 [<ffffffffa04f48f0>] ? br_handle_frame_finish+0x0/0x2a0 [bridge] [<ffffffff814736b6>] ? nf_hook_slow+0x76/0x120 [<ffffffffa04f48f0>] ? br_handle_frame_finish+0x0/0x2a0 [bridge] [<ffffffffa04f4d1c>] ? br_handle_frame+0x18c/0x250 [bridge] [<ffffffff81445709>] ? __netif_receive_skb+0x529/0x750 [<ffffffff814397da>] ? __alloc_skb+0x7a/0x180 [<ffffffff...

...0x110 [xfs] Aug 27 19:27:38 sauron kernel: [<c0223949>] dev_queue_xmit+0x249/0x300 Aug 27 19:27:38 sauron kernel: [<c88d1a5e>] xfs_bmapi+0x1fe/0x1460 [xfs] Aug 27 19:27:38 sauron kernel: [<c023af60>] ip_finish_output2+0x0/0x1b0 Aug 27 19:27:38 sauron kernel: [<c022d701>] nf_hook_slow+0xf1/0x120 Aug 27 19:27:39 sauron kernel: [<c023af60>] ip_finish_output2+0x0/0x1b0 Aug 27 19:27:39 sauron kernel: [<c023af30>] dst_output+0x0/0x30 Aug 27 19:27:39 sauron kernel: [<c023af44>] dst_output+0x14/0x30 Aug 27 19:27:39 sauron kernel: [<c0223949>] dev_queue_xmit+...

...#10 [ffff880010ba3928] ipt_do_table at ffffffffa029e16a #11 [ffff880010ba3ab8] nf_nat_rule_find at ffffffffa02a61d4 #12 [ffff880010ba3ad8] nf_nat_fn at ffffffffa02a6469 #13 [ffff880010ba3b28] nf_nat_out at ffffffffa02a6638 #14 [ffff880010ba3b48] nf_iterate at ffffffff812fd45c #15 [ffff880010ba3b98] nf_hook_slow at ffffffff812fd514 #16 [ffff880010ba3c08] ip_output at ffffffff8130b6f3 #17 [ffff880010ba3c38] ip_forward_finish at ffffffff81306cde #18 [ffff880010ba3c58] ip_forward at ffffffff81306ede #19 [ffff880010ba3c98] ip_rcv_finish at ffffffff81305125 #20 [ffff880010ba3cd8] ip_rcv at ffffffff813056ad #21...

https://bugzilla.netfilter.org/cgi-bin/bugzilla/show_bug.cgi?id=22 laforge@netfilter.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bowles@ambisys.com Component|unknown |ip_tables (kernel) OS/Version|other

...f80315620 ffffffff88020814 0000000000000000 ffff88003fa00000 ffffffff8801ebc0 Call Trace: <IRQ> <ffffffff8023ccd7>{nf_iterate+63} <ffffffff880339be>{:ip_conntrack:tcp_pkt_to_tuple+0} <ffffffff8024218b>{ip_local_deliver_finish+0} <ffffffff8023cdfd> {nf_hook_slow+90} <ffffffff8024218b>{ip_local_deliver_finish+0} <ffffffff802423ce> {ip_local_deliver+103} <ffffffff880339be>{:ip_conntrack:tcp_pkt_to_tuple+0} <ffffffff80242a6e>{ip_rcv+1206} <ffffffff8020e8f8>{netif_poll+1661} <ffffffff80229f4f>{net...

...caf6>] __qdisc_run+0xe4/0x19a [<c05b0544>] dev_queue_xmit+0x1e0/0x2e8 [<c05b4b24>] neigh_resolve_output+0x1b2/0x1dc [<d136eb2e>] ip6_output2+0x256/0x2a7 [ipv6] [<d136f656>] ip6_output+0x9c7/0x9f3 [ipv6] [<d137c8c0>] dst_output+0x0/0x7 [ipv6] [<c05c3d12>] nf_hook_slow+0x3a/0x90 [<d137c8c0>] dst_output+0x0/0x7 [ipv6] [<d137e4d6>] ndisc_send_ns+0x3a8/0x47a [ipv6] [<c06090d8>] _spin_lock_irqsave+0x8/0x28 [<c042914a>] lock_timer_base+0x15/0x2f [<d1375ddb>] addrconf_dad_timer+0xc3/0xdf [ipv6] [<c0434244>] hrtimer_run_queues+0...

...6_output+0x86/0xb0 [nf_conntrack_ipv6] [<c02618b0>] ip6_rcv_finish+0x0/0x30 [<ce81911b>] ipv6_defrag+0x3b/0x50 [nf_conntrack_ipv6] [<c02618b0>] ip6_rcv_finish+0x0/0x30 [<c022c618>] nf_iterate+0x38/0x70 [<c02618b0>] ip6_rcv_finish+0x0/0x30 [<c022c75d>] nf_hook_slow+0x4d/0xc0 [<c02618b0>] ip6_rcv_finish+0x0/0x30 [<c0261ac0>] ipv6_rcv+0x1e0/0x250 [<c02618b0>] ip6_rcv_finish+0x0/0x30 [<c0217068>] netif_receive_skb+0x1a8/0x200 [<c021868e>] process_backlog+0x6e/0xe0 [<c0218752>] net_rx_action+0x52/0xd0 [<c011388...

Hi, I just want to know if somebody use 2.6.31.4 xenified kernel (aka OpenSUSE) in production? We have been testing it on new Nehalem Xeon server for few weeks w/o any problem. But as soon we tried it on production machine - after several production domUs started - hard OS failure. We had to switch back to 2.6.18.8 - xen stock kernel. Peter _______________________________________________

...1beb [nf_nat] #6 [ffff88002c303a58] nf_nat_setup_info at ffffffffa1491de9 [nf_nat] #7 [ffff88002c303b38] alloc_null_binding at ffffffffa149e162 [iptable_nat] #8 [ffff88002c303b78] nf_nat_fn at ffffffffa149e519 [iptable_nat] #9 [ffff88002c303bb8] nf_iterate at ffffffff81318d18 #10 [ffff88002c303bf8] nf_hook_slow at ffffffff81318db2 #11 [ffff88002c303c58] ip_local_deliver at ffffffff813214a1 #12 [ffff88002c303c78] ip_rcv_finish at ffffffff81320a59 #13 [ffff88002c303cb8] netif_receive_skb at ffffffff812f5f89 #14 [ffff88002c303d28] ixgbe_clean_rx_irq at ffffffffa0ea4837 [ixgbe] #15 [ffff88002c303e28] ixgbe_cl...