search for: next_extent

I can't seem to find a definitive answer on this, and I really don't want to risk breaking a production server to find out; so I am going to try asking this here, and maybe anyone else in the same situation searching the archives sometime in future will find the answer I get. Can you use variables in the target of a GoTo() statement? What I am specifically thinking of is this;

...FSUUID, /* Boot filesystem UUID */ SYSAPPEND_MAX /* Total number of strings */ }; diff --git a/core/fs/btrfs/btrfs.c b/core/fs/btrfs/btrfs.c index 16386cc..dfa9ad7 100644 --- a/core/fs/btrfs/btrfs.c +++ b/core/fs/btrfs/btrfs.c @@ -674,5 +674,6 @@ const struct fs_ops btrfs_fs_ops = { .next_extent = btrfs_next_extent, .readdir = btrfs_readdir, .chdir_start = generic_chdir_start, - .open_config = generic_open_config + .open_config = generic_open_config, + .fs_uuid = NULL, }; diff --git a/core/fs/ext2/ext2.c b/core/fs/ext2/ext2.c index 957c60b..df0856f 1...

...; + if (block < triple_blks) + return bmap_indirect(fs, PVT(inode)->triple_indirect_blk_ptr, + block, 3, nblocks); + + /* This can't happen... */ + return 0; +} + +/* + * Next extent for getfssec + * "Remaining sectors" means (lstart & blkmask). + */ +int ufs_next_extent(struct inode *inode, uint32_t lstart) +{ + struct fs_info *fs = inode->fs; + int blktosec = BLOCK_SHIFT(fs) - SECTOR_SHIFT(fs); + int frag_shift = BLOCK_SHIFT(fs) - UFS_SB(fs)->c_blk_frag_shift; + int blkmask = (1 << blktosec) - 1; + block_t block; + size_t nblocks =...

...; + if (block < triple_blks) + return bmap_indirect(fs, PVT(inode)->triple_indirect_blk_ptr, + block, 3, nblocks); + + /* This can't happen... */ + return 0; +} + +/* + * Next extent for getfssec + * "Remaining sectors" means (lstart & blkmask). + */ +int ufs_next_extent(struct inode *inode, uint32_t lstart) +{ + struct fs_info *fs = inode->fs; + int blktosec = BLOCK_SHIFT(fs) - SECTOR_SHIFT(fs); + int frag_shift = BLOCK_SHIFT(fs) - UFS_SB(fs)->c_blk_frag_shift; + int blkmask = (1 << blktosec) - 1; + block_t block; + size_t nblocks =...

...urn NULL; + } + + return uuid; +} + const struct fs_ops ext2_fs_ops = { .fs_name = "ext2", .fs_flags = FS_THISIND | FS_USEMEM, @@ -336,5 +374,5 @@ const struct fs_ops ext2_fs_ops = { .readlink = ext2_readlink, .readdir = ext2_readdir, .next_extent = ext2_next_extent, - .fs_uuid = NULL, + .fs_uuid = ext2_fs_uuid, }; diff --git a/core/fs/ext2/ext2_fs.h b/core/fs/ext2/ext2_fs.h index 8adc9bb..803a995 100644 --- a/core/fs/ext2/ext2_fs.h +++ b/core/fs/ext2/ext2_fs.h @@ -277,6 +277,7 @@ struct ext2_sb_info { uint32_t s_gr...

...EG) break; + if (btrfs_file_extent_compression(leaf, fi) || + btrfs_file_extent_encryption(leaf, fi) || + btrfs_file_extent_other_encoding(leaf, fi)) + break; bytenr = btrfs_file_extent_disk_bytenr(leaf, fi); /* skip holes and direct mapped extents */ @@ -2750,6 +2777,15 @@ next_extent: goto fail; } + /* zero btrfs super block mirrors */ + memset(buf, 0, sectorsize); + for (i = 1 ; i < BTRFS_SUPER_MIRROR_MAX; i++) { + bytenr = btrfs_sb_offset(i); + if (bytenr >= total_bytes) + break; + ret = pwrite(fd, buf, sectorsize, bytenr); + } + sb_bytenr = (u64)-1; /*...

...;can_extents (b_conn->b, b_conn->conn); +} + static int next_can_fua (void *nxdata) { @@ -364,6 +371,16 @@ next_zero (void *nxdata, uint32_t count, uint64_t offset, uint32_t flags, return b_conn->b->zero (b_conn->b, b_conn->conn, count, offset, flags, err); } +static int +next_extents (void *nxdata, uint32_t count, uint64_t offset, uint32_t flags, + size_t *nr_extents, struct nbdkit_extent **extents, + int *err) +{ + struct b_conn *b_conn = nxdata; + return b_conn->b->extents (b_conn->b, b_conn->conn, count, offset, flags, +...

...nxdata; - return backend_trim (b_next, count, offset, flags, err); -} - -static int -next_zero (void *nxdata, uint32_t count, uint64_t offset, uint32_t flags, - int *err) -{ - struct backend *b_next = nxdata; - return backend_zero (b_next, count, offset, flags, err); -} - -static int -next_extents (void *nxdata, uint32_t count, uint64_t offset, uint32_t flags, - struct nbdkit_extents *extents, int *err) -{ - struct backend *b_next = nxdata; - return backend_extents (b_next, count, offset, flags, extents, err); -} - -static int -next_cache (void *nxdata, uint32_t count, uint64...

From: Raphael S. Carvalho <raphael.scarv at gmail.com> Wrote the documentation below. I think it would be good to push the doc to the wiki as soon as the UFS support gets merged. Unix Fast File System (UFS/FFS) 1/2 on Syslinux - (usage/install) ----- There is a confusion about the name of this file system, then I decided to contact the author who replied: "The name has always been

...;can_extents (b_conn->b, b_conn->conn); +} + static int next_can_fua (void *nxdata) { @@ -364,6 +371,16 @@ next_zero (void *nxdata, uint32_t count, uint64_t offset, uint32_t flags, return b_conn->b->zero (b_conn->b, b_conn->conn, count, offset, flags, err); } +static int +next_extents (void *nxdata, uint32_t count, uint64_t offset, uint32_t flags, + struct nbdkit_extents_map *extents_map, + int *err) +{ + struct b_conn *b_conn = nxdata; + return b_conn->b->extents (b_conn->b, b_conn->conn, count, offset, flags, +...

From: Raphael S. Carvalho <raphael.scarv at gmail.com> Change since v1: * Fix bug on dentry structure (thank you specification; btw, sarcasm), and consequently a bug on ufs_readdir. * Add readlink support (applied tests for symlinks whose destionation path were stored in blk pointers and the file itself). * Several improvements. Wrote the documentation below. I think it would be good to

...;can_extents (b_conn->b, b_conn->conn); +} + static int next_can_fua (void *nxdata) { @@ -364,6 +371,16 @@ next_zero (void *nxdata, uint32_t count, uint64_t offset, uint32_t flags, return b_conn->b->zero (b_conn->b, b_conn->conn, count, offset, flags, err); } +static int +next_extents (void *nxdata, uint32_t count, uint64_t offset, uint32_t flags, + struct nbdkit_extents_map *extents_map, + int *err) +{ + struct b_conn *b_conn = nxdata; + return b_conn->b->extents (b_conn->b, b_conn->conn, count, offset, flags, +...

Another couple things I noticed that are worth improving, but aren't strictly related to implementing fast zero support. Eric Blake (2): server: Assert sane error responses nozero: More efficient FUA handling filters/nozero/nozero.c | 17 +++++++++++-- server/filters.c | 56 +++++++++++++++++++++++++++++++++-------- server/protocol.c | 32 +++++++++++++++++------ 3 files

...;can_extents (b_conn->b, b_conn->conn); +} + static int next_can_fua (void *nxdata) { @@ -364,6 +371,15 @@ next_zero (void *nxdata, uint32_t count, uint64_t offset, uint32_t flags, return b_conn->b->zero (b_conn->b, b_conn->conn, count, offset, flags, err); } +static int +next_extents (void *nxdata, uint32_t count, uint64_t offset, uint32_t flags, + struct nbdkit_extents *extents, int *err) +{ + struct b_conn *b_conn = nxdata; + return b_conn->b->extents (b_conn->b, b_conn->conn, count, offset, flags, + extents, err); +} +...

This tentative commit implements extents/can_extents, roughly as discussed in the previous thread here: https://www.redhat.com/archives/libguestfs/2019-March/msg00017.html I can't say that I'm a big fan of having the plugin allocate an extents array. There are no other plugin callbacks currently where we require the plugin to allocate complex data structures (or indeed do any allocation

...;can_extents (b_conn->b, b_conn->conn); +} + static int next_can_fua (void *nxdata) { @@ -364,6 +371,15 @@ next_zero (void *nxdata, uint32_t count, uint64_t offset, uint32_t flags, return b_conn->b->zero (b_conn->b, b_conn->conn, count, offset, flags, err); } +static int +next_extents (void *nxdata, uint32_t count, uint64_t offset, uint32_t flags, + struct nbdkit_extents *extents, int *err) +{ + struct b_conn *b_conn = nxdata; + return b_conn->b->extents (b_conn->b, b_conn->conn, count, offset, flags, + extents, err); +} +...

I'm not sure which version we're up to now. Anyway I believe this addresses all the points that Eric raised in: https://www.redhat.com/archives/libguestfs/2019-March/msg00038.html https://www.redhat.com/archives/libguestfs/2019-March/msg00040.html In particular: - default state of extents_map is all allocated disk - support hole + non-zero - you can now iterate with bounds -

...;can_extents (b_conn->b, b_conn->conn); +} + static int next_can_fua (void *nxdata) { @@ -364,6 +371,15 @@ next_zero (void *nxdata, uint32_t count, uint64_t offset, uint32_t flags, return b_conn->b->zero (b_conn->b, b_conn->conn, count, offset, flags, err); } +static int +next_extents (void *nxdata, uint32_t count, uint64_t offset, uint32_t flags, + struct nbdkit_extents *extents, int *err) +{ + struct b_conn *b_conn = nxdata; + return b_conn->b->extents (b_conn->b, b_conn->conn, count, offset, flags, + extents, err); +} +...

Second version based on nbdkit_extent* calls, as discussed here: https://www.redhat.com/archives/libguestfs/2019-March/msg00033.html Note in particular there is some subtlety about how filters would work in this implementation. See docs/nbdkit-filter.pod for the details. Rich.

...zero (void *nxdata, uint32_t count, uint64_t offset, uint32_t flags, int *err) { - struct b_h *b_h = nxdata; - return backend_zero (b_h->b, count, offset, flags, err); + struct backend *b_next = nxdata; + return backend_zero (b_next, count, offset, flags, err); } static int next_extents (void *nxdata, uint32_t count, uint64_t offset, uint32_t flags, struct nbdkit_extents *extents, int *err) { - struct b_h *b_h = nxdata; - return backend_extents (b_h->b, count, offset, flags, - extents, err); + struct backend *b_next = nxdata; + retu...