search for: next_button

https://bugzilla.redhat.com/show_bug.cgi?id=823758

https://bugzilla.redhat.com/show_bug.cgi?id=1167921

...int type, const char *data); > +static int get_vcpus_from_conv_dlg (void); > +static uint64_t get_memory_from_conv_dlg (void); > > enum { > DISKS_COL_CONVERT = 0, > @@ -1051,6 +1053,32 @@ conversion_back_clicked (GtkWidget *w, gpointer data) > gtk_widget_set_sensitive (next_button, FALSE); > } > > +static int > +get_vcpus_from_conv_dlg (void) > +{ > + const char *str; > + int i; > + > + str = gtk_entry_get_text (GTK_ENTRY (vcpus_entry)); > + if (sscanf (str, "%d", &i) == 1 && i > 0) > + return i; > + els...

... and a small initial patch which makes it easier to test virt-p2v without having to start up a virtual machine. There is still a bug in Gtk 3 where the GtkTextView on the final (running) dialog ignores gtk_widget_set_size_request and so the window appears just a single pixel high. Rich.

This is basically the same as what I posted earlier today. The main difference is I split out the GDK thread sychronization (removal of) changes from the other Gtk 2/3 changes, which should make it a bit easier to review. Gtk 3 is still not quite perfect. Apart from the problem with the GtkTextView noted before, there are also vertical alignment and padding problems with labels in GtkGrid

...; static void notify_ui_callback (int type, const char *data); +static int get_vcpus_from_conv_dlg (void); +static uint64_t get_memory_from_conv_dlg (void); enum { DISKS_COL_CONVERT = 0, @@ -1051,6 +1053,32 @@ conversion_back_clicked (GtkWidget *w, gpointer data) gtk_widget_set_sensitive (next_button, FALSE); } +static int +get_vcpus_from_conv_dlg (void) +{ + const char *str; + int i; + + str = gtk_entry_get_text (GTK_ENTRY (vcpus_entry)); + if (sscanf (str, "%d", &i) == 1 && i > 0) + return i; + else + return 1; +} + +static uint64_t +get_memory_from_conv...

...----- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/scripts/ovirt-config-installer.py b/scripts/ovirt-config-installer.py index 46b917b..1dba72a 100644 --- a/scripts/ovirt-config-installer.py +++ b/scripts/ovirt-config-installer.py @@ -35,7 +35,7 @@ BACK_BUTTON = "Back" NEXT_BUTTON = "Next" FINISH_BUTTON = "Finish" INSTALL_BUTTON = "Install" -RESTART_BUTTON = "Restart" +REBOOT_BUTTON = "Reboot" POWEROFF_BUTTON = "Power Off" CONTINUE_BUTTON = "Continue" SHELL_BUTTON = "Drop To Shell" @@ -700,7...

..._("_Configure network ..."), 1, + _("_XTerm ..."), 2, + _("_About virt-p2v " PACKAGE_VERSION " ..."), 3, + _("_Next"), 4, NULL); next_button = gtk_dialog_get_widget_for_response (GTK_DIALOG (conn_dlg), 4); @@ -786,21 +790,23 @@ create_conversion_dialog (struct config *config) vbox_new (target_vbox, FALSE, 1); table_new (target_tbl, 3, 3); - guestname_label = gtk_label_new (_("Name:")); + guestname_label = gtk_label_n...

This version of the patch includes feedback from jboggs at redhat.com, including fixes to the BuildRequires and Requires in the spec file.

This patch obsoletes any previous ones. This is an upstream candidate, so I'm looking for feedback so we can push this and start using it.

This version fixes a few bugs found by jboggs. It also includes some logging facilities that need to be fleshed out more.

This patch is ready for pushing upstream.

The previous patch was missing this file. Resending.

...just looking for some feedback on the direction I'm going. The code won't get all the way to the define stage since I'm in the middle of retrofitting it to use virtinst instead of a home spun node definition.

A mixed bag, but all the patches make sense together! Patch 1: Fix a bug that Tingting found: https://bugzilla.redhat.com/show_bug.cgi?id=1256222 Patch 2: Revert a patch that makes no sense now that we've added virt-v2v into base RHEL. This is just included because it's a cleanup needed before applying patch 3. Patch 3: Add the ability to use SSH identities (private keys) for virt-p2v

Fixes https://bugzilla.redhat.com/1256222

Now that virt-p2v has its own repository [1] and releases [2], it is time to remove it from libguestfs. [1] https://github.com/libguestfs/virt-p2v [2] http://download.libguestfs.org/virt-p2v/ Pino Toscano (2): Remove virt-p2v Remove remaining virt-p2v bits .gitignore | 4 - Makefile.am | 7 +- bash/Makefile.am