search for: newsunit

Hello, Still trying to write a custom scheduler, I stumbled accross a highly suspicious code in all schedulers. In both ScheduleDAGFast.cpp and ScheduleDAGRRList.cpp, one can find this piece of code: SUnit *CopyFromSU = CreateNewSUnit(NULL); and then in the same files: SUnit *CreateNewSUnit(SDNode *N) { [...] SUnit *NewNode = NewSUnit(N); And finally in ScheduleDAGSDNodes.cpp: SUnit *ScheduleDAGSDNodes::NewSUnit(SDNode *N) { [...] if (N->isMachineOpcode() && [...] So basically, it means that calling C...

...lvm/CodeGen/ScheduleDAGSDNodes.h > =================================================================== > --- include/llvm/CodeGen/ScheduleDAGSDNodes.h (revision 61532) > +++ include/llvm/CodeGen/ScheduleDAGSDNodes.h (working copy) > @@ -103,10 +103,13 @@ > /// > SUnit *NewSUnit(SDNode *N) { > #ifndef NDEBUG > - const SUnit *Addr = &SUnits[0]; > + const SUnit *Addr = 0; > + if (SUnits.size() > 0) > + Addr = &SUnits[0]; > #endif > SUnits.push_back(SUnit(N, (unsigned)SUnits.size())); > - assert(Addr ==...

...or you? -bw Index: include/llvm/CodeGen/ScheduleDAGSDNodes.h =================================================================== --- include/llvm/CodeGen/ScheduleDAGSDNodes.h (revision 61532) +++ include/llvm/CodeGen/ScheduleDAGSDNodes.h (working copy) @@ -103,10 +103,13 @@ /// SUnit *NewSUnit(SDNode *N) { #ifndef NDEBUG - const SUnit *Addr = &SUnits[0]; + const SUnit *Addr = 0; + if (SUnits.size() > 0) + Addr = &SUnits[0]; #endif SUnits.push_back(SUnit(N, (unsigned)SUnits.size())); - assert(Addr == &SUnits[0] && "SUnits...

Bill Wendling wrote: > On Dec 30, 2008, at 4:51 PM, srs wrote: > > >> 2. There seems to be an issue in ScheduleDAGSDNodes.h when in debug >> mode. The problem is the evaluation of "&SUnits[0];" which ASSERT's in >> VC++'s vector[] implementation (when _HAS_ITERATOR_DEBUGGING is on). >> >> As a work-around, I commented out the debug

...n Roger Index: include/llvm/CodeGen/ScheduleDAGSDNodes.h =================================================================== --- include/llvm/CodeGen/ScheduleDAGSDNodes.h (revision 61500) +++ include/llvm/CodeGen/ScheduleDAGSDNodes.h (working copy) @@ -103,10 +103,10 @@ /// SUnit *NewSUnit(SDNode *N) { #ifndef NDEBUG - const SUnit *Addr = &SUnits[0]; + //const SUnit *Addr = &SUnits[0]; #endif SUnits.push_back(SUnit(N, (unsigned)SUnits.size())); - assert(Addr == &SUnits[0] && "SUnits std::vector reallocated on the fly!"); + /...

...m/CodeGen/ScheduleDAGSDNodes.h > =================================================================== > --- include/llvm/CodeGen/ScheduleDAGSDNodes.h (revision 61500) > +++ include/llvm/CodeGen/ScheduleDAGSDNodes.h (working copy) > @@ -103,10 +103,10 @@ > /// > SUnit *NewSUnit(SDNode *N) { > #ifndef NDEBUG > - const SUnit *Addr = &SUnits[0]; > + //const SUnit *Addr = &SUnits[0]; > #endif > SUnits.push_back(SUnit(N, (unsigned)SUnits.size())); > - assert(Addr == &SUnits[0] && "SUnits std::vector reallocated on...