Displaying 20 results from an estimated 263 matches for "newstyle".
2020 Sep 28
0
[libnbd PATCH 2/3] generator: Rename OPT_SET_META_CONTEXT states
Drop the SET designation, so that we can reuse these states for
OPT_LIST_META_CONTEXT in the next patch.
---
generator/Makefile.am | 4 +--
generator/state_machine.ml | 6 ++---
...t.c => states-newstyle-opt-meta-context.c} | 26 +++++++++----------
.../states-newstyle-opt-structured-reply.c | 4 +--
generator/states-newstyle.c | 2 +-
5 files changed, 21 insertions(+), 21 deletions(-)
rename generator/{states-newstyle-opt-set-meta-context.c => states-newstyle-opt-meta-co...
2019 May 19
5
[libnbd PATCH 0/4] Various interop fixes
...unencrypted
states: Reject payload to NBD_REP_ACK
meta-context: Skip error payload if server lacks meta_context
states: Add NBD_OPT_EXPORT_NAME handling
generator/Makefile.am | 1 +
generator/generator | 53 ++++++++++++++
generator/states-newstyle-opt-export-name.c | 73 +++++++++++++++++++
generator/states-newstyle-opt-go.c | 13 +++-
.../states-newstyle-opt-set-meta-context.c | 26 +++++--
generator/states-newstyle-opt-starttls.c | 27 ++++++-
.../states-newstyle-opt-structured-reply.c | 6 ++
generator/states-news...
2019 Sep 11
1
Re: [PATCH nbdkit] tests: Convert some tests to use nbdsh instead of qemu-io.
...ONNECTING
libnbd: debug: nbd5: nbd_connect_uri: transition: CONNECT.CONNECTING -> MAGIC.START
libnbd: debug: nbd5: nbd_connect_uri: transition: MAGIC.START -> MAGIC.RECV_MAGIC
libnbd: debug: nbd5: nbd_connect_uri: poll start: events=1
nbdkit: debug: accepted connection
nbdkit: full[1]: debug: newstyle negotiation: flags: global 0x3
libnbd: debug: nbd5: nbd_connect_uri: poll end: r=1 revents=1
libnbd: debug: nbd5: nbd_connect_uri: transition: MAGIC.RECV_MAGIC -> MAGIC.CHECK_MAGIC
libnbd: debug: nbd5: nbd_connect_uri: transition: MAGIC.CHECK_MAGIC -> NEWSTYLE.START
libnbd: debug: nbd5: nbd_c...
2019 May 19
0
[libnbd PATCH 4/4] states: Add NBD_OPT_EXPORT_NAME handling
Used both for servers that are not fixed newstyle, and for servers
that don't understand NBD_OPT_GO.
---
generator/Makefile.am | 1 +
generator/generator | 39 +++++++++++
generator/states-newstyle-opt-export-name.c | 73 +++++++++++++++++++++
generator/states-newstyle-opt-go.c | 8 +--...
2019 Jun 14
10
[libnbd PATCH 0/7] state machine refactoring
...reply parsing
states: Allow large SET_CONTEXT_NAME replies
states: Rewrite NBD_REP_INFO parsing
states: Factor out NBD_REP payload prep
states: Give up on oversized reply length
states: Capture NBD_REP_ERR message
generator/generator | 19 ++--
generator/states-newstyle-opt-go.c | 71 ++++++-------
.../states-newstyle-opt-set-meta-context.c | 99 +++++++------------
generator/states-newstyle-opt-starttls.c | 39 ++------
.../states-newstyle-opt-structured-reply.c | 34 +++----
generator/states-newstyle.c | 90 +++++++++++++++...
2019 Sep 11
4
[PATCH nbdkit] tests: Convert some tests to use nbdsh instead of qemu-io.
Very much a work in progress as there are still many tests using
qemu-io which are candidates for conversion.
You'll notice at the end of test-full.sh that the new test has some
duplicated code which looks as if it ought to be refactored into a
Python function. When I tried to do that, I got loads of strange
Python problems which may indicate bugs in nbdsh itself or problems
with my
2019 Jun 14
0
[libnbd PATCH 5/7] states: Factor out NBD_REP payload prep
...check for valid reply headers in each sub-state
machine, let's have a common helper function do all the
work. Additionally, a central location will make it easier to
uniformly capture any NBD_REP_ERR message payloads.
---
generator/generator | 8 +--
generator/states-newstyle-opt-go.c | 40 +++----------
.../states-newstyle-opt-set-meta-context.c | 39 ++-----------
generator/states-newstyle-opt-starttls.c | 31 ++--------
.../states-newstyle-opt-structured-reply.c | 28 ++-------
generator/states-newstyle.c | 58 +++++++++++++++++...
2019 Jun 14
0
[libnbd PATCH 7/7] states: Capture NBD_REP_ERR message
Similar to the earlier patch for structured reply errors, it's worth
logging (at least through debug) any error messages that the server
sends alongside NBD_REP_ERR. And given our earlier changes, it
doesn't really impact the size of struct nbd_handle.
---
generator/states-newstyle-opt-go.c | 5 ++--
.../states-newstyle-opt-set-meta-context.c | 6 +++-
generator/states-newstyle-opt-starttls.c | 8 ++---
.../states-newstyle-opt-structured-reply.c | 6 +++-
generator/states-newstyle.c | 29 +++++++++++++++++++
lib/internal.h...
2019 Sep 17
0
[PATCH libnbd 2/2] api: New API for reading NBD protocol.
This commit adds a new API which can be used from the connected to
state to read back which NBD protocol (eg. oldstyle, newstyle-fixed)
we are using.
It was helpful to add a new state in newstyle negotiation
(%NEWSTYLE.FINISHED) so we can route all successful option
negotiations through a single path before moving to the %READY state,
allowing us to set h->protocol in one place.
---
generator/generator...
2019 Sep 17
3
[PATCH libnbd 1/2] api: Add new API to read whether TLS was negotiated.
...ould be but requires quite a complicated set of
tests because ideally we'd like to find out whether it falls back
correctly for all supported servers.
---
TODO | 3 +++
generator/generator | 34 +++++++++++++++++++++---
generator/states-newstyle-opt-starttls.c | 1 +
lib/crypto.c | 6 +++++
lib/internal.h | 3 +++
5 files changed, 43 insertions(+), 4 deletions(-)
diff --git a/TODO b/TODO
index 642d39f..21feb2f 100644
--- a/TODO
+++ b/TODO
@@ -17,6 +17,9 @@ NBD_INFO_BLOCK_SIZE.
TL...
2019 Sep 16
1
[libnbd PATCH] states: Avoid magic number for h->tls
...ges (confusing since 632196ec,
and copy-and-pasted into more locations since then).
Fixes: 4488cf2a
Thanks: Rich Jones
---
Rich noticed this while reviewing the patch for today's CVE fix. It's
not a show-stopper if this doesn't get included in today's releases.
generator/states-newstyle-opt-starttls.c | 8 ++++----
generator/states-newstyle.c | 4 ++--
generator/states-oldstyle.c | 6 +++---
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/generator/states-newstyle-opt-starttls.c b/generator/states-newstyle-opt-starttls.c
index 0a18db0..b050...
2020 Aug 14
0
[libnbd PATCH v2 06/13] api: Add nbd_opt_abort and nbd_aio_opt_abort
It is finally time to introduce our first negotiating option command.
With this change, we can now enter NEWSTYLE.START more than once; as
such, it needs to know whether it is the first entry (proceed with
gflags/cflags, TLS, and structured reply) or a later entry (all
nbd_opt_* will cause an IssueCommand event to kick the state machine
out of NEGOTIATING, at which point we want to jump to the sub-state
approp...
2019 Sep 12
3
[nbdkit PATCH 0/2] Make client fallback testing easier
...pple the protocol from either the server or the client
side, to see how the other side reacts, similar to the recently-added
nbd_set_request_structured_replies).
I'm open to naming suggestions on the command-line option.
Eric Blake (2):
server: Skip option haggling from client lacking fixed newstyle
server: Add --mask-handshake option for integration testing
docs/nbdkit-protocol.pod | 25 ++++++++++++++++++-----
docs/synopsis.txt | 2 +-
server/internal.h | 1 +
server/options.h | 2 ++
server/main.c...
2020 Sep 28
8
[libnbd PATCH 0/3] opt_list_meta_context
...s
api: Add nbd_opt_list_meta_context
lib/internal.h | 1 +
generator/API.ml | 162 +++++++++++++++++-
generator/Makefile.am | 4 +-
generator/state_machine.ml | 6 +-
...t.c => states-newstyle-opt-meta-context.c} | 106 ++++++++----
.../states-newstyle-opt-structured-reply.c | 4 +-
generator/states-newstyle.c | 5 +-
lib/handle.c | 32 ++++
lib/opt.c | 73 ++++++++
tests/meta-base-allocation....
2019 Jun 29
0
[libnbd PATCH 2/6] generator: Allow DEAD state actions to run
...0, then letting DEAD's code return -1.
---
generator/generator | 30 +++++++---
generator/states-connect.c | 24 ++++----
generator/states-issue-command.c | 4 +-
generator/states-magic.c | 6 +-
generator/states-newstyle-opt-export-name.c | 8 +--
generator/states-newstyle-opt-go.c | 20 +++----
.../states-newstyle-opt-set-meta-context.c | 24 ++++----
generator/states-newstyle-opt-starttls.c | 18 +++---
.../states-newstyle-opt-structured-reply.c | 10 ++--
generator/states-newstyle.c...
2018 Jan 23
1
[PATCH nbdkit] Change the default protocol to newstyle.
nbdkit <= 1.1.28 defaulted to the oldstyle protocol for compatibility
with qemu and libguestfs. However qemu >= 2.6 can now work with
either protocol and is widely installed. Also newstyle is required
for newer features such as export names and TLS. In addition
nbd-client dropped support for oldstyle entirely.
You can select the oldstyle protocol by adding ‘-o’, and it is still
tested.
---
TODO | 6 ++++++
docs/nbdkit.pod | 29 +++++++++++++++--------------
s...
2019 Sep 17
1
Re: [PATCH libnbd 2/2] api: New API for reading NBD protocol.
On 9/17/19 5:02 AM, Richard W.M. Jones wrote:
> This commit adds a new API which can be used from the connected to
> state to read back which NBD protocol (eg. oldstyle, newstyle-fixed)
> we are using.
Somewhat of an overlap with my get_handshake_flags (as newstyle-fixed
corresponds to whether handshake_flags includes the FIXED_NEWSTYLE
flag), but I don't see the redundancy as an issue.
>
> It was helpful to add a new state in newstyle negotiation
> (%NEW...
2019 Sep 12
0
[nbdkit PATCH 2/2] server: Add --mask-handshake option for integration testing
...cs/nbdkit-protocol.pod | 25 ++++++++++++++++++-----
docs/synopsis.txt | 2 +-
server/internal.h | 1 +
server/options.h | 2 ++
server/main.c | 30 ++++++++++++++++++----------
server/protocol-handshake-newstyle.c | 4 ++--
6 files changed, 45 insertions(+), 19 deletions(-)
diff --git a/docs/nbdkit-protocol.pod b/docs/nbdkit-protocol.pod
index 3ae89063..272f4e5b 100644
--- a/docs/nbdkit-protocol.pod
+++ b/docs/nbdkit-protocol.pod
@@ -4,8 +4,8 @@ nbdkit - which parts of the NBD protocol nbdkit supports...
2019 Jun 08
0
[PATCH libnbd 3/3] states: Use MSG_MORE to coalesce messages into single packets.
...09'
before applying this patch:
real 0m54.151s
real 0m54.950s
real 0m55.927s
and after applying this patch:
real 0m39.154s
real 0m44.249s
real 0m44.027s
Thanks: Eric Blake for suggesting this change.
---
generator/states-issue-command.c | 2 ++
generator/states-newstyle-opt-export-name.c | 1 +
generator/states-newstyle-opt-go.c | 3 +++
generator/states-newstyle-opt-set-meta-context.c | 5 +++++
4 files changed, 11 insertions(+)
diff --git a/generator/states-issue-command.c b/generator/states-issue-command.c
index 627a54f..cce43d7 100644
--- a...
2016 Jan 11
1
[PATCH] Add support for newstyle NBD protocol (RHBZ#1297100).
Experimental and only very lightly tested so far.
Rich.