search for: networkplumber

...ry into the outgoing scatter list. This bug has been there since: commit f565a7c259d71cc186753653d978c646d2354b36 Author: Alex Williamson <alex.williamson at hp.com> Date: Wed Feb 4 09:02:45 2009 +0000 virtio_net: Add a MAC filter table Signed-off-by: Stephen Hemminger <stephen at networkplumber.org> --- a/drivers/net/virtio_net.c 2013-12-09 16:12:03.897891975 -0800 +++ b/drivers/net/virtio_net.c 2013-12-09 16:12:36.353164803 -0800 @@ -893,7 +893,7 @@ static bool virtnet_send_command(struct sg_init_one(&hdr, &ctrl, sizeof(ctrl)); sgs[out_num++] = &hdr; - if (out) + fo...

...ry into the outgoing scatter list. This bug has been there since: commit f565a7c259d71cc186753653d978c646d2354b36 Author: Alex Williamson <alex.williamson at hp.com> Date: Wed Feb 4 09:02:45 2009 +0000 virtio_net: Add a MAC filter table Signed-off-by: Stephen Hemminger <stephen at networkplumber.org> --- a/drivers/net/virtio_net.c 2013-12-09 16:12:03.897891975 -0800 +++ b/drivers/net/virtio_net.c 2013-12-09 16:12:36.353164803 -0800 @@ -893,7 +893,7 @@ static bool virtnet_send_command(struct sg_init_one(&hdr, &ctrl, sizeof(ctrl)); sgs[out_num++] = &hdr; - if (out) + fo...

From: Stephen Hemminger <stephen at networkplumber.org> Date: Tue, 19 Dec 2017 09:55:48 -0800 > could be 10ms, just enough to let udev do its renaming Please, move to some kind of notification or event based handling of this problem. No delay is safe, what if userspace gets swapped out or whatever else might make userspace stall unexpected...

From: Stephen Hemminger <stephen at networkplumber.org> Date: Tue, 19 Dec 2017 09:55:48 -0800 > could be 10ms, just enough to let udev do its renaming Please, move to some kind of notification or event based handling of this problem. No delay is safe, what if userspace gets swapped out or whatever else might make userspace stall unexpected...

When fail, translate_desc() returns negative value, otherwise the number of iovs. So we should fail when the return value is negative instead of a blindly check against zero. Reported-by: Stephen Hemminger <stephen at networkplumber.org> Fixes: cc5e71075947 ("vhost: log dirty page correctly") Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/vhost/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index 24a129fcdd61..a2e5dc7...

When fail, translate_desc() returns negative value, otherwise the number of iovs. So we should fail when the return value is negative instead of a blindly check against zero. Reported-by: Stephen Hemminger <stephen at networkplumber.org> Fixes: cc5e71075947 ("vhost: log dirty page correctly") Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/vhost/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index 24a129fcdd61..a2e5dc7...

...unsigned long guest_offloads[] = { > Why is this delay necessary? And why by 100ms? This is based on netvsc implementation and here is the commit that added this delay.? Not sure if this needs to be 100ms. commit 6123c66854c174e4982f98195100c1d990f9e5e6 Author: stephen hemminger <stephen at networkplumber.org> Date:?? Wed Aug 9 17:46:03 2017 -0700 ??? netvsc: delay setup of VF device ??? When VF device is discovered, delay bring it automatically up in ??? order to allow userspace to some simple changes (like renaming).

...unsigned long guest_offloads[] = { > Why is this delay necessary? And why by 100ms? This is based on netvsc implementation and here is the commit that added this delay.? Not sure if this needs to be 100ms. commit 6123c66854c174e4982f98195100c1d990f9e5e6 Author: stephen hemminger <stephen at networkplumber.org> Date:?? Wed Aug 9 17:46:03 2017 -0700 ??? netvsc: delay setup of VF device ??? When VF device is discovered, delay bring it automatically up in ??? order to allow userspace to some simple changes (like renaming).

The original comment was not really informative or funny as well as sexist. Replace it with a better explanation of why the driver does stop and what the impacts are. Signed-off-by: Stephen Hemminger <stephen at networkplumber.org> --- a/drivers/net/virtio_net.c 2015-03-24 15:20:25.174671000 -0700 +++ b/drivers/net/virtio_net.c 2015-03-24 16:17:28.478525333 -0700 @@ -939,8 +939,12 @@ static netdev_tx_t start_xmit(struct sk_ skb_orphan(skb); nf_reset(skb); - /* Apparently nice girls don't return TX_BUSY; sto...

The original comment was not really informative or funny as well as sexist. Replace it with a better explanation of why the driver does stop and what the impacts are. Signed-off-by: Stephen Hemminger <stephen at networkplumber.org> --- a/drivers/net/virtio_net.c 2015-03-24 15:20:25.174671000 -0700 +++ b/drivers/net/virtio_net.c 2015-03-24 16:17:28.478525333 -0700 @@ -939,8 +939,12 @@ static netdev_tx_t start_xmit(struct sk_ skb_orphan(skb); nf_reset(skb); - /* Apparently nice girls don't return TX_BUSY; sto...

On 12/19/2017 10:41 AM, Stephen Hemminger wrote: > On Tue, 19 Dec 2017 13:21:17 -0500 (EST) > David Miller <davem at davemloft.net> wrote: > >> From: Stephen Hemminger <stephen at networkplumber.org> >> Date: Tue, 19 Dec 2017 09:55:48 -0800 >> >>> could be 10ms, just enough to let udev do its renaming >> Please, move to some kind of notification or event based handling of >> this problem. >> >> No delay is safe, what if userspace gets swapped...

On 12/19/2017 10:41 AM, Stephen Hemminger wrote: > On Tue, 19 Dec 2017 13:21:17 -0500 (EST) > David Miller <davem at davemloft.net> wrote: > >> From: Stephen Hemminger <stephen at networkplumber.org> >> Date: Tue, 19 Dec 2017 09:55:48 -0800 >> >>> could be 10ms, just enough to let udev do its renaming >> Please, move to some kind of notification or event based handling of >> this problem. >> >> No delay is safe, what if userspace gets swapped...

Sat, Feb 24, 2018 at 12:59:04AM CET, stephen at networkplumber.org wrote: >On Thu, 22 Feb 2018 13:30:12 -0800 >Alexander Duyck <alexander.duyck at gmail.com> wrote: > >> > Again, I undertand your motivation. Yet I don't like your solution. >> > But if the decision is made to do this in-driver bonding. I would like >>...

Sat, Feb 24, 2018 at 12:59:04AM CET, stephen at networkplumber.org wrote: >On Thu, 22 Feb 2018 13:30:12 -0800 >Alexander Duyck <alexander.duyck at gmail.com> wrote: > >> > Again, I undertand your motivation. Yet I don't like your solution. >> > But if the decision is made to do this in-driver bonding. I would like >>...

...<sridhar.samudrala at intel.com> wrote: > >> On 12/19/2017 10:41 AM, Stephen Hemminger wrote: >>> On Tue, 19 Dec 2017 13:21:17 -0500 (EST) >>> David Miller <davem at davemloft.net> wrote: >>> >>>> From: Stephen Hemminger <stephen at networkplumber.org> >>>> Date: Tue, 19 Dec 2017 09:55:48 -0800 >>>> >>>>> could be 10ms, just enough to let udev do its renaming >>>> Please, move to some kind of notification or event based handling of >>>> this problem. >>>> >&g...

...<sridhar.samudrala at intel.com> wrote: > >> On 12/19/2017 10:41 AM, Stephen Hemminger wrote: >>> On Tue, 19 Dec 2017 13:21:17 -0500 (EST) >>> David Miller <davem at davemloft.net> wrote: >>> >>>> From: Stephen Hemminger <stephen at networkplumber.org> >>>> Date: Tue, 19 Dec 2017 09:55:48 -0800 >>>> >>>>> could be 10ms, just enough to let udev do its renaming >>>> Please, move to some kind of notification or event based handling of >>>> this problem. >>>> >&g...

On Fri, 20 Apr 2018 18:00:58 +0200 Jiri Pirko <jiri at resnulli.us> wrote: > Fri, Apr 20, 2018 at 05:28:02PM CEST, stephen at networkplumber.org wrote: > >On Thu, 19 Apr 2018 18:42:04 -0700 > >Sridhar Samudrala <sridhar.samudrala at intel.com> wrote: > > > >> Use the registration/notification framework supported by the generic > >> failover infrastructure. > >> > >> Signed-o...

On Fri, 20 Apr 2018 18:00:58 +0200 Jiri Pirko <jiri at resnulli.us> wrote: > Fri, Apr 20, 2018 at 05:28:02PM CEST, stephen at networkplumber.org wrote: > >On Thu, 19 Apr 2018 18:42:04 -0700 > >Sridhar Samudrala <sridhar.samudrala at intel.com> wrote: > > > >> Use the registration/notification framework supported by the generic > >> failover infrastructure. > >> > >> Signed-o...

New file seems to have missed the SPDX license scan and update. Signed-off-by: Stephen Hemminger <sthemmin at microsoft.com> --- include/uapi/linux/vm_sockets_diag.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/vm_sockets_diag.h b/include/uapi/linux/vm_sockets_diag.h index 14cd7dc5a187..0b4dd54f3d1e 100644 --- a/include/uapi/linux/vm_sockets_diag.h +++

...alue is negative instead of a blindly check against zero. Detected by CoverityScan, CID# 1442593: Control flow issues (DEADCODE) Fixes: cc5e71075947 ("vhost: log dirty page correctly") Acked-by: Michael S. Tsirkin <mst at redhat.com> Reported-by: Stephen Hemminger <stephen at networkplumber.org> Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/vhost/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index 24a129fcdd61..a2e5dc7716e2 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost...