search for: netvsc_initialize

These fields have been assigned in netvsc_drv_init() before calling netvsc_initialize(), so there is no need to check them. The ASSERTs were already commented out, and this patch removes them. Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com> Signed-off-by: K. Y. Srinivasan <kys at microsoft.com> Signed-off-by: Hank Janssen <hjanssen at microsoft.com> ---...

These fields have been assigned in netvsc_drv_init() before calling netvsc_initialize(), so there is no need to check them. The ASSERTs were already commented out, and this patch removes them. Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com> Signed-off-by: K. Y. Srinivasan <kys at microsoft.com> Signed-off-by: Hank Janssen <hjanssen at microsoft.com> ---...

...c_device_remove(struct hyperv_device *device); -static void netvsc_cleanup(struct hv_driver *driver); +static void netvsc_cleanup(struct driver_context *driver); static void netvsc_channel_cb(void *context); @@ -178,7 +178,7 @@ static struct netvsc_device *release_inbound_net_device( /* * netvsc_initialize - Main entry point */ -int netvsc_initialize(struct hv_driver *drv) +int netvsc_initialize(struct driver_context *drv) { struct netvsc_driver *driver = (struct netvsc_driver *)drv; @@ -837,7 +837,7 @@ static int netvsc_device_remove(struct hyperv_device *device) /* * netvsc_cleanup - Perf...

...c_device_remove(struct hyperv_device *device); -static void netvsc_cleanup(struct hv_driver *driver); +static void netvsc_cleanup(struct driver_context *driver); static void netvsc_channel_cb(void *context); @@ -178,7 +178,7 @@ static struct netvsc_device *release_inbound_net_device( /* * netvsc_initialize - Main entry point */ -int netvsc_initialize(struct hv_driver *drv) +int netvsc_initialize(struct driver_context *drv) { struct netvsc_driver *driver = (struct netvsc_driver *)drv; @@ -837,7 +837,7 @@ static int netvsc_device_remove(struct hyperv_device *device) /* * netvsc_cleanup - Perf...

From: haiyangz <haiyangz at hz-dev.msft.interop.novell.com> This patch series cleans up forward declarations and the remaining camel cases in netvsc.c Haiyang Zhang (8): staging: hv: move netvsc_initialize() to clean up forward declaration staging: hv: move netvsc_receive_completion() to clean up forward declaration staging: hv: move netvsc_send_recv_completion() to clean up forward declaration staging: hv: move netvsc_destroy_recv_buf() to clean up forward declaration staging: hv...

From: haiyangz <haiyangz at hz-dev.msft.interop.novell.com> This patch series cleans up forward declarations and the remaining camel cases in netvsc.c Haiyang Zhang (8): staging: hv: move netvsc_initialize() to clean up forward declaration staging: hv: move netvsc_receive_completion() to clean up forward declaration staging: hv: move netvsc_send_recv_completion() to clean up forward declaration staging: hv: move netvsc_destroy_recv_buf() to clean up forward declaration staging: hv...

...vice_remove(struct hyperv_device *device); -static void netvsc_cleanup(struct driver_context *driver); +static void netvsc_cleanup(struct hyperv_driver *driver); static void netvsc_channel_cb(void *context); @@ -178,7 +178,7 @@ static struct netvsc_device *release_inbound_net_device( /* * netvsc_initialize - Main entry point */ -int netvsc_initialize(struct driver_context *drv) +int netvsc_initialize(struct hyperv_driver *drv) { struct netvsc_driver *driver = (struct netvsc_driver *)drv; @@ -837,7 +837,7 @@ static int netvsc_device_remove(struct hyperv_device *device) /* * netvsc_cleanup -...

...vice_remove(struct hyperv_device *device); -static void netvsc_cleanup(struct driver_context *driver); +static void netvsc_cleanup(struct hyperv_driver *driver); static void netvsc_channel_cb(void *context); @@ -178,7 +178,7 @@ static struct netvsc_device *release_inbound_net_device( /* * netvsc_initialize - Main entry point */ -int netvsc_initialize(struct driver_context *drv) +int netvsc_initialize(struct hyperv_driver *drv) { struct netvsc_driver *driver = (struct netvsc_driver *)drv; @@ -837,7 +837,7 @@ static int netvsc_device_remove(struct hyperv_device *device) /* * netvsc_cleanup -...

Further cleanup of the hv drivers. 1) Implement code for autoloading the vmbus drivers without using PCI or DMI signatures. I have implemented this based on Greg's feedback on my earlier implementation. 2) Cleanup error handling across the board and use standard Linux error codes. 3) General cleanup Regards, K. Y

Further cleanup of the hv drivers. 1) Implement code for autoloading the vmbus drivers without using PCI or DMI signatures. I have implemented this based on Greg's feedback on my earlier implementation. 2) Cleanup error handling across the board and use standard Linux error codes. 3) General cleanup Regards, K. Y

...ruct netvsc_device *release_outbound_net_device( } static struct netvsc_device *release_inbound_net_device( - struct hv_device *device) + struct hyperv_device *device) { struct netvsc_device *net_device; @@ -174,7 +178,7 @@ static struct netvsc_device *release_inbound_net_device( /* * netvsc_initialize - Main entry point */ -int netvsc_initialize(struct hv_driver *drv) +int netvsc_initialize(struct hyperv_driver *drv) { struct netvsc_driver *driver = (struct netvsc_driver *)drv; @@ -186,7 +190,7 @@ int netvsc_initialize(struct hv_driver *drv) sizeof(struct vmtransfer_page_packet_head...

...ruct netvsc_device *release_outbound_net_device( } static struct netvsc_device *release_inbound_net_device( - struct hv_device *device) + struct hyperv_device *device) { struct netvsc_device *net_device; @@ -174,7 +178,7 @@ static struct netvsc_device *release_inbound_net_device( /* * netvsc_initialize - Main entry point */ -int netvsc_initialize(struct hv_driver *drv) +int netvsc_initialize(struct hyperv_driver *drv) { struct netvsc_driver *driver = (struct netvsc_driver *)drv; @@ -186,7 +190,7 @@ int netvsc_initialize(struct hv_driver *drv) sizeof(struct vmtransfer_page_packet_head...

...ivers/staging/hv/netvsc.c +++ b/drivers/staging/hv/netvsc.c @@ -134,7 +134,6 @@ static void put_net_device(struct hv_device *device) struct netvsc_device *net_device; net_device = device->ext; - /* ASSERT(netDevice); */ atomic_dec(&net_device->refcnt); } @@ -186,9 +185,6 @@ int netvsc_initialize(struct hv_driver *drv) sizeof(struct nvsp_message), sizeof(struct vmtransfer_page_packet_header)); - /* Make sure we are at least 2 pages since 1 page is used for control */ - /* ASSERT(driver->RingBufferSize >= (PAGE_SIZE << 1)); */ - drv->name = driver_name; memcp...

...ivers/staging/hv/netvsc.c +++ b/drivers/staging/hv/netvsc.c @@ -134,7 +134,6 @@ static void put_net_device(struct hv_device *device) struct netvsc_device *net_device; net_device = device->ext; - /* ASSERT(netDevice); */ atomic_dec(&net_device->refcnt); } @@ -186,9 +185,6 @@ int netvsc_initialize(struct hv_driver *drv) sizeof(struct nvsp_message), sizeof(struct vmtransfer_page_packet_header)); - /* Make sure we are at least 2 pages since 1 page is used for control */ - /* ASSERT(driver->RingBufferSize >= (PAGE_SIZE << 1)); */ - drv->name = driver_name; memcp...

netif_carrier_off() was called earlier in this function, and there is no other thread access this device yet. The status checking code is not necessary here. Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com> Signed-off-by: K. Y. Srinivasan <kys at microsoft.com> Signed-off-by: Abhishek Kane <v-abkane at microsoft.com> Signed-off-by: Hank Janssen <hjanssen at

netif_carrier_off() was called earlier in this function, and there is no other thread access this device yet. The status checking code is not necessary here. Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com> Signed-off-by: K. Y. Srinivasan <kys at microsoft.com> Signed-off-by: Abhishek Kane <v-abkane at microsoft.com> Signed-off-by: Hank Janssen <hjanssen at

Further cleanup of the hv drivers. Back in June I had sent two patch sets to address these issues. I have addressed the comments I got from the community on my earlier patches here: 1) Implement code for autoloading the vmbus drivers without using PCI or DMI signatures. I have implemented this based on Greg's feedback on my earlier implementation. 2) Cleanup error handling across

Further cleanup of the hv drivers. Back in June I had sent two patch sets to address these issues. I have addressed the comments I got from the community on my earlier patches here: 1) Implement code for autoloading the vmbus drivers without using PCI or DMI signatures. I have implemented this based on Greg's feedback on my earlier implementation. 2) Cleanup error handling across

...struct netvsc_device *net_device; @@ -155,7 +156,7 @@ static struct netvsc_device *release_outbound_net_device( } static struct netvsc_device *release_inbound_net_device( - struct hv_device *device) + struct vm_device *device) { struct netvsc_device *net_device; @@ -186,7 +187,7 @@ int netvsc_initialize(struct hv_driver *drv) sizeof(struct vmtransfer_page_packet_header)); drv->name = driver_name; - memcpy(&drv->dev_type, &netvsc_device_type, sizeof(struct hv_guid)); + memcpy(&drv->class_id, &netvsc_device_type, sizeof(struct hv_guid)); /* Setup the dispatch t...

...struct netvsc_device *net_device; @@ -155,7 +156,7 @@ static struct netvsc_device *release_outbound_net_device( } static struct netvsc_device *release_inbound_net_device( - struct hv_device *device) + struct vm_device *device) { struct netvsc_device *net_device; @@ -186,7 +187,7 @@ int netvsc_initialize(struct hv_driver *drv) sizeof(struct vmtransfer_page_packet_header)); drv->name = driver_name; - memcpy(&drv->dev_type, &netvsc_device_type, sizeof(struct hv_guid)); + memcpy(&drv->class_id, &netvsc_device_type, sizeof(struct hv_guid)); /* Setup the dispatch t...