search for: netif_tx_stop_all_queu

...deletions(-) > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index fa17afa..d80fef4 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c [...] > @@ -1430,7 +1426,7 @@ static void virtnet_config_changed_work(struct work_struct *work) > netif_tx_stop_all_queues(vi->dev); > } > done: > - mutex_unlock(&vi->config_lock); > + return; There's no need for this *return*. > } > > static void virtnet_config_changed(struct virtio_device *vdev) WBR, Sergei

...deletions(-) > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index fa17afa..d80fef4 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c [...] > @@ -1430,7 +1426,7 @@ static void virtnet_config_changed_work(struct work_struct *work) > netif_tx_stop_all_queues(vi->dev); > } > done: > - mutex_unlock(&vi->config_lock); > + return; There's no need for this *return*. > } > > static void virtnet_config_changed(struct virtio_device *vdev) WBR, Sergei

...io_net.c b/drivers/net/virtio_net.c >>> index fa17afa..d80fef4 100644 >>> --- a/drivers/net/virtio_net.c >>> +++ b/drivers/net/virtio_net.c >> [...] >>> @@ -1430,7 +1426,7 @@ static void virtnet_config_changed_work(struct work_struct *work) >>> netif_tx_stop_all_queues(vi->dev); >>> } >>> done: >>> - mutex_unlock(&vi->config_lock); >>> + return; >> There's no need for this *return*. > I know - it's removed by the follow-up patch. Yeah, I saw. > It's formatted like this to mak...

...io_net.c b/drivers/net/virtio_net.c >>> index fa17afa..d80fef4 100644 >>> --- a/drivers/net/virtio_net.c >>> +++ b/drivers/net/virtio_net.c >> [...] >>> @@ -1430,7 +1426,7 @@ static void virtnet_config_changed_work(struct work_struct *work) >>> netif_tx_stop_all_queues(vi->dev); >>> } >>> done: >>> - mutex_unlock(&vi->config_lock); >>> + return; >> There's no need for this *return*. > I know - it's removed by the follow-up patch. Yeah, I saw. > It's formatted like this to mak...

...imary_dev)) || > > > + (standby_dev && failover_xmit_ready(standby_dev))) { > > > + netif_carrier_on(failover_dev); > > > + netif_tx_wake_all_queues(failover_dev); > > > + } else { > > > + netif_carrier_off(failover_dev); > > > + netif_tx_stop_all_queues(failover_dev); > > And I think it's a good idea to get stats from device here too. > > Not sure why we need to get stats from lower devs here? link down is often indication of a hardware problem. lower dev might stop responding down the road. > > > +static const struct...

...6 deletions(-) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index fa17afa..d80fef4 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -1430,7 +1426,7 @@ static void virtnet_config_changed_work(struct work_struct *work) > netif_tx_stop_all_queues(vi->dev); > } > done: > - mutex_unlock(&vi->config_lock); > + return; > } > > static void virtnet_config_changed(struct virtio_device *vdev) I'd probably return directly in the remaining 'goto done;' cases, but still Reviewed-by: Cornelia Huck &l...

...6 deletions(-) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index fa17afa..d80fef4 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -1430,7 +1426,7 @@ static void virtnet_config_changed_work(struct work_struct *work) > netif_tx_stop_all_queues(vi->dev); > } > done: > - mutex_unlock(&vi->config_lock); > + return; > } > > static void virtnet_config_changed(struct virtio_device *vdev) I'd probably return directly in the remaining 'goto done;' cases, but still Reviewed-by: Cornelia Huck &l...

...&& failover_xmit_ready(standby_dev))) { >> > > + netif_carrier_on(failover_dev); >> > > + netif_tx_wake_all_queues(failover_dev); >> > > + } else { >> > > + netif_carrier_off(failover_dev); >> > > + netif_tx_stop_all_queues(failover_dev); >> > And I think it's a good idea to get stats from device here too. >> >> Not sure why we need to get stats from lower devs here? > > link down is often indication of a hardware problem. > lower dev might stop responding down the road. > >&g...

...virtnet_info, config_work); u16 v; - mutex_lock(&vi->config_lock); if (virtio_cread_feature(vi->vdev, VIRTIO_NET_F_STATUS, struct virtio_net_config, status, &v) < 0) goto done; @@ -1430,7 +1426,7 @@ static void virtnet_config_changed_work(struct work_struct *work) netif_tx_stop_all_queues(vi->dev); } done: - mutex_unlock(&vi->config_lock); + return; } static void virtnet_config_changed(struct virtio_device *vdev) @@ -1751,7 +1747,6 @@ static int virtnet_probe(struct virtio_device *vdev) u64_stats_init(&virtnet_stats->rx_syncp); } - mutex_init(&vi...

...atic void virtnet_config_changed_work(struct work_struct *work) v &= VIRTIO_NET_S_LINK_UP; if (vi->status == v) - goto done; + return; vi->status = v; @@ -1425,8 +1425,6 @@ static void virtnet_config_changed_work(struct work_struct *work) netif_carrier_off(vi->dev); netif_tx_stop_all_queues(vi->dev); } -done: - return; } static void virtnet_config_changed(struct virtio_device *vdev) -- MST

...--git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > >index fa17afa..d80fef4 100644 > >--- a/drivers/net/virtio_net.c > >+++ b/drivers/net/virtio_net.c > [...] > >@@ -1430,7 +1426,7 @@ static void virtnet_config_changed_work(struct work_struct *work) > > netif_tx_stop_all_queues(vi->dev); > > } > > done: > >- mutex_unlock(&vi->config_lock); > >+ return; > > There's no need for this *return*. > I know - it's removed by the follow-up patch. It's formatted like this to make diff smaller and make review easier....

...irtio_net.c > >>>index fa17afa..d80fef4 100644 > >>>--- a/drivers/net/virtio_net.c > >>>+++ b/drivers/net/virtio_net.c > >>[...] > >>>@@ -1430,7 +1426,7 @@ static void virtnet_config_changed_work(struct work_struct *work) > >>> netif_tx_stop_all_queues(vi->dev); > >>> } > >>> done: > >>>- mutex_unlock(&vi->config_lock); > >>>+ return; > > >> There's no need for this *return*. > > >I know - it's removed by the follow-up patch. > > Yeah, I saw...

Rusty, I have a mind to send this patches for the next merge window. Any input on this? This fixes the following virtio spec compliance issues: 1. on restore, drivers use device before setting ACKNOWLEDGE and DRIVER bits 2. on probe, drivers aren't prepared to handle config interrupts arriving before probe returns 3. on probe, drivers use device before DRIVER_OK it set Note that 1 is a

Rusty, I have a mind to send this patches for the next merge window. Any input on this? This fixes the following virtio spec compliance issues: 1. on restore, drivers use device before setting ACKNOWLEDGE and DRIVER bits 2. on probe, drivers aren't prepared to handle config interrupts arriving before probe returns 3. on probe, drivers use device before DRIVER_OK it set Note that 1 is a

Patch 1 introduces a new feature bit VIRTIO_NET_F_BACKUP that can be used by hypervisor to indicate that virtio_net interface should act as a backup for another device with the same MAC address. Ppatch 2 is in response to the community request for a 3 netdev solution. However, it creates some issues we'll get into in a moment. It extends virtio_net to use alternate datapath when available

Patch 1 introduces a new feature bit VIRTIO_NET_F_BACKUP that can be used by hypervisor to indicate that virtio_net interface should act as a backup for another device with the same MAC address. Ppatch 2 is in response to the community request for a 3 netdev solution. However, it creates some issues we'll get into in a moment. It extends virtio_net to use alternate datapath when available

...&& bypass_xmit_ready(backup_netdev))) { >> > > > + netif_carrier_on(bypass_netdev); >> > > > + netif_tx_wake_all_queues(bypass_netdev); >> > > > + } else { >> > > > + netif_carrier_off(bypass_netdev); >> > > > + netif_tx_stop_all_queues(bypass_netdev); >> > > > + } >> > > > + >> > > > +done: >> > > > + return NOTIFY_DONE; >> > > > +} >> > > > + >> > > > +static bool bypass_validate_event_dev(struct net_device *dev) >> &...

...&& bypass_xmit_ready(backup_netdev))) { >> > > > + netif_carrier_on(bypass_netdev); >> > > > + netif_tx_wake_all_queues(bypass_netdev); >> > > > + } else { >> > > > + netif_carrier_off(bypass_netdev); >> > > > + netif_tx_stop_all_queues(bypass_netdev); >> > > > + } >> > > > + >> > > > +done: >> > > > + return NOTIFY_DONE; >> > > > +} >> > > > + >> > > > +static bool bypass_validate_event_dev(struct net_device *dev) >> &...

..._bypass_xmit_ready(active_netdev)) || >> + (backup_netdev && virtnet_bypass_xmit_ready(backup_netdev))) { >> + netif_carrier_on(bypass_netdev); >> + netif_tx_wake_all_queues(bypass_netdev); >> + } else { >> + netif_carrier_off(bypass_netdev); >> + netif_tx_stop_all_queues(bypass_netdev); >> + } >> + >> + return 0; >> +} >> + >> +/* Called when child dev is injecting data into network stack. >> + * Change the associated network device from lower dev to virtio. >> + * note: already called with rcu_read_lock >> +...

...+ > + if ((primary_dev && failover_xmit_ready(primary_dev)) || > + (standby_dev && failover_xmit_ready(standby_dev))) { > + netif_carrier_on(failover_dev); > + netif_tx_wake_all_queues(failover_dev); > + } else { > + netif_carrier_off(failover_dev); > + netif_tx_stop_all_queues(failover_dev); And I think it's a good idea to get stats from device here too. > + } > + > +done: > + return NOTIFY_DONE; > +} > + > +static bool failover_validate_event_dev(struct net_device *dev) > +{ > + /* Skip parent events */ > + if (netif_is_failover(de...