search for: netif_tx_disable

...to post patch directly. >> >>> If I am to do more >>> investigation, what areas should I look into? >> As you've figured out, you can start with why netif_tx_wake_all_queues() >> were not executed? >> >> (Btw, does the issue disappear if you move netif_tx_disable() under the >> check of netif_running() in virtnet_freeze_down()?) > The issue disappears if I move netif_tx_disable() under the check of > netif_running() in virtnet_freeze_down(). Moving netif_tx_disable() > is probably better as its logic is consistent with > netif_device_attac...

...0ef9 ("virtio_net: XDP support for adjust_head"). That was removed in commit 4941d472bf95 ("virtio-net: do not reset during XDP set"), because no longer used. Bring it back, minus the xdp specific code. Before tearing down any state, virtnet_freeze_down quiesces the device with netif_tx_disable. virtnet_reset also ensures that no other config operations can run concurrently. On successful reset, the host can observe that the flag has been cleared. There is no need for the explicit control flag introduced in the previous RFC of this patch. Changes RFC -> v1 - drop VIRTIO_NET_CTRL_...

...0ef9 ("virtio_net: XDP support for adjust_head"). That was removed in commit 4941d472bf95 ("virtio-net: do not reset during XDP set"), because no longer used. Bring it back, minus the xdp specific code. Before tearing down any state, virtnet_freeze_down quiesces the device with netif_tx_disable. virtnet_reset also ensures that no other config operations can run concurrently. On successful reset, the host can observe that the flag has been cleared. There is no need for the explicit control flag introduced in the previous RFC of this patch. Changes RFC -> v1 - drop VIRTIO_NET_CTRL_...

...DP support for adjust_head"). That was removed in > commit 4941d472bf95 ("virtio-net: do not reset during XDP set"), > because no longer used. Bring it back, minus the xdp specific code. > > Before tearing down any state, virtnet_freeze_down quiesces the > device with netif_tx_disable. virtnet_reset also ensures that no > other config operations can run concurrently. > > On successful reset, the host can observe that the flag has been > cleared. There is no need for the explicit control flag introduced > in the previous RFC of this patch. > > Changes >...

...eport this as a bug first? Nope, you're very welcome to post patch directly. > If I am to do more > investigation, what areas should I look into? As you've figured out, you can start with why netif_tx_wake_all_queues() were not executed? (Btw, does the issue disappear if you move netif_tx_disable() under the check of netif_running() in virtnet_freeze_down()?) Thanks > > Best Regards > Ake Koomsin >

...active_netdev); + if (err) + goto err_active_open; + } + + backup_netdev = rtnl_dereference(vbi->backup_netdev); + if (backup_netdev) { + err = dev_open(backup_netdev); + if (err) + goto err_backup_open; + } + + return 0; + +err_backup_open: + dev_close(active_netdev); +err_active_open: + netif_tx_disable(dev); + return err; +} + +static int virtnet_bypass_close(struct net_device *dev) +{ + struct virtnet_bypass_info *vi = netdev_priv(dev); + struct net_device *child_netdev; + + netif_tx_disable(dev); + + child_netdev = rtnl_dereference(vi->active_netdev); + if (child_netdev) + dev_close(child_n...

...o work handler is accessing the device, >> + * unless this call is made from the reset work handler itself. >> + */ >> + if (!in_reset) >> + flush_work(&vi->config_work); >> >> netif_device_detach(vi->dev); >> netif_tx_disable(vi->dev); >> @@ -1878,6 +1880,7 @@ static void virtnet_freeze_down(struct virtio_device *vdev) >> } >> >> static int init_vqs(struct virtnet_info *vi); >> +static void remove_vq_common(struct virtnet_info *vi); >> >> static int virtnet_restore_up(stru...

...o work handler is accessing the device, >> + * unless this call is made from the reset work handler itself. >> + */ >> + if (!in_reset) >> + flush_work(&vi->config_work); >> >> netif_device_detach(vi->dev); >> netif_tx_disable(vi->dev); >> @@ -1878,6 +1880,7 @@ static void virtnet_freeze_down(struct virtio_device *vdev) >> } >> >> static int init_vqs(struct virtnet_info *vi); >> +static void remove_vq_common(struct virtnet_info *vi); >> >> static int virtnet_restore_up(stru...

...> + standby_dev = rtnl_dereference(finfo->standby_dev); > + if (standby_dev) { > + err = dev_open(standby_dev); > + if (err) > + goto err_standby_open; > + } > + > + return 0; > + > +err_standby_open: > + dev_close(primary_dev); > +err_primary_open: > + netif_tx_disable(dev); > + return err; > +} > + > +static int failover_close(struct net_device *dev) > +{ > + struct failover_info *finfo = netdev_priv(dev); > + struct net_device *slave_dev; > + > + netif_tx_disable(dev); > + > + slave_dev = rtnl_dereference(finfo->primary_dev);...

...> + standby_dev = rtnl_dereference(finfo->standby_dev); > + if (standby_dev) { > + err = dev_open(standby_dev); > + if (err) > + goto err_standby_open; > + } > + > + return 0; > + > +err_standby_open: > + dev_close(primary_dev); > +err_primary_open: > + netif_tx_disable(dev); > + return err; > +} > + > +static int failover_close(struct net_device *dev) > +{ > + struct failover_info *finfo = netdev_priv(dev); > + struct net_device *slave_dev; > + > + netif_tx_disable(dev); > + > + slave_dev = rtnl_dereference(finfo->primary_dev);...

...} >+ >+ backup_netdev = rtnl_dereference(bi->backup_netdev); >+ if (backup_netdev) { >+ err = dev_open(backup_netdev); >+ if (err) >+ goto err_backup_open; >+ } >+ >+ return 0; >+ >+err_backup_open: >+ dev_close(active_netdev); >+err_active_open: >+ netif_tx_disable(dev); >+ return err; >+} >+EXPORT_SYMBOL_GPL(bypass_open); >+ >+int bypass_close(struct net_device *dev) >+{ >+ struct bypass_info *vi = netdev_priv(dev); This should be probably "bi" >+ struct net_device *slave_netdev; >+ >+ netif_tx_disable(dev); >+ &...

...} >+ >+ backup_netdev = rtnl_dereference(bi->backup_netdev); >+ if (backup_netdev) { >+ err = dev_open(backup_netdev); >+ if (err) >+ goto err_backup_open; >+ } >+ >+ return 0; >+ >+err_backup_open: >+ dev_close(active_netdev); >+err_active_open: >+ netif_tx_disable(dev); >+ return err; >+} >+EXPORT_SYMBOL_GPL(bypass_open); >+ >+int bypass_close(struct net_device *dev) >+{ >+ struct bypass_info *vi = netdev_priv(dev); This should be probably "bi" >+ struct net_device *slave_netdev; >+ >+ netif_tx_disable(dev); >+ &...

...(active_netdev); + if (err) + goto err_active_open; + } + + backup_netdev = rtnl_dereference(bi->backup_netdev); + if (backup_netdev) { + err = dev_open(backup_netdev); + if (err) + goto err_backup_open; + } + + return 0; + +err_backup_open: + dev_close(active_netdev); +err_active_open: + netif_tx_disable(dev); + return err; +} +EXPORT_SYMBOL_GPL(bypass_open); + +int bypass_close(struct net_device *dev) +{ + struct bypass_info *vi = netdev_priv(dev); + struct net_device *slave_netdev; + + netif_tx_disable(dev); + + slave_netdev = rtnl_dereference(vi->active_netdev); + if (slave_netdev) + dev_clo...

..._open(primary_dev); + if (err) + goto err_primary_open; + } + + standby_dev = rtnl_dereference(finfo->standby_dev); + if (standby_dev) { + err = dev_open(standby_dev); + if (err) + goto err_standby_open; + } + + return 0; + +err_standby_open: + dev_close(primary_dev); +err_primary_open: + netif_tx_disable(dev); + return err; +} + +static int failover_close(struct net_device *dev) +{ + struct failover_info *finfo = netdev_priv(dev); + struct net_device *slave_dev; + + netif_tx_disable(dev); + + slave_dev = rtnl_dereference(finfo->primary_dev); + if (slave_dev) + dev_close(slave_dev); + + slave_de...

...open; + } + + if ((primary_dev && net_failover_xmit_ready(primary_dev)) || + (standby_dev && net_failover_xmit_ready(standby_dev))) { + netif_carrier_on(dev); + netif_tx_wake_all_queues(dev); + } + + return 0; + +err_standby_open: + dev_close(primary_dev); +err_primary_open: + netif_tx_disable(dev); + return err; +} + +static int net_failover_close(struct net_device *dev) +{ + struct net_failover_info *nfo_info = netdev_priv(dev); + struct net_device *slave_dev; + + netif_tx_disable(dev); + + slave_dev = rtnl_dereference(nfo_info->primary_dev); + if (slave_dev) + dev_close(slave_dev)...

...standby_dev); >> + if (standby_dev) { >> + err = dev_open(standby_dev); >> + if (err) >> + goto err_standby_open; >> + } >> + >> + return 0; >> + >> +err_standby_open: >> + dev_close(primary_dev); >> +err_primary_open: >> + netif_tx_disable(dev); >> + return err; >> +} >> + >> +static int failover_close(struct net_device *dev) >> +{ >> + struct failover_info *finfo = netdev_priv(dev); >> + struct net_device *slave_dev; >> + >> + netif_tx_disable(dev); >> + >> + slave_de...

...p_netdev); >> + if (backup_netdev) { >> + err = dev_open(backup_netdev); >> + if (err) >> + goto err_backup_open; >> + } >> + >> + return 0; >> + >> +err_backup_open: >> + dev_close(active_netdev); >> +err_active_open: >> + netif_tx_disable(dev); >> + return err; >> +} >> +EXPORT_SYMBOL_GPL(bypass_open); >> + >> +int bypass_close(struct net_device *dev) >> +{ >> + struct bypass_info *vi = netdev_priv(dev); > This should be probably "bi" Yes. > > >> + struct net_devi...

...open; + } + + if ((primary_dev && net_failover_xmit_ready(primary_dev)) || + (standby_dev && net_failover_xmit_ready(standby_dev))) { + netif_carrier_on(dev); + netif_tx_wake_all_queues(dev); + } + + return 0; + +err_standby_open: + dev_close(primary_dev); +err_primary_open: + netif_tx_disable(dev); + return err; +} + +static int net_failover_close(struct net_device *dev) +{ + struct net_failover_info *nfo_info = netdev_priv(dev); + struct net_device *slave_dev; + + netif_tx_disable(dev); + + slave_dev = rtnl_dereference(nfo_info->primary_dev); + if (slave_dev) + dev_close(slave_dev)...

The main motivation for this patch is to enable cloud service providers to provide an accelerated datapath to virtio-net enabled VMs in a transparent manner with no/minimal guest userspace changes. This also enables hypervisor controlled live migration to be supported with VMs that have direct attached SR-IOV VF devices. Patch 1 introduces a new feature bit VIRTIO_NET_F_BACKUP that can be used

...); >+ if (backup_netdev) { >+ err = dev_open(backup_netdev); >+ if (err) >+ goto err_backup_open; >+ } This should be moved to bypass module. See "***" below. >+ >+ return 0; >+ >+err_backup_open: >+ dev_close(active_netdev); >+err_active_open: >+ netif_tx_disable(dev); >+ return err; >+} >+ >+static int virtnet_bypass_close(struct net_device *dev) >+{ >+ struct virtnet_bypass_info *vi = netdev_priv(dev); >+ struct net_device *child_netdev; >+ >+ netif_tx_disable(dev); >+ >+ child_netdev = rtnl_dereference(vi->active_netde...