search for: netif_notify_p

After Quick Migration, the network is not immediately operational in the current context when receiving RNDIS_STATUS_MEDIA_CONNECT event. So, I put the netif_notify_peers() into a scheduled work, otherwise GARP packet will not be sent after quick migration, and cause network disconnection. Thanks to Mike Surcouf <mike at surcouf.co.uk> for reporting the bug and testing the patch. This patch should also be backported to stable kernel 2.6.32 and later. Si...

After Quick Migration, the network is not immediately operational in the current context when receiving RNDIS_STATUS_MEDIA_CONNECT event. So, I put the netif_notify_peers() into a scheduled work, otherwise GARP packet will not be sent after quick migration, and cause network disconnection. Thanks to Mike Surcouf <mike at surcouf.co.uk> for reporting the bug and testing the patch. This patch should also be backported to stable kernel 2.6.32 and later. Si...

...ous packets when needed. This patch implements VIRTIO_NET_F_GUEST_ANNOUNCE feature: hypervisor would notice the guest when it thinks it's time for guest to announce the link presnece. Guest tests VIRTIO_NET_S_ANNOUNCE bit during config change interrupt and woule send gratuitous packets through netif_notify_peers() and ack the notification through ctrl vq. We need to make sure the atomicy of read and ack in guest otherwise we may ack more times than being notified. This is done through handling the whole config change interrupt in an non-reentrant workqueue. Signed-off-by: Jason Wang <jasowang at r...

...ous packets when needed. This patch implements VIRTIO_NET_F_GUEST_ANNOUNCE feature: hypervisor would notice the guest when it thinks it's time for guest to announce the link presnece. Guest tests VIRTIO_NET_S_ANNOUNCE bit during config change interrupt and woule send gratuitous packets through netif_notify_peers() and ack the notification through ctrl vq. We need to make sure the atomicy of read and ack in guest otherwise we may ack more times than being notified. This is done through handling the whole config change interrupt in an non-reentrant workqueue. Signed-off-by: Jason Wang <jasowang at r...

The hv_netvsc gets RNDIS_STATUS_MEDIA_CONNECT event after the VM is live migrated. Adding call to netif_notify_peers() for this event to send GARP (Gratuitous ARP) to notify network peers. Otherwise, the VM's network connection may stop after a live migration. This patch should also be applied to stable kernel 2.6.32 and later. Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com> Signed-off-by...

The hv_netvsc gets RNDIS_STATUS_MEDIA_CONNECT event after the VM is live migrated. Adding call to netif_notify_peers() for this event to send GARP (Gratuitous ARP) to notify network peers. Otherwise, the VM's network connection may stop after a live migration. This patch should also be applied to stable kernel 2.6.32 and later. Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com> Signed-off-by...

...*pages; @@ -512,6 +515,13 @@ static void refill_work(struct work_struct *work) queue_delayed_work(system_nrt_wq, &vi->refill, HZ/2); } +static void announce_work(struct work_struct *work) +{ + struct virtnet_info *vi = container_of(work, struct virtnet_info, + announce); + netif_notify_peers(vi->dev); +} + static int virtnet_poll(struct napi_struct *napi, int budget) { struct virtnet_info *vi = container_of(napi, struct virtnet_info, napi); @@ -787,6 +797,8 @@ static int virtnet_close(struct net_device *dev) /* Make sure refill_work doesn't re-enable napi! */ cance...

...*pages; @@ -512,6 +515,13 @@ static void refill_work(struct work_struct *work) queue_delayed_work(system_nrt_wq, &vi->refill, HZ/2); } +static void announce_work(struct work_struct *work) +{ + struct virtnet_info *vi = container_of(work, struct virtnet_info, + announce); + netif_notify_peers(vi->dev); +} + static int virtnet_poll(struct napi_struct *napi, int budget) { struct virtnet_info *vi = container_of(napi, struct virtnet_info, napi); @@ -787,6 +797,8 @@ static int virtnet_close(struct net_device *dev) /* Make sure refill_work doesn't re-enable napi! */ cance...

...+ VIRTIO_NET_CTRL_ANNOUNCE_ACK, NULL, + 0, 0)) { + dev_warn(&vi->dev->dev, "Failed to ack link nnounce.\n"); + } +} + +static void announce_work(struct work_struct *work) +{ + struct virtnet_info *vi = container_of(work, struct virtnet_info, + announce); + netif_notify_peers(vi->dev); + virtnet_ack_link_announce(vi); +} + static int virtnet_close(struct net_device *dev) { struct virtnet_info *vi = netdev_priv(dev); /* Make sure refill_work doesn't re-enable napi! */ cancel_delayed_work_sync(&vi->refill); + cancel_work_sync(&vi->announ...

...+ VIRTIO_NET_CTRL_ANNOUNCE_ACK, NULL, + 0, 0)) { + dev_warn(&vi->dev->dev, "Failed to ack link nnounce.\n"); + } +} + +static void announce_work(struct work_struct *work) +{ + struct virtnet_info *vi = container_of(work, struct virtnet_info, + announce); + netif_notify_peers(vi->dev); + virtnet_ack_link_announce(vi); +} + static int virtnet_close(struct net_device *dev) { struct virtnet_info *vi = netdev_priv(dev); /* Make sure refill_work doesn't re-enable napi! */ cancel_delayed_work_sync(&vi->refill); + cancel_work_sync(&vi->announ...

...*pages; @@ -512,6 +515,13 @@ static void refill_work(struct work_struct *work) queue_delayed_work(system_nrt_wq, &vi->refill, HZ/2); } +static void announce_work(struct work_struct *work) +{ + struct virtnet_info *vi = container_of(work, struct virtnet_info, + announce); + netif_notify_peers(vi->dev); +} + static int virtnet_poll(struct napi_struct *napi, int budget) { struct virtnet_info *vi = container_of(napi, struct virtnet_info, napi); @@ -787,6 +797,7 @@ static int virtnet_close(struct net_device *dev) /* Make sure refill_work doesn't re-enable napi! */ cance...

...*pages; @@ -512,6 +515,13 @@ static void refill_work(struct work_struct *work) queue_delayed_work(system_nrt_wq, &vi->refill, HZ/2); } +static void announce_work(struct work_struct *work) +{ + struct virtnet_info *vi = container_of(work, struct virtnet_info, + announce); + netif_notify_peers(vi->dev); +} + static int virtnet_poll(struct napi_struct *napi, int budget) { struct virtnet_info *vi = container_of(napi, struct virtnet_info, napi); @@ -787,6 +797,7 @@ static int virtnet_close(struct net_device *dev) /* Make sure refill_work doesn't re-enable napi! */ cance...

Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com> Signed-off-by: Abhishek Kane <v-abkane at microsoft.com> Signed-off-by: Hank Janssen <hjanssen at microsoft.com> Signed-off-by: K. Y. Srinivasan <kys at microsoft.com> --- drivers/staging/hv/netvsc.c | 8 ++++---- drivers/staging/hv/netvsc_drv.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff

Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com> Signed-off-by: Abhishek Kane <v-abkane at microsoft.com> Signed-off-by: Hank Janssen <hjanssen at microsoft.com> Signed-off-by: K. Y. Srinivasan <kys at microsoft.com> --- drivers/staging/hv/netvsc.c | 8 ++++---- drivers/staging/hv/netvsc_drv.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff

Fixed a set of bugs in netvsc module, and cleaned up some coding style issues. Haiyang Zhang (10): staging: hv: remove unnecessary includes in netvsc staging: hv: add newline to log messages in netvsc staging: hv: convert dev_<loglevel> to netdev_<loglevel> in netvsc staging: hv: fix a kernel warning in netvsc_linkstatus_callback() staging: hv: re-order the code in

Fixed a set of bugs in netvsc module, and cleaned up some coding style issues. Haiyang Zhang (10): staging: hv: remove unnecessary includes in netvsc staging: hv: add newline to log messages in netvsc staging: hv: convert dev_<loglevel> to netdev_<loglevel> in netvsc staging: hv: fix a kernel warning in netvsc_linkstatus_callback() staging: hv: re-order the code in

Fixed a set of bugs in netvsc module, and cleaned up some coding style issues. Haiyang Zhang (9): staging: hv: remove unnecessary includes in netvsc staging: hv: add newline to log messages in netvsc staging: hv: convert dev_<loglevel> to netdev_<loglevel> in netvsc staging: hv: fix a kernel warning in netvsc_linkstatus_callback() staging: hv: re-order the code in

Fixed a set of bugs in netvsc module, and cleaned up some coding style issues. Haiyang Zhang (9): staging: hv: remove unnecessary includes in netvsc staging: hv: add newline to log messages in netvsc staging: hv: convert dev_<loglevel> to netdev_<loglevel> in netvsc staging: hv: fix a kernel warning in netvsc_linkstatus_callback() staging: hv: re-order the code in

...usStateConnected: case XenbusStateUnknown: case XenbusStateClosed: break; @@ -1657,6 +1656,9 @@ static void netback_changed(struct xenbus_device *dev, if (xennet_connect(netdev) != 0) break; xenbus_switch_state(dev, XenbusStateConnected); + break; + + case XenbusStateConnected: netif_notify_peers(netdev); break; -- 1.7.4.4

...usStateConnected: case XenbusStateUnknown: case XenbusStateClosed: break; @@ -1657,6 +1656,9 @@ static void netback_changed(struct xenbus_device *dev, if (xennet_connect(netdev) != 0) break; xenbus_switch_state(dev, XenbusStateConnected); + break; + + case XenbusStateConnected: netif_notify_peers(netdev); break; -- 1.7.4.4