Displaying 7 results from an estimated 7 matches for "netif_f_ufo_bit".
Did you mean:
netif_f_ufo6_bit
2014 Nov 21
1
[PATCH v2 net 1/2] drivers/net: Disable UFO through virtio
...irst time we do
> > this.
> >
> > Signed-off-by: Ben Hutchings <ben at decadent.org.uk>
> > Fixes: 916e4cf46d02 ("ipv6: reuse ip6_frag_id from ip6_ufo_append_data")
>
>
> There's something I don't understand here. I see:
>
> NETIF_F_UFO_BIT, /* ... UDPv4 fragmentation */
>
> this comment is wrong then?
Yes.
> The patches drastically regress performance for UDPv4 for VMs only, but
> isn't it likely many other devices based their code on this comment?
There's only one hardware driver that implement...
2014 Nov 21
1
[PATCH v2 net 1/2] drivers/net: Disable UFO through virtio
...irst time we do
> > this.
> >
> > Signed-off-by: Ben Hutchings <ben at decadent.org.uk>
> > Fixes: 916e4cf46d02 ("ipv6: reuse ip6_frag_id from ip6_ufo_append_data")
>
>
> There's something I don't understand here. I see:
>
> NETIF_F_UFO_BIT, /* ... UDPv4 fragmentation */
>
> this comment is wrong then?
Yes.
> The patches drastically regress performance for UDPv4 for VMs only, but
> isn't it likely many other devices based their code on this comment?
There's only one hardware driver that implement...
2014 Oct 30
3
[PATCH v2 net 1/2] drivers/net: Disable UFO through virtio
IPv6 does not allow fragmentation by routers, so there is no
fragmentation ID in the fixed header. UFO for IPv6 requires the ID to
be passed separately, but there is no provision for this in the virtio
net protocol.
Until recently our software implementation of UFO/IPv6 generated a new
ID, but this was a bug. Now we will use ID=0 for any UFO/IPv6 packet
passed through a tap, which is even
2014 Oct 30
3
[PATCH v2 net 1/2] drivers/net: Disable UFO through virtio
IPv6 does not allow fragmentation by routers, so there is no
fragmentation ID in the fixed header. UFO for IPv6 requires the ID to
be passed separately, but there is no provision for this in the virtio
net protocol.
Until recently our software implementation of UFO/IPv6 generated a new
ID, but this was a bug. Now we will use ID=0 for any UFO/IPv6 packet
passed through a tap, which is even
2014 Nov 19
0
[PATCH v2 net 1/2] drivers/net: Disable UFO through virtio
...accepting UFO packets but log a warning the first time we do
> this.
>
> Signed-off-by: Ben Hutchings <ben at decadent.org.uk>
> Fixes: 916e4cf46d02 ("ipv6: reuse ip6_frag_id from ip6_ufo_append_data")
There's something I don't understand here. I see:
NETIF_F_UFO_BIT, /* ... UDPv4 fragmentation */
this comment is wrong then?
The patches drastically regress performance for UDPv4 for VMs only, but
isn't it likely many other devices based their code on this comment?
How about we disable UFO for IPv6 globally, and put the
flag back in?
We can...
2014 Oct 30
5
[PATCH v2 net 0/2] drivers/net,ipv6: Fix IPv6 fragment ID selection for virtio
The virtio net protocol supports UFO but does not provide for passing a
fragment ID for fragmentation of IPv6 packets. We used to generate a
fragment ID wherever such a packet was fragmented, but currently we
always use ID=0!
v2: Add blank lines after declarations
Ben.
Ben Hutchings (2):
drivers/net: Disable UFO through virtio
drivers/net,ipv6: Select IPv6 fragment idents for virtio UFO
2014 Oct 30
5
[PATCH v2 net 0/2] drivers/net,ipv6: Fix IPv6 fragment ID selection for virtio
The virtio net protocol supports UFO but does not provide for passing a
fragment ID for fragmentation of IPv6 packets. We used to generate a
fragment ID wherever such a packet was fragmented, but currently we
always use ID=0!
v2: Add blank lines after declarations
Ben.
Ben Hutchings (2):
drivers/net: Disable UFO through virtio
drivers/net,ipv6: Select IPv6 fragment idents for virtio UFO