search for: netif_f_

...g compatibility > with hypervisors forever. > I'm ok with failing the probe. But it won't cost big effort to workaround only features dependencies issue. I don't see how this block any further features implementation. Looking at virtio-net, it also depends on network core to fix NETIF_F_* dependencies. There seems no way to get rid of maintaining compatibility, e.g the workarounds for the buggy hypervisor without VIRTIO_F_ANY_LAYOUT support.

...g compatibility > with hypervisors forever. > I'm ok with failing the probe. But it won't cost big effort to workaround only features dependencies issue. I don't see how this block any further features implementation. Looking at virtio-net, it also depends on network core to fix NETIF_F_* dependencies. There seems no way to get rid of maintaining compatibility, e.g the workarounds for the buggy hypervisor without VIRTIO_F_ANY_LAYOUT support.

...Rusty Russell <rusty at rustcorp.com.au> Cc: Cornelia Huck <cornelia.huck at de.ibm.com> Cc: Wanlong Gao <gaowanlong at cn.fujitsu.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- Changes from V1: - Drop NETIF_F_*_UFO from checklist Changes from V2: - only check the features for ctrl vq (this fix the real bug) - better error message and simplify API Changes from V3: - pass dbit directly and even better error message - typo fix --- drivers/net/virtio_net.c | 37 +++++++++++++++++++++++++++++++++++++ 1 file...

...Rusty Russell <rusty at rustcorp.com.au> Cc: Cornelia Huck <cornelia.huck at de.ibm.com> Cc: Wanlong Gao <gaowanlong at cn.fujitsu.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- Changes from V1: - Drop NETIF_F_*_UFO from checklist Changes from V2: - only check the features for ctrl vq (this fix the real bug) - better error message and simplify API Changes from V3: - pass dbit directly and even better error message - typo fix --- drivers/net/virtio_net.c | 37 +++++++++++++++++++++++++++++++++++++ 1 file...

...Rusty Russell <rusty at rustcorp.com.au> Cc: Cornelia Huck <cornelia.huck at de.ibm.com> Cc: Wanlong Gao <gaowanlong at cn.fujitsu.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- Changes from V1: - Drop NETIF_F_*_UFO from checklist Changes from V2: - only check the features for ctrl vq (this fix the real bug) - better error message and simplify API Changes from V3: - pass dbit directly and even better error message - typo fix Changes from v4: - add "device" before "advertise" --- drive...

...Rusty Russell <rusty at rustcorp.com.au> Cc: Cornelia Huck <cornelia.huck at de.ibm.com> Cc: Wanlong Gao <gaowanlong at cn.fujitsu.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- Changes from V1: - Drop NETIF_F_*_UFO from checklist Changes from V2: - only check the features for ctrl vq (this fix the real bug) - better error message and simplify API Changes from V3: - pass dbit directly and even better error message - typo fix Changes from v4: - add "device" before "advertise" --- drive...

...gt; But it won't cost big effort to workaround only features dependencies > issue. >From experience, second-guessing user always adds maintainance. > I don't see how this block any further features implementation. > Looking at virtio-net, it also depends on network core to fix NETIF_F_* > dependencies. That code is common for all drivers, so it was moved to core. > There seems no way to get rid of maintaining compatibility, e.g the > workarounds for the buggy hypervisor without VIRTIO_F_ANY_LAYOUT support. Right - because too many hypervisors shipped without it, it...

On Mon, 17 Nov 2014 11:37:01 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > On Mon, Nov 17, 2014 at 05:17:17PM +0800, Jason Wang wrote: > > Buggy host may advertised buggy host features (a usual case is that host > > advertise a feature whose dependencies were missed). In this case, driver > > should detect and disable the buggy features by itself.

On Mon, 17 Nov 2014 11:37:01 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > On Mon, Nov 17, 2014 at 05:17:17PM +0800, Jason Wang wrote: > > Buggy host may advertised buggy host features (a usual case is that host > > advertise a feature whose dependencies were missed). In this case, driver > > should detect and disable the buggy features by itself.