search for: netdev_notify_p

...s only ring state. Device configuration such as mac and vlan persist across the reset. > Also, it seems that LINK_ANNOUNCE requests will get ignored > even if they got set before the reset, leading to downtime. Do you mean act on VIRTIO_NET_F_GUEST_ANNOUNCE requests? That flag is tested and netdev_notify_peers called before resetting virtio ring state.

...s only ring state. Device configuration such as mac and vlan persist across the reset. > Also, it seems that LINK_ANNOUNCE requests will get ignored > even if they got set before the reset, leading to downtime. Do you mean act on VIRTIO_NET_F_GUEST_ANNOUNCE requests? That flag is tested and netdev_notify_peers called before resetting virtio ring state.

...reviously resetting in the context of xdp? >> > Also, it seems that LINK_ANNOUNCE requests will get ignored >> > even if they got set before the reset, leading to downtime. >> >> Do you mean act on VIRTIO_NET_F_GUEST_ANNOUNCE >> requests? That flag is tested and netdev_notify_peers >> called before resetting virtio ring state. > > Yes but I wonder if there's a race where announce > is set after it is read but before NEED_RESET is read. > > Re-reading status from the config before reset > might be necessary. Thanks, I'll have a look. Perhap...

...reviously resetting in the context of xdp? >> > Also, it seems that LINK_ANNOUNCE requests will get ignored >> > even if they got set before the reset, leading to downtime. >> >> Do you mean act on VIRTIO_NET_F_GUEST_ANNOUNCE >> requests? That flag is tested and netdev_notify_peers >> called before resetting virtio ring state. > > Yes but I wonder if there's a race where announce > is set after it is read but before NEED_RESET is read. > > Re-reading status from the config before reset > might be necessary. Thanks, I'll have a look. Perhap...

As hypervior does not have the knowledge of guest network configuration, it's better to ask guest to send gratuitous packets when needed. Guest tests VIRTIO_NET_S_ANNOUNCE bit during config change interrupt and when it is set, a workqueue is scheduled to send gratuitous packet through NETDEV_NOTIFY_PEERS. This feature is negotiated through bit VIRTIO_NET_F_GUEST_ANNOUNCE. Changes from v4: - typos - handle workqueue unconditionally - move VIRTIO_NET_S_ANNOUNCE to bit 8 to separate rw bits from ro bits Changes from v3: - cancel the workqueue during freeze Changes from v2: - fix the race betwee...

As hypervior does not have the knowledge of guest network configuration, it's better to ask guest to send gratuitous packets when needed. Guest tests VIRTIO_NET_S_ANNOUNCE bit during config change interrupt and when it is set, a workqueue is scheduled to send gratuitous packet through NETDEV_NOTIFY_PEERS. This feature is negotiated through bit VIRTIO_NET_F_GUEST_ANNOUNCE. Changes from v4: - typos - handle workqueue unconditionally - move VIRTIO_NET_S_ANNOUNCE to bit 8 to separate rw bits from ro bits Changes from v3: - cancel the workqueue during freeze Changes from v2: - fix the race betwee...

As hypervior does not have the knowledge of guest network configuration, it's better to ask guest to send gratuitous packets when needed. Guest tests VIRTIO_NET_S_ANNOUNCE bit during config change interrupt and when it is set, a workqueue is scheduled to send gratuitous packet through NETDEV_NOTIFY_PEERS. This feature is negotiated through bit VIRTIO_NET_F_GUEST_ANNOUNCE. Changes from v5: - notify the chain before acking the link annoucement - ack the link announcement notification through control vq Changes from v4: - typos - handle workqueue unconditionally - move VIRTIO_NET_S_ANNOUNCE to b...

As hypervior does not have the knowledge of guest network configuration, it's better to ask guest to send gratuitous packets when needed. Guest tests VIRTIO_NET_S_ANNOUNCE bit during config change interrupt and when it is set, a workqueue is scheduled to send gratuitous packet through NETDEV_NOTIFY_PEERS. This feature is negotiated through bit VIRTIO_NET_F_GUEST_ANNOUNCE. Changes from v5: - notify the chain before acking the link annoucement - ack the link announcement notification through control vq Changes from v4: - typos - handle workqueue unconditionally - move VIRTIO_NET_S_ANNOUNCE to b...

As hypervior does not have the knowledge of guest network configuration, it's better to ask guest to send gratuitous packet when needed. Guest test VIRTIO_NET_S_ANNOUNCE bit during config change interrupt and when it is set, a workqueue is scheduled to send gratuitous packet through NETDEV_NOTIFY_PEERS. This feature is negotiated through bit VIRTIO_NET_F_GUEST_ANNOUNCE. Changes from v3: - cancel the workqueue during freeze Changes from v2: - fix the race between unregister_dev() and workqueue Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/net/virtio_net.c | 31 ++...

As hypervior does not have the knowledge of guest network configuration, it's better to ask guest to send gratuitous packet when needed. Guest test VIRTIO_NET_S_ANNOUNCE bit during config change interrupt and when it is set, a workqueue is scheduled to send gratuitous packet through NETDEV_NOTIFY_PEERS. This feature is negotiated through bit VIRTIO_NET_F_GUEST_ANNOUNCE. Changes from v3: - cancel the workqueue during freeze Changes from v2: - fix the race between unregister_dev() and workqueue Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/net/virtio_net.c | 31 ++...

...o device seems to lose all state, you have to re-program it. > > Also, it seems that LINK_ANNOUNCE requests will get ignored > > even if they got set before the reset, leading to downtime. > > Do you mean act on VIRTIO_NET_F_GUEST_ANNOUNCE > requests? That flag is tested and netdev_notify_peers > called before resetting virtio ring state. Yes but I wonder if there's a race where announce is set after it is read but before NEED_RESET is read. Re-reading status from the config before reset might be necessary. -- MST

...rivers/net/virtio_net.c @@ -1403,7 +1403,7 @@ static void virtnet_config_changed_work(struct work_struct *work) if (virtio_cread_feature(vi->vdev, VIRTIO_NET_F_STATUS, struct virtio_net_config, status, &v) < 0) - goto done; + return; if (v & VIRTIO_NET_S_ANNOUNCE) { netdev_notify_peers(vi->dev); @@ -1414,7 +1414,7 @@ static void virtnet_config_changed_work(struct work_struct *work) v &= VIRTIO_NET_S_LINK_UP; if (vi->status == v) - goto done; + return; vi->status = v; @@ -1425,8 +1425,6 @@ static void virtnet_config_changed_work(struct work_struct *w...

...n back then, too. > >> > Also, it seems that LINK_ANNOUNCE requests will get ignored > >> > even if they got set before the reset, leading to downtime. > >> > >> Do you mean act on VIRTIO_NET_F_GUEST_ANNOUNCE > >> requests? That flag is tested and netdev_notify_peers > >> called before resetting virtio ring state. > > > > Yes but I wonder if there's a race where announce > > is set after it is read but before NEED_RESET is read. > > > > Re-reading status from the config before reset > > might be necessary. &g...

...t virtnet_set_guest_offloads(struct virtnet_info *vi, u64 offloads) >> { >> struct scatterlist sg; >> @@ -2085,7 +2127,16 @@ static void virtnet_config_changed_work(struct work_struct *work) >> >> if (v & VIRTIO_NET_S_ANNOUNCE) { >> netdev_notify_peers(vi->dev); >> - virtnet_ack_link_announce(vi); >> + virtnet_ack(vi, VIRTIO_NET_CTRL_ANNOUNCE, >> + VIRTIO_NET_CTRL_ANNOUNCE_ACK); >> + } >> + >> + if (vi->vdev->config->get_status(vi->vdev)...

...t virtnet_set_guest_offloads(struct virtnet_info *vi, u64 offloads) >> { >> struct scatterlist sg; >> @@ -2085,7 +2127,16 @@ static void virtnet_config_changed_work(struct work_struct *work) >> >> if (v & VIRTIO_NET_S_ANNOUNCE) { >> netdev_notify_peers(vi->dev); >> - virtnet_ack_link_announce(vi); >> + virtnet_ack(vi, VIRTIO_NET_CTRL_ANNOUNCE, >> + VIRTIO_NET_CTRL_ANNOUNCE_ACK); >> + } >> + >> + if (vi->vdev->config->get_status(vi->vdev)...

From: Willem de Bruijn <willemb at google.com> Implement the reset communication request defined in the VIRTIO 1.0 specification and introduces in Linux in commit c00bbcf862896 ("virtio: add VIRTIO_CONFIG_S_NEEDS_RESET device status bit"). Use the virtnet_reset function introduced in commit 2de2f7f40ef9 ("virtio_net: XDP support for adjust_head"). That was removed in

From: Willem de Bruijn <willemb at google.com> Implement the reset communication request defined in the VIRTIO 1.0 specification and introduces in Linux in commit c00bbcf862896 ("virtio: add VIRTIO_CONFIG_S_NEEDS_RESET device status bit"). Use the virtnet_reset function introduced in commit 2de2f7f40ef9 ("virtio_net: XDP support for adjust_head"). That was removed in

On Thu, Jun 12, 2014 at 05:08:37PM +0530, abhishek jain wrote: > Hi Rich > > I have all the virtio modules available in the kernel but I'm getting the > same result . It doesn't appear to be using any kernel modules. I would have expected to see output such as this: supermin: internal insmod virtio.ko It seems as if you might not be setting SUPERMIN_MODULES; or maybe you

...gt;> >> > Also, it seems that LINK_ANNOUNCE requests will get ignored >> >> > even if they got set before the reset, leading to downtime. >> >> >> >> Do you mean act on VIRTIO_NET_F_GUEST_ANNOUNCE >> >> requests? That flag is tested and netdev_notify_peers >> >> called before resetting virtio ring state. >> > >> > Yes but I wonder if there's a race where announce >> > is set after it is read but before NEED_RESET is read. >> > >> > Re-reading status from the config before reset >>...

...gt;> >> > Also, it seems that LINK_ANNOUNCE requests will get ignored >> >> > even if they got set before the reset, leading to downtime. >> >> >> >> Do you mean act on VIRTIO_NET_F_GUEST_ANNOUNCE >> >> requests? That flag is tested and netdev_notify_peers >> >> called before resetting virtio ring state. >> > >> > Yes but I wonder if there's a race where announce >> > is set after it is read but before NEED_RESET is read. >> > >> > Re-reading status from the config before reset >>...