search for: netdev_err

Fixed a set of bugs in netvsc module, and cleaned up some coding style issues. Haiyang Zhang (10): staging: hv: remove unnecessary includes in netvsc staging: hv: add newline to log messages in netvsc staging: hv: convert dev_<loglevel> to netdev_<loglevel> in netvsc staging: hv: fix a kernel warning in netvsc_linkstatus_callback() staging: hv: re-order the code in

Fixed a set of bugs in netvsc module, and cleaned up some coding style issues. Haiyang Zhang (10): staging: hv: remove unnecessary includes in netvsc staging: hv: add newline to log messages in netvsc staging: hv: convert dev_<loglevel> to netdev_<loglevel> in netvsc staging: hv: fix a kernel warning in netvsc_linkstatus_callback() staging: hv: re-order the code in

Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com> Signed-off-by: Abhishek Kane <v-abkane at microsoft.com> Signed-off-by: Hank Janssen <hjanssen at microsoft.com> Signed-off-by: K. Y. Srinivasan <kys at microsoft.com> --- drivers/staging/hv/netvsc.c | 8 ++++---- drivers/staging/hv/netvsc_drv.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff

Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com> Signed-off-by: Abhishek Kane <v-abkane at microsoft.com> Signed-off-by: Hank Janssen <hjanssen at microsoft.com> Signed-off-by: K. Y. Srinivasan <kys at microsoft.com> --- drivers/staging/hv/netvsc.c | 8 ++++---- drivers/staging/hv/netvsc_drv.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff

Fixed a set of bugs in netvsc module, and cleaned up some coding style issues. Haiyang Zhang (9): staging: hv: remove unnecessary includes in netvsc staging: hv: add newline to log messages in netvsc staging: hv: convert dev_<loglevel> to netdev_<loglevel> in netvsc staging: hv: fix a kernel warning in netvsc_linkstatus_callback() staging: hv: re-order the code in

Fixed a set of bugs in netvsc module, and cleaned up some coding style issues. Haiyang Zhang (9): staging: hv: remove unnecessary includes in netvsc staging: hv: add newline to log messages in netvsc staging: hv: convert dev_<loglevel> to netdev_<loglevel> in netvsc staging: hv: fix a kernel warning in netvsc_linkstatus_callback() staging: hv: re-order the code in

...ously is was possible to loop over this insane number, getting an error each time and therefore not generating any more pending requests and therefore not exiting the loop in xen_netbk_tx_build_gops for an externded period. Also turn various netdev_dbg calls which no precipitate a fatal error into netdev_err, they are rate limited because the device is shutdown afterwards. This fixes at least one known DoS/softlockup of the backend domain. Signed-off-by: Ian Campbell <ian.campbell@citrix.com> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Acked-by: Jan Beulich <JBeulich@su...

...r 28, 2018 at 11:06:01AM CEST, jiri at resnulli.us wrote: >Fri, Apr 27, 2018 at 07:06:58PM CEST, sridhar.samudrala at intel.com wrote: [...] >>+ >>+ err = netdev_rx_handler_register(slave_dev, net_failover_handle_frame, >>+ failover_dev); >>+ if (err) { >>+ netdev_err(slave_dev, "can not register failover rx handler (err = %d)\n", >>+ err); >>+ goto err_handler_register; >>+ } >>+ >>+ err = netdev_upper_dev_link(slave_dev, failover_dev, NULL); > >Please use netdev_master_upper_dev_link(). Don't forget to f...

...r 28, 2018 at 11:06:01AM CEST, jiri at resnulli.us wrote: >Fri, Apr 27, 2018 at 07:06:58PM CEST, sridhar.samudrala at intel.com wrote: [...] >>+ >>+ err = netdev_rx_handler_register(slave_dev, net_failover_handle_frame, >>+ failover_dev); >>+ if (err) { >>+ netdev_err(slave_dev, "can not register failover rx handler (err = %d)\n", >>+ err); >>+ goto err_handler_register; >>+ } >>+ >>+ err = netdev_upper_dev_link(slave_dev, failover_dev, NULL); > >Please use netdev_master_upper_dev_link(). Don't forget to f...

We''ve been hitting the following issue on a variety of hosts and recent Xen/dom0 version combinations. Here''s an excerpt from our latest: Xen: 4.1.4 (xenbits @ 23432) Dom0: 3.7.1-x86_64 BUG: unable to handle kernel NULL pointer dereference at 000000000000001c IP: [<ffffffff8141a301>] evtchn_from_irq+0x11/0x40 PGD 0 Oops: 0000 [#1] SMP Modules linked in: ebt_comment

...r; + + nfo_info = netdev_priv(failover_dev); + standby_dev = rtnl_dereference(nfo_info->standby_dev); + primary_dev = rtnl_dereference(nfo_info->primary_dev); + slave_is_standby = slave_dev->dev.parent == failover_dev->dev.parent; + if (slave_is_standby ? standby_dev : primary_dev) { + netdev_err(failover_dev, "%s attempting to register as slave dev when %s already present\n", + slave_dev->name, + slave_is_standby ? "standby" : "primary"); + goto done; + } + + /* We want to allow only a direct attached VF device as a primary + * netdev. As there...

...d) >+ goto done; >+ >+ ret = bypass->ops->register_child(bypass_netdev, child_netdev); >+ if (ret != 0) >+ goto done; >+ >+ ret = netdev_rx_handler_register(child_netdev, >+ bypass->ops->handle_frame, >+ bypass_netdev); >+ if (ret != 0) { >+ netdev_err(child_netdev, >+ "can not register bypass rx handler (err = %d)\n", >+ ret); >+ goto rx_handler_failed; >+ } >+ >+ ret = netdev_upper_dev_link(child_netdev, bypass_netdev, NULL); >+ if (ret != 0) { >+ netdev_err(child_netdev, No line-wrap is needed her...

...gt; > > + >> > > > + ret = netdev_rx_handler_register(slave_netdev, >> > > > + bypass_ops ? bypass_ops->handle_frame : >> > > > + bypass_handle_frame, bypass_netdev); >> > > > + if (ret != 0) { >> > > > + netdev_err(slave_netdev, "can not register bypass rx handler (err = %d)\n", >> > > > + ret); >> > > > + goto done; >> > > > + } >> > > > + >> > > > + ret = netdev_upper_dev_link(slave_netdev, bypass_netdev, NULL); >&...

...gt; > > + >> > > > + ret = netdev_rx_handler_register(slave_netdev, >> > > > + bypass_ops ? bypass_ops->handle_frame : >> > > > + bypass_handle_frame, bypass_netdev); >> > > > + if (ret != 0) { >> > > > + netdev_err(slave_netdev, "can not register bypass rx handler (err = %d)\n", >> > > > + ret); >> > > > + goto done; >> > > > + } >> > > > + >> > > > + ret = netdev_upper_dev_link(slave_netdev, bypass_netdev, NULL); >&...

...ev->tx_queue_len = new_len; > + int res, orig_len = dev->tx_queue_len; > + > + if (new_len != orig_len) { > + dev->tx_queue_len = new_len; > + res = call_netdevice_notifiers(NETDEV_CHANGE_TX_QUEUE_LEN, dev); > + res = notifier_to_errno(res); > + if (res) { > + netdev_err(dev, > + "refused to change device tx_queue_len\n"); > + dev->tx_queue_len = orig_len; > + return -EFAULT; > + } > + } > + > return 0; > } > > Acked-by: John Fastabend <john.r.fastabend at intel.com> Great timing I was just looking...

...ev->tx_queue_len = new_len; > + int res, orig_len = dev->tx_queue_len; > + > + if (new_len != orig_len) { > + dev->tx_queue_len = new_len; > + res = call_netdevice_notifiers(NETDEV_CHANGE_TX_QUEUE_LEN, dev); > + res = notifier_to_errno(res); > + if (res) { > + netdev_err(dev, > + "refused to change device tx_queue_len\n"); > + dev->tx_queue_len = orig_len; > + return -EFAULT; > + } > + } > + > return 0; > } > > Acked-by: John Fastabend <john.r.fastabend at intel.com> Great timing I was just looking...

...); + + if (!bypass->ops->register_child) + goto done; + + ret = bypass->ops->register_child(bypass_netdev, child_netdev); + if (ret != 0) + goto done; + + ret = netdev_rx_handler_register(child_netdev, + bypass->ops->handle_frame, + bypass_netdev); + if (ret != 0) { + netdev_err(child_netdev, + "can not register bypass rx handler (err = %d)\n", + ret); + goto rx_handler_failed; + } + + ret = netdev_upper_dev_link(child_netdev, bypass_netdev, NULL); + if (ret != 0) { + netdev_err(child_netdev, + "can not set master device %s (err = %d)\n&quot...

...+ + child_netdev = rcu_dereference(vbi->active_netdev); + if (child_netdev) { + ret = dev_set_mtu(child_netdev, new_mtu); + if (ret) + return ret; + } + + child_netdev = rcu_dereference(vbi->backup_netdev); + if (child_netdev) { + ret = dev_set_mtu(child_netdev, new_mtu); + if (ret) + netdev_err(child_netdev, + "Unexpected failure to set mtu to %d\n", + new_mtu); + } + + dev->mtu = new_mtu; + return 0; +} + +static const struct net_device_ops virtnet_bypass_netdev_ops = { + .ndo_open = virtnet_bypass_open, + .ndo_stop = virtnet_bypass_close, + .ndo_start_xmit =...

On Mon, 7 May 2018 15:10:44 -0700 Sridhar Samudrala <sridhar.samudrala at intel.com> wrote: > + if (netif_running(failover_dev)) { > + err = dev_open(slave_dev); > + if (err && (err != -EBUSY)) { > + netdev_err(failover_dev, "Opening slave %s failed err:%d\n", > + slave_dev->name, err); > + goto err_dev_open; > + } > + } > + > + netif_addr_lock_bh(failover_dev); > + dev_uc_sync_multiple(slave_dev, failover_dev); > + dev_uc_sync_multiple(slave_dev, failover_dev...

...t;tx_ring.size - * sizeof(struct Vmxnet3_TxDesc), - &tq->tx_ring.basePA); + tq->tx_ring.base = dma_alloc_coherent(&adapter->pdev->dev, + tq->tx_ring.size * sizeof(struct Vmxnet3_TxDesc), + &tq->tx_ring.basePA, GFP_KERNEL); if (!tq->tx_ring.base) { netdev_err(adapter->netdev, "failed to allocate tx ring\n"); goto err; } - tq->data_ring.base = pci_alloc_consistent(adapter->pdev, - tq->data_ring.size * - sizeof(struct Vmxnet3_TxDataDesc), - &tq->data_ring.basePA); + tq->data_ring.base = dma_alloc...