search for: net_failover_slave_regist

On Mon, 7 May 2018 15:10:44 -0700 Sridhar Samudrala <sridhar.samudrala at intel.com> wrote: > +static struct net_device *net_failover_get_bymac(u8 *mac, > + struct net_failover_ops **ops) > +{ > + struct net_device *failover_dev; > + struct net_failover *failover; > + > + spin_lock(&net_failover_lock); > + list_for_each_entry(failover,

On Mon, 7 May 2018 15:10:44 -0700 Sridhar Samudrala <sridhar.samudrala at intel.com> wrote: > +static struct net_device *net_failover_get_bymac(u8 *mac, > + struct net_failover_ops **ops) > +{ > + struct net_device *failover_dev; > + struct net_failover *failover; > + > + spin_lock(&net_failover_lock); > + list_for_each_entry(failover,

...nabled = true; + else + info.tx_enabled = false; + } else { + if ((primary_dev && netif_running(primary_dev)) || + (!netif_running(standby_dev))) + info.tx_enabled = false; + else + info.tx_enabled = true; + } + + netdev_lower_state_changed(slave_dev, &info); +} + +/** + * net_failover_slave_register - Register a slave netdev + * + * @slave_dev: slave netdev that is being registered + * + * Registers a slave device to a failover instance. For a 2 netdev model, + * this will be primary netdev. In case of a 3 netdev model, it can be a + * standby or a primary netdev. + * + */ +static int net_fa...

...+ return failover_dev; >> + } >> + } >> + spin_unlock(&net_failover_lock); >> + return NULL; >> +} > This is broken if non-ethernet devices such as Infiniband are present. There is check to make sure that a slave and failover devices are of the same type in net_failover_slave_register() failover_dev = net_failover_get_bymac(slave_dev->perm_addr, &nfo_ops); ??????? if (!failover_dev) ??????????????? goto done; ??????? if (failover_dev->type != slave_dev->type) ??????????????? goto done; Do you think this is not good enough? I had an explicit check for ARPHR...

Sorry for replying to this ancient thread. There was some remaining issue that I don't think the initial net_failover patch got addressed cleanly, see: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1815268 The renaming of 'eth0' to 'ens4' fails because the udev userspace was not specifically writtten for such kernel automatic enslavement. Specifically, if it is a bond

...led = true; + else + info.tx_enabled = false; + } else { + if ((primary_dev && netif_running(primary_dev)) || + (!netif_running(standby_dev))) + info.tx_enabled = false; + else + info.tx_enabled = true; + } + + netdev_lower_state_changed(slave_dev, &info); +} + +static int net_failover_slave_register(struct net_device *slave_dev, + struct net_device *failover_dev) +{ + struct net_device *standby_dev, *primary_dev; + struct netdev_lag_upper_info lag_upper_info; + struct net_failover_info *nfo_info; + bool slave_is_standby; + u32 orig_mtu; + int err; + + nfo_info = netdev_priv(failove...

...| > call_netdevice_notifiers(NETDEV_REGISTER) | | > failover_event(..., NETDEV_REGISTER, ...) | | > failover_slave_register(ixgbevf_netdev) | | > net_failover_slave_register(ixgbevf_netdev) | | > dev_open(ixgbevf_netdev) | | > | | > |...

The main motivation for this patch is to enable cloud service providers to provide an accelerated datapath to virtio-net enabled VMs in a transparent manner with no/minimal guest userspace changes. This also enables hypervisor controlled live migration to be supported with VMs that have direct attached SR-IOV VF devices. Patch 1 introduces a new feature bit VIRTIO_NET_F_STANDBY that can be used

...call_netdevice_notifiers(NETDEV_REGISTER) | | > > > failover_event(..., NETDEV_REGISTER, ...) | | > > > failover_slave_register(ixgbevf_netdev) | | > > > net_failover_slave_register(ixgbevf_netdev) | | > > > dev_open(ixgbevf_netdev) | | > > > | | > > >...

...call_netdevice_notifiers(NETDEV_REGISTER) | | > >> failover_event(..., NETDEV_REGISTER, ...) | | > >> failover_slave_register(ixgbevf_netdev) | | > >> net_failover_slave_register(ixgbevf_netdev) | | > >> dev_open(ixgbevf_netdev) | | > >> | | > >>...

This is another update based on feedback from MST and Stephen on the last patchset. Hopefully this series can be integrated and any further enhancements can be made on top of this patchset. v8: - Made the failover managment routines more robust by updating the feature bits/other fields in the failover netdev when slave netdevs are registered/unregistered. (mst) - added support for handling

...EGISTER) | | > > > > > failover_event(..., NETDEV_REGISTER, ...) | | > > > > > failover_slave_register(ixgbevf_netdev) | | > > > > > net_failover_slave_register(ixgbevf_netdev) | | > > > > > dev_open(ixgbevf_netdev) | | > > > > > | | > > > > >...

...| > > > > > > > failover_event(..., NETDEV_REGISTER, ...) | | > > > > > > > failover_slave_register(ixgbevf_netdev) | | > > > > > > > net_failover_slave_register(ixgbevf_netdev) | | > > > > > > > dev_open(ixgbevf_netdev) | | > > > > > > > | | >...

...| | > > > > > > failover_event(..., NETDEV_REGISTER, ...) | | > > > > > > failover_slave_register(ixgbevf_netdev) | | > > > > > > net_failover_slave_register(ixgbevf_netdev) | | > > > > > > dev_open(ixgbevf_netdev) | | > > > > > > | | > > > &g...

The main motivation for this patch is to enable cloud service providers to provide an accelerated datapath to virtio-net enabled VMs in a transparent manner with no/minimal guest userspace changes. This also enables hypervisor controlled live migration to be supported with VMs that have direct attached SR-IOV VF devices. Patch 1 introduces a failover module that provides a generic interface for

The main motivation for this patch is to enable cloud service providers to provide an accelerated datapath to virtio-net enabled VMs in a transparent manner with no/minimal guest userspace changes. This also enables hypervisor controlled live migration to be supported with VMs that have direct attached SR-IOV VF devices. Patch 1 introduces a failover module that provides a generic interface for