search for: net_failover_cr

...It exposes 2 sets of interfaces to the paravirtual drivers. > 1. For paravirtual drivers like virtio_net that use 3 netdev model, the > the failover module provides interfaces to create/destroy additional > master netdev and all the slave events are managed internally. > net_failover_create() > net_failover_destroy() > A failover netdev is created that acts a master device and controls 2 > slave devices. The original virtio_net netdev is registered as 'standby' > netdev and a passthru/vf device with the same MAC gets registered as > ...

...ons for paravirtual > + * drivers to enable accelerated datapath and support VF live migration. > + * > + * The notifier and event handling code is based on netvsc driver and failover > + * netdev management routines are based on bond/team driver. > + * > + */ > +/** > + * net_failover_create - Create and register a failover instance > + * > + * @dev: standby netdev * @standby_dev: standby netdev > + * > + * Creates a failover netdev and registers a failover instance for a standby > + * netdev. Used by paravirtual drivers that use 3-netdev model. > + * The fa...

The main motivation for this patch is to enable cloud service providers to provide an accelerated datapath to virtio-net enabled VMs in a transparent manner with no/minimal guest userspace changes. This also enables hypervisor controlled live migration to be supported with VMs that have direct attached SR-IOV VF devices. Patch 1 introduces a new feature bit VIRTIO_NET_F_STANDBY that can be used

...sc implementation. It exposes 2 sets of interfaces to the paravirtual drivers. 1. For paravirtual drivers like virtio_net that use 3 netdev model, the the failover module provides interfaces to create/destroy additional master netdev and all the slave events are managed internally. net_failover_create() net_failover_destroy() A failover netdev is created that acts a master device and controls 2 slave devices. The original virtio_net netdev is registered as 'standby' netdev and a passthru/vf device with the same MAC gets registered as 'primary' netdev. Bo...

...turn NOTIFY_DONE; +} + +static struct failover_ops net_failover_ops = { + .slave_register = net_failover_slave_register, + .slave_unregister = net_failover_slave_unregister, + .slave_link_change = net_failover_slave_link_change, + .slave_name_change = net_failover_slave_name_change, +}; + +/** + * net_failover_create - Create and register a failover instance + * + * @dev: standby netdev + * + * Creates a failover netdev and registers a failover instance for a standby + * netdev. Used by paravirtual drivers that use 3-netdev model. + * The failover netdev acts as a master device and controls 2 slave devices...

...F_STANDBY > > which are not currently addressed. > > F_STANDBY is only enabled when virtio-net device MAC address is equal to the > VFIO device MAC address, I don't think it can be enabled when the MAC > address is randomly assigned (in this case it has already failed in > net_failover_create(), as it has been called using the random mac address), > it's why I didn't check for it. But the spec did not say there's a dependency :(. My point is what should we do if there's F_STANDBY but no MAC? Maybe add a separate patch clearing F_STANDBY in this case? > >...

...-3163,6 +3164,7 @@ static int virtnet_probe(struct virtio_device *vdev) > virtnet_init_settings(dev); > > - if (virtio_has_feature(vdev, VIRTIO_NET_F_STANDBY)) { > + if (virtio_has_feature(vdev, VIRTIO_NET_F_STANDBY) && > + !disable_failover) { > vi->failover = net_failover_create(vi->dev); > if (IS_ERR(vi->failover)) { > err = PTR_ERR(vi->failover); >

On Wed, 27 Feb 2019 20:26:02 -0500, Michael S. Tsirkin wrote: > On Wed, Feb 27, 2019 at 04:52:05PM -0800, Jakub Kicinski wrote: > > On Wed, 27 Feb 2019 19:41:32 -0500, Michael S. Tsirkin wrote: > > > > As this scheme adds much complexity to the kernel naming convention > > > > (currently it's just ethX names) that no userspace can understand. > >

This is another update based on feedback from MST and Stephen on the last patchset. Hopefully this series can be integrated and any further enhancements can be made on top of this patchset. v8: - Made the failover managment routines more robust by updating the feature bits/other fields in the failover netdev when slave netdevs are registered/unregistered. (mst) - added support for handling

...t/virtio_net.c > index 8f08a3e..2d55e2a 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -2935,8 +2935,10 @@ static int virtnet_probe(struct virtio_device *vdev) > > if (virtio_has_feature(vdev, VIRTIO_NET_F_STANDBY)) { > vi->failover = net_failover_create(vi->dev); > - if (IS_ERR(vi->failover)) > + if (IS_ERR(vi->failover)) { > + err = PTR_ERR(vi->failover); > goto free_vqs; > + } > } > > err = register_netdev(dev); > Acked-by: Jason Wang <jasowang at redhat.com>

.../net/virtio_net.c > index 8f08a3e..2d55e2a 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -2935,8 +2935,10 @@ static int virtnet_probe(struct virtio_device *vdev) > > if (virtio_has_feature(vdev, VIRTIO_NET_F_STANDBY)) { > vi->failover = net_failover_create(vi->dev); > - if (IS_ERR(vi->failover)) > + if (IS_ERR(vi->failover)) { > + err = PTR_ERR(vi->failover); > goto free_vqs; > + } > } > > err = register_netdev(dev);

...+ VLAN_HLEN + ETH_DATA_LEN) @@ -3163,6 +3164,7 @@ static int virtnet_probe(struct virtio_device *vdev) virtnet_init_settings(dev); - if (virtio_has_feature(vdev, VIRTIO_NET_F_STANDBY)) { + if (virtio_has_feature(vdev, VIRTIO_NET_F_STANDBY) && + !disable_failover) { vi->failover = net_failover_create(vi->dev); if (IS_ERR(vi->failover)) { err = PTR_ERR(vi->failover);

...virtnet_probe(struct virtio_device *vdev) > > virtnet_init_settings(dev); > > > > - if (virtio_has_feature(vdev, VIRTIO_NET_F_STANDBY)) { > > + if (virtio_has_feature(vdev, VIRTIO_NET_F_STANDBY) && > > + !disable_failover) { > > vi->failover = net_failover_create(vi->dev); > > if (IS_ERR(vi->failover)) { > > err = PTR_ERR(vi->failover); > >

...ort_name = virtnet_get_phys_port_name, }; static void virtnet_config_changed_work(struct work_struct *work) @@ -2876,10 +2902,16 @@ static int virtnet_probe(struct virtio_device *vdev) virtnet_init_settings(dev); + if (virtio_has_feature(vdev, VIRTIO_NET_F_STANDBY)) { + vi->failover = net_failover_create(vi->dev); + if (IS_ERR(vi->failover)) + goto free_vqs; + } + err = register_netdev(dev); if (err) { pr_debug("virtio_net: registering device failed\n"); - goto free_vqs; + goto free_failover; } virtio_device_ready(vdev); @@ -2916,6 +2948,8 @@ static int virtnet...

The main motivation for this patch is to enable cloud service providers to provide an accelerated datapath to virtio-net enabled VMs in a transparent manner with no/minimal guest userspace changes. This also enables hypervisor controlled live migration to be supported with VMs that have direct attached SR-IOV VF devices. Patch 1 introduces a failover module that provides a generic interface for

Sorry for replying to this ancient thread. There was some remaining issue that I don't think the initial net_failover patch got addressed cleanly, see: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1815268 The renaming of 'eth0' to 'ens4' fails because the udev userspace was not specifically writtten for such kernel automatic enslavement. Specifically, if it is a bond

...ort_name = virtnet_get_phys_port_name, }; static void virtnet_config_changed_work(struct work_struct *work) @@ -2876,10 +2902,16 @@ static int virtnet_probe(struct virtio_device *vdev) virtnet_init_settings(dev); + if (virtio_has_feature(vdev, VIRTIO_NET_F_STANDBY)) { + vi->failover = net_failover_create(vi->dev); + if (IS_ERR(vi->failover)) + goto free_vqs; + } + err = register_netdev(dev); if (err) { pr_debug("virtio_net: registering device failed\n"); - goto free_vqs; + goto free_failover; } virtio_device_ready(vdev); @@ -2916,6 +2948,8 @@ static int virtnet...

...-------------------- > (standby virtio-net and net_failover | | > devices created and initialized, | | > i.e. virtnet_probe()-> | | > net_failover_create() | | > was done.) | | > | | > | runs...

...dby virtio-net and net_failover | | > > > devices created and initialized, | | > > > i.e. virtnet_probe()-> | | > > > net_failover_create() | | > > > was done.) | | > > > | | > > >...

The main motivation for this patch is to enable cloud service providers to provide an accelerated datapath to virtio-net enabled VMs in a transparent manner with no/minimal guest userspace changes. This also enables hypervisor controlled live migration to be supported with VMs that have direct attached SR-IOV VF devices. Patch 1 introduces a failover module that provides a generic interface for