search for: net_failov

Hi, On 05/07/2018 03:10 PM, Sridhar Samudrala wrote: > > Signed-off-by: Sridhar Samudrala <sridhar.samudrala at intel.com> > --- > MAINTAINERS | 7 + > include/linux/netdevice.h | 16 + > include/net/net_failover.h | 52 +++ > net/Kconfig | 10 + > net/core/Makefile | 1 + > net/core/net_failover.c | 1044 ++++++++++++++++++++++++++++++++++++++++++++ > 6 files changed, 1130 insertions(+) > create mode 100644 include/net/net_failover.h > create mode 100...

The net_failover driver provides an automated failover mechanism via APIs to create and destroy a failover master netdev and mananges a primary and standby slave netdevs that get registered via the generic failover infrastructure. The failover netdev acts a master device and controls 2 slave devices. The origina...

...> > (currently it's just ethX names) that no userspace can understand. > > > > > > Anything that pokes at slaves needs to be specially designed anyway. > > > Naming seems like a minor issue. > > > > Can the users who care about the naming put net_failover into > > "user space will do the bond enslavement" mode, and do the bond > > creation/management themselves from user space (in systemd/ > > Network Manager) based on the failover flag? > > Putting issues of compatibility aside (userspace tends to be confused...

...adds much complexity to the kernel naming convention > > (currently it's just ethX names) that no userspace can understand. > > Anything that pokes at slaves needs to be specially designed anyway. > Naming seems like a minor issue. Can the users who care about the naming put net_failover into "user space will do the bond enslavement" mode, and do the bond creation/management themselves from user space (in systemd/ Network Manager) based on the failover flag?

...chicken or the egg situation ;) But users can > > > > just blacklist, too. Anyway, I think this is far better than module > > > > parameters > > > > > > Sorry I'm a bit confused. What is better than what? > > > > I mean that blacklist net_failover or module param to disable > > net_failover and handle in user space are better than trying to solve > > the renaming at kernel level (either by adding module params that make > > the kernel rename devices or letting user space change names of running > > devices if they a...

On Wed, 27 Feb 2019 23:47:33 -0500, Michael S. Tsirkin wrote: > On Wed, Feb 27, 2019 at 05:52:18PM -0800, Jakub Kicinski wrote: > > > > Can the users who care about the naming put net_failover into > > > > "user space will do the bond enslavement" mode, and do the bond > > > > creation/management themselves from user space (in systemd/ > > > > Network Manager) based on the failover flag? > > > > > > Putting issues of...

...00, Michael S. Tsirkin wrote: > > It is a bit of a the chicken or the egg situation ;) But users can > > just blacklist, too. Anyway, I think this is far better than module > > parameters > > Sorry I'm a bit confused. What is better than what? I mean that blacklist net_failover or module param to disable net_failover and handle in user space are better than trying to solve the renaming at kernel level (either by adding module params that make the kernel rename devices or letting user space change names of running devices if they are slaves). > > for twiddling ker...

...ied static ip and dhcp configurations using 'network' scripts and Network Manager. - To avoid dhcp requests to be sent over the lower 'standby' and 'primary' netdevs, ifcfg-xxx scripts for the lower devices can be created. - Build tested netvsc module. Updates: - fix net_failover_open() to update failover CARRIER correctly based on standby and primary states. - fix net_failover_handle_frame() to handle frames received on standby when primary is present. - replace netdev_upper_dev_link with netdev_master_upper_dev_link and handle lower dev state changes. - fix net_f...

...sc implementation. It exposes 2 sets of interfaces to the paravirtual drivers. 1. For paravirtual drivers like virtio_net that use 3 netdev model, the the failover module provides interfaces to create/destroy additional master netdev and all the slave events are managed internally. net_failover_create() net_failover_destroy() A failover netdev is created that acts a master device and controls 2 slave devices. The original virtio_net netdev is registered as 'standby' netdev and a passthru/vf device with the same MAC gets registered as 'primary' netde...

...39;s just ethX names) that no userspace can understand. > > > > > > > > Anything that pokes at slaves needs to be specially designed anyway. > > > > Naming seems like a minor issue. > > > > > > Can the users who care about the naming put net_failover into > > > "user space will do the bond enslavement" mode, and do the bond > > > creation/management themselves from user space (in systemd/ > > > Network Manager) based on the failover flag? > > > > Putting issues of compatibility aside (users...

...change events from pci ethernet devices with the same MAC and takeover their datapath. The notifier and event handling code is based on the existing netvsc implementation. Patch 2 refactors netvsc to use the registration/notification framework introduced by failover module. Patch 3 introduces a net_failover driver that provides an automated failover mechanism to paravirtual drivers via APIs to create and destroy a failover master netdev and mananges a primary and standby slave netdevs that get registered via the generic failover infrastructure. Patch 4 introduces a new feature bit VIRTIO_NET_F_STAN...

On Thu, Feb 28, 2019 at 10:13:56AM -0800, Jakub Kicinski wrote: > On Wed, 27 Feb 2019 23:47:33 -0500, Michael S. Tsirkin wrote: > > On Wed, Feb 27, 2019 at 05:52:18PM -0800, Jakub Kicinski wrote: > > > > > Can the users who care about the naming put net_failover into > > > > > "user space will do the bond enslavement" mode, and do the bond > > > > > creation/management themselves from user space (in systemd/ > > > > > Network Manager) based on the failover flag? > > > > > > &g...

...netvsc to only use the notifier/event/lookups from the failover module. The slave register/unregister/link-change handlers are only updated to use the getbymac routine to get the upper netdev. There is no change in their functionality. (stephen) - renamed structs/function/file names to use net_failover prefix. (mst) The main motivation for this patch is to enable cloud service providers to provide an accelerated datapath to virtio-net enabled VMs in a transparent manner with no/minimal guest userspace changes. This also enables hypervisor controlled live migration to be supported with VMs tha...

...change events from pci ethernet devices with the same MAC and takeover their datapath. The notifier and event handling code is based on the existing netvsc implementation. Patch 2 refactors netvsc to use the registration/notification framework introduced by failover module. Patch 3 introduces a net_failover driver that provides an automated failover mechanism to paravirtual drivers via APIs to create and destroy a failover master netdev and mananges a primary and standby slave netdevs that get registered via the generic failover infrastructure. Patch 4 introduces a new feature bit VIRTIO_NET_F_STAN...

...> > It is a bit of a the chicken or the egg situation ;) But users can > > > just blacklist, too. Anyway, I think this is far better than module > > > parameters > > > > Sorry I'm a bit confused. What is better than what? > > I mean that blacklist net_failover or module param to disable > net_failover and handle in user space are better than trying to solve > the renaming at kernel level (either by adding module params that make > the kernel rename devices or letting user space change names of running > devices if they are slaves). > &g...

...It exposes 2 sets of interfaces to the paravirtual drivers. > 1. For paravirtual drivers like virtio_net that use 3 netdev model, the > the failover module provides interfaces to create/destroy additional > master netdev and all the slave events are managed internally. > net_failover_create() > net_failover_destroy() > A failover netdev is created that acts a master device and controls 2 > slave devices. The original virtio_net netdev is registered as 'standby' > netdev and a passthru/vf device with the same MAC gets registered as >...

...t; > option and maybe a module parameter to rename the primary? People can > > then opt in to the old broken behaviour. > Were I could I would ask why a similar opt-in (kernel config or module > parameter) couldn't be implemented to open up the rename restriction on > slave, net_failover in particular. What I felt about this rename restriction > was more because of historical reason than anything else, while net_failover > is comparatively a new type of link that we are now designing proper use > case it should support, and can get it shaped to whatever it fits. My >...

...1/2019 7:33 PM, si-wei liu wrote: > > > On 2/21/2019 5:39 PM, Michael S. Tsirkin wrote: >> On Thu, Feb 21, 2019 at 05:14:44PM -0800, Siwei Liu wrote: >>> Sorry for replying to this ancient thread. There was some remaining >>> issue that I don't think the initial net_failover patch got addressed >>> cleanly, see: >>> >>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1815268 >>> >>> The renaming of 'eth0' to 'ens4' fails because the udev userspace was >>> not specifically writtten for such ker...

...itch over to a VF datapath when STANDBY feature is enabled and a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct attached VF without the need to setup a bond/team between a VF and virtio net device in the guest. It uses the API that is exported by the net_failover driver to create and and destroy a master failover netdev. When STANDBY feature is enabled, an additional netdev(failover netdev) is created that acts as a master device and tracks the state of the 2 lower netdevs. The original virtio_net netdev is marked as 'standby' netdev and a passthr...

...ernel naming convention > > > (currently it's just ethX names) that no userspace can understand. > > > > Anything that pokes at slaves needs to be specially designed anyway. > > Naming seems like a minor issue. > > Can the users who care about the naming put net_failover into > "user space will do the bond enslavement" mode, and do the bond > creation/management themselves from user space (in systemd/ > Network Manager) based on the failover flag? Putting issues of compatibility aside (userspace tends to be confused if you give it two devices...