search for: need_reset

...ng to downtime. >> >> Do you mean act on VIRTIO_NET_F_GUEST_ANNOUNCE >> requests? That flag is tested and netdev_notify_peers >> called before resetting virtio ring state. > > Yes but I wonder if there's a race where announce > is set after it is read but before NEED_RESET is read. > > Re-reading status from the config before reset > might be necessary. Thanks, I'll have a look. Perhaps a host should simply not request a reset while it is waiting for an announce ack.

...ng to downtime. >> >> Do you mean act on VIRTIO_NET_F_GUEST_ANNOUNCE >> requests? That flag is tested and netdev_notify_peers >> called before resetting virtio ring state. > > Yes but I wonder if there's a race where announce > is set after it is read but before NEED_RESET is read. > > Re-reading status from the config before reset > might be necessary. Thanks, I'll have a look. Perhaps a host should simply not request a reset while it is waiting for an announce ack.

...c. >> The IB test itself doesn't needs to be protected by the exclusive lock. Only everything between radeon_save_bios_scratch_regs and radeon_ring_restore. > I'm not sure about that, what do you want to do if the ring tests fail? Do you have to retake the exclusive lock? Just set need_reset again and return -EAGAIN, that should have mostly the same effect as what we are doing right now. Christian. > > ~Maarten >

...>> Do you mean act on VIRTIO_NET_F_GUEST_ANNOUNCE > >> requests? That flag is tested and netdev_notify_peers > >> called before resetting virtio ring state. > > > > Yes but I wonder if there's a race where announce > > is set after it is read but before NEED_RESET is read. > > > > Re-reading status from the config before reset > > might be necessary. > > Thanks, I'll have a look. Perhaps a host should simply not > request a reset while it is waiting for an announce ack. It's one option though we can't make this change...

...IB test itself doesn't needs to be protected by the exclusive lock. Only everything between radeon_save_bios_scratch_regs and radeon_ring_restore. >>> I'm not sure about that, what do you want to do if the ring tests fail? Do you have to retake the exclusive lock? >> Just set need_reset again and return -EAGAIN, that should have mostly the same effect as what we are doing right now. > Yeah, except for the locking the ttm delayed workqueue, but that bool should be easy to save/restore. > I think this could work. Actually you could activate the delayed workqueue much earlier...

>> +static int virtnet_reset(struct virtnet_info *vi) >> +{ >> + struct virtio_device *dev = vi->vdev; >> + int ret; >> + >> + virtio_config_disable(dev); >> + dev->failed = dev->config->get_status(dev) & VIRTIO_CONFIG_S_FAILED; >> + virtnet_freeze_down(dev, true); >> + remove_vq_common(vi); >> +

>> +static int virtnet_reset(struct virtnet_info *vi) >> +{ >> + struct virtio_device *dev = vi->vdev; >> + int ret; >> + >> + virtio_config_disable(dev); >> + dev->failed = dev->config->get_status(dev) & VIRTIO_CONFIG_S_FAILED; >> + virtnet_freeze_down(dev, true); >> + remove_vq_common(vi); >> +

...act on VIRTIO_NET_F_GUEST_ANNOUNCE >> >> requests? That flag is tested and netdev_notify_peers >> >> called before resetting virtio ring state. >> > >> > Yes but I wonder if there's a race where announce >> > is set after it is read but before NEED_RESET is read. >> > >> > Re-reading status from the config before reset >> > might be necessary. >> >> Thanks, I'll have a look. Perhaps a host should simply not >> request a reset while it is waiting for an announce ack. > > It's one option thou...

...act on VIRTIO_NET_F_GUEST_ANNOUNCE >> >> requests? That flag is tested and netdev_notify_peers >> >> called before resetting virtio ring state. >> > >> > Yes but I wonder if there's a race where announce >> > is set after it is read but before NEED_RESET is read. >> > >> > Re-reading status from the config before reset >> > might be necessary. >> >> Thanks, I'll have a look. Perhaps a host should simply not >> request a reset while it is waiting for an announce ack. > > It's one option thou...

...t set before the reset, leading to downtime. > > Do you mean act on VIRTIO_NET_F_GUEST_ANNOUNCE > requests? That flag is tested and netdev_notify_peers > called before resetting virtio ring state. Yes but I wonder if there's a race where announce is set after it is read but before NEED_RESET is read. Re-reading status from the config before reset might be necessary. -- MST

...;> >> +??? void (*set_status)(struct mdev_device *mdev, u8 status); > > Hi Jason > > Is it possible to make set_status() return an u8 or bool, because this > may fail in real hardware. Without a returned code, I am not sure? > whether it is a good idea to set the status | NEED_RESET when fail. > > Thanks, > BR > Zhu Lingshan Hi: It's possible but I'm not sure whether any user will care about it. E.g see virtio_add_status(): void virtio_add_status(struct virtio_device *dev, unsigned int status) { ??? might_sleep(); ??? dev->config->set_status(dev...

...he IB test itself doesn't needs to be protected by the exclusive lock. Only everything between radeon_save_bios_scratch_regs and radeon_ring_restore. >> I'm not sure about that, what do you want to do if the ring tests fail? Do you have to retake the exclusive lock? > > Just set need_reset again and return -EAGAIN, that should have mostly the same effect as what we are doing right now. Yeah, except for the locking the ttm delayed workqueue, but that bool should be easy to save/restore. I think this could work. ~Maarten

From: Anand Jain <anand.jain@oracle.com> (This patch is for the review/test not yet for the integration). Here is an implementation of the feature to add label to the subvolume and snapshots. Which would help sysadmin to better manager the subvol and snapshots. This can be done in two ways, one - using attr which is user land only changes but drawback is able to change the label

Am 04.08.2014 um 16:40 schrieb Maarten Lankhorst: > op 04-08-14 16:37, Christian K?nig schreef: >>> It'a pain to deal with gpu reset. >> Yeah, well that's nothing new. >> >>> I've now tried other solutions but that would mean reverting to the old style during gpu lockup recovery, and only running the delayed work when !lockup. >>> But this

From: Anand <anand.jain@oracle.com> This patch adds creation-time to the snapshot list display, which would help user to better manage the snapshots when number of snapshots grow substantially. This patch is developed and on top of the send/receive btrfs and btrfs-progs repo at git://github.com/ablock84/linux-btrfs.git (send-v2) git://github.com/ablock84/btrfs-progs.git (send-v2)

Hi all: There are hardwares that can do virtio datapath offloading while having its own control path. This path tries to implement a mdev based unified API to support using kernel virtio driver to drive those devices. This is done by introducing a new mdev transport for virtio (virtio_mdev) and register itself as a new kind of mdev driver. Then it provides a unified way for kernel virtio driver

Hi all: There are hardwares that can do virtio datapath offloading while having its own control path. This path tries to implement a mdev based unified API to support using kernel virtio driver to drive those devices. This is done by introducing a new mdev transport for virtio (virtio_mdev) and register itself as a new kind of mdev driver. Then it provides a unified way for kernel virtio driver