search for: need_inotify

...f2b..8bb8ed2 100644 --- a/daemon/inotify.c +++ b/daemon/inotify.c @@ -33,7 +33,7 @@ static int inotify_fd = -1; static char inotify_buf[64*1024*1024]; /* Event buffer, [0..posn-1] is valid */ -static int inotify_posn = 0; +static size_t inotify_posn = 0; /* Because inotify_init does NEED_ROOT, NEED_INOTIFY implies NEED_ROOT. */ #define NEED_INOTIFY(errcode) \ @@ -184,7 +184,8 @@ do_inotify_read (void) while (space > 0) { struct inotify_event *event; - int n, r; + int r; + size_t n; r = read (inotify_fd, inotify_buf + inotify_posn, sizeof (inotify_buf) -...

From: "Richard W.M. Jones" <rjones at redhat.com> Callers are supposed to use the availability API to check for functions that may not be available in particular builds of libguestfs. If they don't do this, currently they tend to get obscure error messages, eg: libguestfs: error: zerofree: /dev/vda1: zerofree: No such file or directory This commit changes the error

...H. --- daemon/inotify.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/daemon/inotify.c b/daemon/inotify.c index 7834dcb..3e314f0 100644 --- a/daemon/inotify.c +++ b/daemon/inotify.c @@ -129,7 +129,6 @@ do_inotify_add_watch (const char *path, int mask) char *buf; NEED_INOTIFY (-1); - ABS_PATH (path, return -1); buf = sysroot_path (path); if (!buf) { -- 1.6.2.5 -------------- next part -------------- >From dcd67e2c4e81bb270ea7f5ed8b6675b114afca60 Mon Sep 17 00:00:00 2001 From: Richard Jones <rjones at trick.home.annexia.org> Date: Thu, 13 Aug 2009 14:...

This started as a simple warning-elimination change. I'll get back to that series shortly ;-) It turned into a factorization and constification exercise during which I got a taste of ocaml. Thanks to Rich Jones for help with a few snippets in generator.ml. The overall result is that many previously-manually-maintained bits from daemon/*.c functions are now hoisted into the automatically-