Displaying 5 results from an estimated 5 matches for "ne10_fft_cfg_float32".
Did you mean:
ne10_fft_cfg_float32_t
2015 Feb 03
2
opus Digest, Vol 72, Issue 17
...ge of _t from NE10 api for following types:
> ne10_int32_t ------> will become ----> ne10_int32
> ne10_fft_cpx_float32_t ------> will become ----> ne10_fft_cpx_float32
> ne10_fft_state_float32_t ------> will become ---> ne10_fft_state_float32
> ne10_fft_cfg_float32_t -----> will become ----> ne10_fft_cfg_float32
>
> 2. Provide scaling as argument to ne10_fft_c2c_1d_float32_neon() and
> remove need for one buffer on stack (ALLOC(tempin, st->nfft,
> ne10_fft_cpx_float32_t);). We will still need cfg->buffer. So, peak stack usage
> go...
2015 Jan 29
0
[RFC PATCH v1 2/2] armv7(float): Optimize encode usecase using NE10 library
...Phil is one of developers/maintainers of opus. Please correct me if
any of information below is inaccurate from a libNE10 change request
perspective.
Phil,
Below are 2 main things we need to change from NE10 Library side. Can
you please make these changes on NE10 side?
1. Remove usage of _t in ne10_fft_cfg_float32_t and ne10_fft_cpx_float32_t
-------from comment----
ne10_fft_cfg_float32_t cfg = (ne10_fft_cfg_float32_t)st->priv;
+ VARDECL(ne10_fft_cpx_float32_t, temp);
+ VARDECL(ne10_fft_cpx_float32_t, tempin);
Just another note on API design... the _t suffix is reserved by POSIX,
and should never be...
2015 Jan 30
1
[RFC PATCH v1 2/2] armv7(float): Optimize encode usecase using NE10 library
Viswanath Puttagunta wrote:
> Is the peak stack usage a complete blocker in current form?
Since this only affects people who enable NE10, I don't think this is a
blocker.
2015 Feb 04
0
opus Digest, Vol 72, Issue 17
...10 api for following types:
>> ne10_int32_t ------> will become ----> ne10_int32
>> ne10_fft_cpx_float32_t ------> will become ----> ne10_fft_cpx_float32
>> ne10_fft_state_float32_t ------> will become ---> ne10_fft_state_float32
>> ne10_fft_cfg_float32_t -----> will become ----> ne10_fft_cfg_float32
>>
>> 2. Provide scaling as argument to ne10_fft_c2c_1d_float32_neon() and
>> remove need for one buffer on stack (ALLOC(tempin, st->nfft,
>> ne10_fft_cpx_float32_t);). We will still need cfg->buffer. So, peak sta...
2015 Jan 29
2
[RFC PATCH v1 2/2] armv7(float): Optimize encode usecase using NE10 library
...32_neon(st->nfft);
> + if (st->priv == NULL) {
> + printf("Unable to ne10 alloc\n");
Absolutely no printfs in library code.
> + return -1;
> + }
> + return 0;
> +}
> +
> +void opus_fft_free_arm_float_neon(kiss_fft_state *st)
> +{
> + ne10_fft_cfg_float32_t cfg = (ne10_fft_cfg_float32_t)st->priv;
> +
> + if (cfg)
> + free((void *)cfg);
This concerns me for several reasons:
1) We never call free() directly in libopus. It is always wrapped in the
opus_free() macro to allow ports to override it (and as a debugging tool).
2) We di...