search for: ndo_tx_timeout

On Sun, Oct 06, 2019 at 03:45:15PM -0300, jcfaracco at gmail.com wrote: > From: Julio Faracco <jcfaracco at gmail.com> > > To enable dev_watchdog, virtio_net should have a tx_timeout defined > (.ndo_tx_timeout). This is only a skeleton to throw a warn message. It > notifies the event in some specific queue of device. This function > still counts tx_timeout statistic and consider this event as an error > (one error per queue), reporting it. > > Signed-off-by: Julio Faracco <jcfaracco...

On Sun, Oct 06, 2019 at 03:45:15PM -0300, jcfaracco at gmail.com wrote: > From: Julio Faracco <jcfaracco at gmail.com> > > To enable dev_watchdog, virtio_net should have a tx_timeout defined > (.ndo_tx_timeout). This is only a skeleton to throw a warn message. It > notifies the event in some specific queue of device. This function > still counts tx_timeout statistic and consider this event as an error > (one error per queue), reporting it. > > Signed-off-by: Julio Faracco <jcfaracco...

From: Julio Faracco <jcfaracco at gmail.com> Driver virtio_net is not handling error events for TX provided by dev_watchdog. This event is reached when transmission queue is having problems to transmit packets. To enable it, driver should have .ndo_tx_timeout implemented. This serie has two commits: In the past, we implemented a function to recover driver state when this kind of event happens, but the structure was to complex for virtio_net that moment. Alternativelly, this skeleton should be enough for now. For further details, see thread: https://lk...

From: Julio Faracco <jcfaracco at gmail.com> Driver virtio_net is not handling error events for TX provided by dev_watchdog. This event is reached when transmission queue is having problems to transmit packets. To enable it, driver should have .ndo_tx_timeout implemented. This serie has two commits: In the past, we implemented a function to recover driver state when this kind of event happens, but the structure was to complex for virtio_net that moment. Alternativelly, this skeleton should be enough for now. For further details, see thread: https://lk...

...the issue, kindly add following tag Reported-by: kbuild test robot <lkp at intel.com> All errors (new ones prefixed by >>): >> drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:2622:20: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] .ndo_tx_timeout = dpaa_tx_timeout, ^~~~~~~~~~~~~~~ drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:2622:20: note: (near initialization for 'dpaa_ops.ndo_tx_timeout') cc1: some warnings being treated as errors vim +2622 drivers/net/ethernet/freescale/dpaa/dpaa_eth.c 4664856e9ca...

Driver virtio_net is not handling error events for TX provided by dev_watchdog. This event is reached when transmission queue is having problems to transmit packets. This could happen for any reason. To enable it, driver should have .ndo_tx_timeout implemented. This commit brings back virtnet_reset method to recover TX queues from a error state. That function is called by schedule_work method and it puts the reset function into work queue. As the error cause is unknown at this moment, it would be better to reset all queues. Signed-off-by:...

Driver virtio_net is not handling error events for TX provided by dev_watchdog. This event is reached when transmission queue is having problems to transmit packets. This could happen for any reason. To enable it, driver should have .ndo_tx_timeout implemented. This commit brings back virtnet_reset method to recover TX queues from a error state. That function is called by schedule_work method and it puts the reset function into work queue. As the error cause is unknown at this moment, it would be better to reset all queues. Signed-off-by:...

From: Julio Faracco <jcfaracco at gmail.com> To enable dev_watchdog, virtio_net should have a tx_timeout defined (.ndo_tx_timeout). This is only a skeleton to throw a warn message. It notifies the event in some specific queue of device. This function still counts tx_timeout statistic and consider this event as an error (one error per queue), reporting it. Signed-off-by: Julio Faracco <jcfaracco at gmail.com> Signed-...

..., Michael S. Tsirkin <mst at redhat.com> escreveu: > > On Sun, Oct 06, 2019 at 03:45:15PM -0300, jcfaracco at gmail.com wrote: > > From: Julio Faracco <jcfaracco at gmail.com> > > > > To enable dev_watchdog, virtio_net should have a tx_timeout defined > > (.ndo_tx_timeout). This is only a skeleton to throw a warn message. It > > notifies the event in some specific queue of device. This function > > still counts tx_timeout statistic and consider this event as an error > > (one error per queue), reporting it. > > > > Signed-off-by: Julio...

Driver virtio_net is not handling error events for TX provided by dev_watchdog. This event is reached when transmission queue is having problems to transmit packets. This could happen for any reason. To enable it, driver should have .ndo_tx_timeout implemented. This commit brings back virtnet_reset method to recover TX queues from a error state. That function is called by schedule_work method and it puts the reset function into work queue. As the error cause is unknown at this moment, it would be better to reset all queues, including RX (be...

Driver virtio_net is not handling error events for TX provided by dev_watchdog. This event is reached when transmission queue is having problems to transmit packets. This could happen for any reason. To enable it, driver should have .ndo_tx_timeout implemented. This commit brings back virtnet_reset method to recover TX queues from a error state. That function is called by schedule_work method and it puts the reset function into work queue. As the error cause is unknown at this moment, it would be better to reset all queues. Signed-off-by:...

...019 at 10:36:36PM -0300, Julio Faracco wrote: > Driver virtio_net is not handling error events for TX provided by > dev_watchdog. This event is reached when transmission queue is having > problems to transmit packets. This could happen for any reason. To > enable it, driver should have .ndo_tx_timeout implemented. > > This commit brings back virtnet_reset method to recover TX queues from a > error state. That function is called by schedule_work method and it puts > the reset function into work queue. > > As the error cause is unknown at this moment, it would be better to >...

...{ .ndo_open = virtnet_open, .ndo_stop = virtnet_close, @@ -1405,6 +1420,7 @@ static const struct net_device_ops virtnet_netdev = { .ndo_get_stats64 = virtnet_stats, .ndo_vlan_rx_add_vid = virtnet_vlan_rx_add_vid, .ndo_vlan_rx_kill_vid = virtnet_vlan_rx_kill_vid, + .ndo_tx_timeout = virtnet_tx_timeout, #ifdef CONFIG_NET_POLL_CONTROLLER .ndo_poll_controller = virtnet_netpoll, #endif @@ -1750,6 +1766,7 @@ static int virtnet_probe(struct virtio_device *vdev) dev->netdev_ops = &virtnet_netdev; dev->features = NETIF_F_HIGHDMA; + dev->watchdog_timeo = 5...

...{ .ndo_open = virtnet_open, .ndo_stop = virtnet_close, @@ -1405,6 +1420,7 @@ static const struct net_device_ops virtnet_netdev = { .ndo_get_stats64 = virtnet_stats, .ndo_vlan_rx_add_vid = virtnet_vlan_rx_add_vid, .ndo_vlan_rx_kill_vid = virtnet_vlan_rx_kill_vid, + .ndo_tx_timeout = virtnet_tx_timeout, #ifdef CONFIG_NET_POLL_CONTROLLER .ndo_poll_controller = virtnet_netpoll, #endif @@ -1750,6 +1766,7 @@ static int virtnet_probe(struct virtio_device *vdev) dev->netdev_ops = &virtnet_netdev; dev->features = NETIF_F_HIGHDMA; + dev->watchdog_timeo = 5...

...rtnet_close, > > @@ -1405,6 +1420,7 @@ static const struct net_device_ops virtnet_netdev = { > > .ndo_get_stats64 = virtnet_stats, > > .ndo_vlan_rx_add_vid = virtnet_vlan_rx_add_vid, > > .ndo_vlan_rx_kill_vid = virtnet_vlan_rx_kill_vid, > > + .ndo_tx_timeout = virtnet_tx_timeout, > > #ifdef CONFIG_NET_POLL_CONTROLLER > > .ndo_poll_controller = virtnet_netpoll, > > #endif > > @@ -1750,6 +1766,7 @@ static int virtnet_probe(struct virtio_device *vdev) > > dev->netdev_ops = &virtnet_netdev; > >...

...rtnet_close, > > @@ -1405,6 +1420,7 @@ static const struct net_device_ops virtnet_netdev = { > > .ndo_get_stats64 = virtnet_stats, > > .ndo_vlan_rx_add_vid = virtnet_vlan_rx_add_vid, > > .ndo_vlan_rx_kill_vid = virtnet_vlan_rx_kill_vid, > > + .ndo_tx_timeout = virtnet_tx_timeout, > > #ifdef CONFIG_NET_POLL_CONTROLLER > > .ndo_poll_controller = virtnet_netpoll, > > #endif > > @@ -1750,6 +1766,7 @@ static int virtnet_probe(struct virtio_device *vdev) > > dev->netdev_ops = &virtnet_netdev; > >...

...ruct net_device_ops virtnet_netdev > > > > = { > > > > .ndo_get_stats64 = virtnet_stats, > > > > .ndo_vlan_rx_add_vid = virtnet_vlan_rx_add_vid, > > > > .ndo_vlan_rx_kill_vid = virtnet_vlan_rx_kill_vid, > > > > + .ndo_tx_timeout = virtnet_tx_timeout, > > > > #ifdef CONFIG_NET_POLL_CONTROLLER > > > > .ndo_poll_controller = virtnet_netpoll, > > > > #endif > > > > @@ -1750,6 +1766,7 @@ static int virtnet_probe(struct virtio_device > > > > *vdev) > &gt...

...ruct net_device_ops virtnet_netdev > > > > = { > > > > .ndo_get_stats64 = virtnet_stats, > > > > .ndo_vlan_rx_add_vid = virtnet_vlan_rx_add_vid, > > > > .ndo_vlan_rx_kill_vid = virtnet_vlan_rx_kill_vid, > > > > + .ndo_tx_timeout = virtnet_tx_timeout, > > > > #ifdef CONFIG_NET_POLL_CONTROLLER > > > > .ndo_poll_controller = virtnet_netpoll, > > > > #endif > > > > @@ -1750,6 +1766,7 @@ static int virtnet_probe(struct virtio_device > > > > *vdev) > &gt...

...ail.com wrote: > From: Julio Faracco <jcfaracco at gmail.com> > > Driver virtio_net is not handling error events for TX provided by > dev_watchdog. This event is reached when transmission queue is having > problems to transmit packets. To enable it, driver should have > .ndo_tx_timeout implemented. This serie has two commits: > > In the past, we implemented a function to recover driver state when this > kind of event happens, but the structure was to complex for virtio_net > that moment. It's more that it was missing a bunch of locks. > Alternativelly, this...

...rtnet_open, > .ndo_stop = virtnet_close, > @@ -1405,6 +1420,7 @@ static const struct net_device_ops virtnet_netdev = { > .ndo_get_stats64 = virtnet_stats, > .ndo_vlan_rx_add_vid = virtnet_vlan_rx_add_vid, > .ndo_vlan_rx_kill_vid = virtnet_vlan_rx_kill_vid, > + .ndo_tx_timeout = virtnet_tx_timeout, > #ifdef CONFIG_NET_POLL_CONTROLLER > .ndo_poll_controller = virtnet_netpoll, > #endif > @@ -1750,6 +1766,7 @@ static int virtnet_probe(struct virtio_device *vdev) > dev->netdev_ops = &virtnet_netdev; > dev->features = NETIF_F_HIGHDMA;...