search for: nbdplug_flush

...he meantime needs this patch to deal with the ABI change. --- plugins/nbd/nbd.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/plugins/nbd/nbd.c b/plugins/nbd/nbd.c index 68ea3dd0..818f94d6 100644 --- a/plugins/nbd/nbd.c +++ b/plugins/nbd/nbd.c @@ -783,9 +783,18 @@ nbdplug_flush (void *handle, uint32_t flags) return nbdplug_reply (h, s); } +/* XXX: Hack this signature to compile to 0.1.3 (minimum configure + * version) as well as 0.1.5 (API change, with witness of the addition + * of pread_structured at the same release). Once configure requires a + * higher minimum v...

libnbd 0.1.7 was released today, which breaks compilation of nbdkit-nbd-plugin. We could work around it by using #ifdef LIBNBD_HAVE_XXX to learn about the renamed functions, but supporting older versions is not all that important when we don't yet have API stability. So patch 1 copes by just bumping the minimum version instead, except that we have yet another pending libnbd patch with an API

...nbdplug_register (h, &s, nbd_aio_trim_callback (h->nbd, count, offset, - &s, nbdplug_notify, f)); + nbdplug_notify, &s, f)); return nbdplug_reply (h, &s); } @@ -738,7 +738,7 @@ nbdplug_flush (void *handle, uint32_t flags) assert (!flags); nbdplug_prepare (&s); nbdplug_register (h, &s, nbd_aio_flush_callback (h->nbd, - &s, nbdplug_notify, 0)); + nbdplug_notify, &am...

I'm not observing any noticeable performance differences, but I'm liking the diffstat. I can't push this patch until we release a new libnbd version with the _notify API addition, but am posting it now for playing with things. Eric Blake (2): nbd: Move transaction info from heap to stack nbd: Use nbdkit aio_*_notify variants plugins/nbd/nbd.c | 217

...;s); - nbdplug_register (h, &s, nbd_aio_trim (h->nbd, count, offset, f)); + nbdplug_register (h, &s, nbd_aio_trim_notify (h->nbd, count, offset, + &s, nbdplug_notify, f)); return nbdplug_reply (h, &s); } @@ -778,7 +737,8 @@ nbdplug_flush (void *handle, uint32_t flags) assert (!flags); nbdplug_prepare (&s); - nbdplug_register (h, &s, nbd_aio_flush (h->nbd, 0)); + nbdplug_register (h, &s, nbd_aio_flush_notify (h->nbd, + &s, nbdplug_notify, 0)); return n...

...lug_register (h, &s, nbd_aio_trim_callback (h->nbd, count, offset, - nbdplug_notify, &s, f)); + nbdplug_register (h, &s, nbd_aio_trim (h->nbd, count, offset, s.cb, f)); return nbdplug_reply (h, &s); } @@ -758,23 +758,17 @@ nbdplug_flush (void *handle, uint32_t flags) assert (!flags); nbdplug_prepare (&s); - nbdplug_register (h, &s, nbd_aio_flush_callback (h->nbd, - nbdplug_notify, &s, 0)); + nbdplug_register (h, &s, nbd_aio_flush (h->nbd, s.cb, 0));...

Patch 1 played with an early draft of Rich's Fedora 30 libnbd package: https://bugzilla.redhat.com/show_bug.cgi?id=1713767#c17 Note that comment 21 provides a newer package 0.1.1-1 with a different API; and that libnbd has more unreleased API changes in the pipeline (whether that will be called 0.2 or 0.1.2); so we'll have to tweak things based on what is actually available in distros.

libnbd-0.1.2-1 is now available in Fedora 29/30 updates-testing, although it was not compiled against libxml2 so it lacks uri support (I ended up testing patch 4 with a self-built libnbd). Diffs since v1 - rebase to master, bump from libnbd 0.1 to 0.1.2, add URI support, better timing results Still not done - patch 5 needs associated tests Eric Blake (5): nbd: Check for libnbd nbd:

...(!(flags & ~NBDKIT_FLAG_FUA)); - s = nbdplug_request (h, flags & NBDKIT_FLAG_FUA ? NBD_CMD_FLAG_FUA : 0, - NBD_CMD_TRIM, offset, count); + s = nbdplug_register (h, nbd_aio_trim (h->nbd, count, offset, f)); return nbdplug_reply (h, s); } @@ -1300,10 +675,36 @@ nbdplug_flush (void *handle, uint32_t flags) struct transaction *s; assert (!flags); - s = nbdplug_request (h, 0, NBD_CMD_FLUSH, 0, 0); + /* XXX API changes in libnbd 0.1.2: */ + s = nbdplug_register (h, nbd_aio_flush (h->nbd /* , f */)); return nbdplug_reply (h, s); } +struct nbdplug_extent_da...

...(!(flags & ~NBDKIT_FLAG_FUA)); - s = nbdplug_request (h, flags & NBDKIT_FLAG_FUA ? NBD_CMD_FLAG_FUA : 0, - NBD_CMD_TRIM, offset, count); + s = nbdplug_register (h, nbd_aio_trim (h->nbd, count, offset, f)); return nbdplug_reply (h, s); } @@ -1305,10 +662,29 @@ nbdplug_flush (void *handle, uint32_t flags) struct transaction *s; assert (!flags); - s = nbdplug_request (h, 0, NBD_CMD_FLUSH, 0, 0); + s = nbdplug_register (h, nbd_aio_flush (h->nbd, 0)); return nbdplug_reply (h, s); } +static int +nbdplug_extent (void *opaque, const char *metacontext, uint64...

libnbd-0.1.4-1 is now available in Fedora 29/30 updates testing. Diffs since v2 - rebase to master, bump from libnbd 0.1.2 to 0.1.3+, add tests to TLS usage which flushed out the need to turn relative pathnames into absolute, doc tweaks Now that the testsuite covers TLS and libnbd has been fixed to provide the things I found lacking when developing v2, I'm leaning towards pushing this on