Displaying 5 results from an estimated 5 matches for "nbdkit_private_init".
2020 Mar 26
3
Re: [PATCH nbdkit 5/9 patch split 2/5] lib: Move code for parsing, passwords and paths into libnbdkit.so.
...bnbdkit.so? If I read the
Makefile changes correctly, you went with the former. I'm wondering if
we want to add some sort of 'assert(is_initialized)' to all of our
public entry functions to ensure that no one is actually trying to use
libnbdkit.so without having first gone through nbdkit_private_init; if
we did that, then test-public should indeed build from direct files
rather than trying to link against libnbdkit.so and bypass the
initialization normally done by the nbdkit binary.
> +++ b/lib/libnbdkit.syms
> @@ -38,6 +38,26 @@
> {
> # The functions we want plugins and...
2020 Mar 27
1
Re: [PATCH nbdkit 5/9 patch split 2/5] lib: Move code for parsing, passwords and paths into libnbdkit.so.
....so?
>
> I will fix this in my copy.
>
>> I'm wondering if we want to add some sort of
>> 'assert(is_initialized)' to all of our public entry functions to
>> ensure that no one is actually trying to use libnbdkit.so without
>> having first gone through nbdkit_private_init;[...]
>
> So firstly I believe this can only be a problem if the server itself
> uses __attribute__((constructor)), since plugins and filters are
> always dlopened long after main() in the server has run. Is that
> correct?
Right. I'm not worried about plugins ever running at...
2020 Mar 26
0
Re: [PATCH nbdkit 5/9 patch split 2/5] lib: Move code for parsing, passwords and paths into libnbdkit.so.
...it be linked against libnbdkit.so?
I will fix this in my copy.
> I'm wondering if we want to add some sort of
> 'assert(is_initialized)' to all of our public entry functions to
> ensure that no one is actually trying to use libnbdkit.so without
> having first gone through nbdkit_private_init;[...]
So firstly I believe this can only be a problem if the server itself
uses __attribute__((constructor)), since plugins and filters are
always dlopened long after main() in the server has run. Is that
correct?
The only ((constructor)) currently used is in the OCaml plugin.
If the server doe...
2020 Mar 26
9
[PATCH nbdkit 5/9 patch split 1/5] Create libnbdkit.so.
This is the previous 5/9 patch posted earlier today, split into
reviewable chunks. This passes bisection with -x 'make && make
check', but I didn't work very hard on the commit messages, so I refer
you back to the original patch to explain how it works:
https://www.redhat.com/archives/libguestfs/2020-March/msg00248.html
Rich.
2020 Mar 26
15
[PATCH nbdkit 0/9] Create libnbdkit.so
This creates libnbdkit.so as discussed in the following thread:
https://www.redhat.com/archives/libguestfs/2020-March/thread.html#00203
test-delay-shutdown.sh fails for unclear reasons.
This series starts by reverting "tests: Don't strand hung nbdkit
processes" which is because several other tests fail randomly unless I
revert this patch. I didn't investigate this yet so it