search for: nbdkit_plugin_level

...rote: > I had an idea about how we might do this and still keep a single > .pwrite method for plugins. Maybe it's too complicated but here goes: > > > This is binary-compatible with old plugins, but not source compatible, so: > > > (2) Plugsin may optionally define NBDKIT_PLUGIN_LEVEL before including > <nbdkit-plugin.h>. Code wishing to use the flags variant of pwrite > can do: > > #define NBDKIT_PLUGIN_LEVEL 2 > #include <nbdkit-plugin.h> > > which would modify the definition of the struct (again), something > like: > > #ifndef NBD...

...nsertions(+), 22 deletions(-) diff --git a/docs/nbdkit-plugin.pod b/docs/nbdkit-plugin.pod index 933f710..a82ced8 100644 --- a/docs/nbdkit-plugin.pod +++ b/docs/nbdkit-plugin.pod @@ -6,7 +6,7 @@ nbdkit-plugin - How to write nbdkit plugins =head1 SYNOPSIS - #define NBDKIT_API_VERSION 2 + #define NBDKIT_PLUGIN_LEVEL 2 #include <nbdkit-plugin.h> @@ -65,22 +65,22 @@ L<nbdkit-perl-plugin(3)>, L<nbdkit-python-plugin(3)>, L<nbdkit-ruby-plugin(3)>. -=head1 C<#define NBDKIT_API_VERSION 2> +=head1 C<#define NBDKIT_PLUGIN_LEVEL 2> Plugins must choose which API version th...

...offset, int may_trim); int errno_is_preserved; void (*dump_plugin) (void); + int (*pwrite) (void *handle, const void *buf, uint32_t count, uint64_t offset, unsigned flags); This is binary-compatible with old plugins, but not source compatible, so: (2) Plugsin may optionally define NBDKIT_PLUGIN_LEVEL before including <nbdkit-plugin.h>. Code wishing to use the flags variant of pwrite can do: #define NBDKIT_PLUGIN_LEVEL 2 #include <nbdkit-plugin.h> which would modify the definition of the struct (again), something like: #ifndef NBDKIT_PLUGIN_LEVEL #define NBDKIT_PLUGIN_LEVEL 1 #en...

Tested via: term1$ qemu-nbd -k $PWD/sock -t -f raw -x foo junk --trace=nbd_\* term2$ ./nbdkit -f -v -e bar nbd socket=$PWD/sock export=foo term3$ qemu-io -t none -f raw nbd://localhost:10809/bar --trace=nbd_\* and checking the traces to see that 'w 0 1' vs. 'w -f 0 1' was able to influence whether the FUA flag showed up at the server in term1. Still to go: figure out how to

On Wed, Jan 17, 2018 at 08:01:35PM -0600, Eric Blake wrote: > Actually, thinking about this more: > > When I added zero support, I documented in commit ac3f294a that for the > file plugin, wdelay is indeed doubled on systems lacking efficient zero > support. But the fallback for handling EOPNOTSUPP is currently done at > the plugins.c level (ie. it is part of next->zero()) -

After more than a month since v2 [1], I've finally got my FUA support series polished. This is all of my outstanding patches, even though some of them were originally posted in separate threads from the original FUA post [2], [3] [1] https://www.redhat.com/archives/libguestfs/2018-January/msg00113.html [2] https://www.redhat.com/archives/libguestfs/2018-January/msg00219.html [3]