search for: nbdkit_dependencies

...e). --- src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index 5c67bf8..046bdc3 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -80,7 +80,7 @@ nbdkit_LDFLAGS = \ # used to generate the man page. EXTRA_DIST = synopsis.c -nbdkit_DEPENDENCIES = synopsis.c +main.c: synopsis.c synopsis.c: $(top_srcdir)/docs/synopsis.txt rm -f $@ $@-t $(SED) -e 's/\(.*\)/"\1\\n"/g' $< > $@-t -- 2.17.1

...Makefile.am > +++ b/src/Makefile.am > @@ -80,6 +80,7 @@ nbdkit_LDFLAGS = \ > # synopsis.c is generated from docs/synopsis.txt where it is also > # used to generate the man page. It is included in main.c. > > +BUILT_SOURCES = synopsis.c > EXTRA_DIST = synopsis.c > nbdkit_DEPENDENCIES = synopsis.c > CLEANFILES += synopsis.c Did this make an actual difference during parallel 'make', given that you already have nbdkit_DEPENDENCIES to trigger normal make prerequisites? Automake's implementation of BUILT_SOURCES states that they will be rebuilt even when Makefil...

How about this variation of your patch? It fixes the problem from a fresh git checkout for me. Rich.

With some crufty sed scripts we can generate functions that map from NBD protocol flags (eg. NBD_CMD_READ) to strings ("NBD_CMD_READ"). This works on GNU sed and with FreeBSD, also with GNU sed's --posix option, so I guess the sed code is POSIX-compatible. Rich.

...9e0a9 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -77,10 +77,11 @@ nbdkit_LDFLAGS = \ -rdynamic # synopsis.c is generated from docs/synopsis.txt where it is also -# used to generate the man page. +# used to generate the man page. It is included in main.c. EXTRA_DIST = synopsis.c nbdkit_DEPENDENCIES = synopsis.c +main.c: synopsis.c synopsis.c: $(top_srcdir)/docs/synopsis.txt rm -f $@ $@-t $(SED) -e 's/\(.*\)/"\1\\n"/g' $< > $@-t -- 2.18.0

...e.am index 3490c0f..65f9498 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -80,6 +80,7 @@ nbdkit_LDFLAGS = \ # synopsis.c is generated from docs/synopsis.txt where it is also # used to generate the man page. It is included in main.c. +BUILT_SOURCES = synopsis.c EXTRA_DIST = synopsis.c nbdkit_DEPENDENCIES = synopsis.c CLEANFILES += synopsis.c -- 2.19.0.rc0

...t; > # synopsis.c is generated from docs/synopsis.txt where it is also > -# used to generate the man page. > +# used to generate the man page. It is included in main.c. > Looks good, but now we have 2 place to edit if we include this in another source. EXTRA_DIST = synopsis.c > nbdkit_DEPENDENCIES = synopsis.c > +main.c: synopsis.c > synopsis.c: $(top_srcdir)/docs/synopsis.txt > rm -f $@ $@-t > $(SED) -e 's/\(.*\)/"\1\\n"/g' $< > $@-t > -- > 2.18.0 > >

...ings.sed < $< > $@-t + mv $@-t $@ + chmod 0444 $@ + # synopsis.c is generated from docs/synopsis.txt where it is also # used to generate the man page. It is included in main.c. -BUILT_SOURCES = synopsis.c -EXTRA_DIST = synopsis.c +BUILT_SOURCES += synopsis.c +EXTRA_DIST += synopsis.c nbdkit_DEPENDENCIES = synopsis.c CLEANFILES += synopsis.c main.c: synopsis.c diff --git a/src/protostrings.sed b/src/protostrings.sed new file mode 100644 index 0000000..9a94f75 --- /dev/null +++ b/src/protostrings.sed @@ -0,0 +1,59 @@ +# nbdkit +# Copyright (C) 2018 Red Hat Inc. +# All rights reserved. +# +# Redist...

...r +/valgrind/suppressions diff --git a/Makefile.am b/Makefile.am index 2b5d80d..a06e683 100644 --- a/Makefile.am +++ b/Makefile.am @@ -40,7 +40,6 @@ EXTRA_DIST = \ html/pod.css \ LICENSE \ OTHER_PLUGINS \ - valgrind-suppressions \ m4/.gitignore CLEANFILES += html/*.html @@ -60,6 +59,7 @@ nbdkit_DEPENDENCIES = config.status SUBDIRS = \ bash \ docs \ + valgrind \ include \ common/include \ src diff --git a/configure.ac b/configure.ac index a3e4457..cf931cd 100644 --- a/configure.ac +++ b/configure.ac @@ -834,6 +834,7 @@ AC_CONFIG_FILES([Makefile src/Makefile...

v1 was here: https://www.redhat.com/archives/libguestfs/2019-November/msg00003.html This version depends on: https://www.redhat.com/archives/libguestfs/2019-November/msg00004.html and this series: https://www.redhat.com/archives/libguestfs/2019-November/msg00009.html The delta has been reduced slightly because of changes made possible by cleaning up and fixing the quit path in nbdkit. It's

libFuzzer is Clang's fuzzer, and alternative to using AFL: https://llvm.org/docs/LibFuzzer.html I implemented an alternative method of fuzzing for libnbd earlier today and it's pretty simple: https://github.com/libguestfs/libnbd/commit/c19a6fbae9a21a7d4693418706c59e81ed256875 However it's considerably more difficult to use libFuzzer with non-library code -- in this case nbdkit.

I worked out why valgrind wasn't being applied to nbdkit when run by many of the tests (patches 1-2). Unfortunately I'm not able to make it actually fail tests when valgrind fails. Although the situation is marginally improved in that you can now manually examine the *.log files and find valgrind failures that way. Also adds valgrinding of the Python plugin (patch 3). Along the way I

v1 was here: https://www.redhat.com/archives/libguestfs/2018-November/msg00147.html v2 was here: https://www.redhat.com/archives/libguestfs/2018-November/msg00152.html v3: - Use optarg != NULL as a sentinel for has_arg. - Moved some variable decls into the inner loop. - Make nbdkit wrapper depend on config.status, so if srcdir or builddir changes then we rebuild the wrapper. It