Displaying 6 results from an estimated 6 matches for "nbd_unlocked_can_fast_zero".
2019 Aug 23
1
[libnbd PATCH 1/1] api: Add support for FAST_ZERO flag
...te zeroes, ignoring claim of fast zero");
+ eflags &= ~NBD_FLAG_SEND_FAST_ZERO;
+ }
+
h->exportsize = exportsize;
h->eflags = eflags;
return 0;
@@ -100,6 +106,12 @@ nbd_unlocked_can_zero (struct nbd_handle *h)
return get_flag (h, NBD_FLAG_SEND_WRITE_ZEROES);
}
+int
+nbd_unlocked_can_fast_zero (struct nbd_handle *h)
+{
+ return get_flag (h, NBD_FLAG_SEND_FAST_ZERO);
+}
+
int
nbd_unlocked_can_df (struct nbd_handle *h)
{
diff --git a/lib/protocol.c b/lib/protocol.c
index 6087887..acee203 100644
--- a/lib/protocol.c
+++ b/lib/protocol.c
@@ -36,6 +36,7 @@ nbd_internal_errno_of_nbd_error...
2020 Sep 04
0
[libnbd PATCH 1/2] api: Add nbd_set_strict_mode
...t;);
- return -1;
- }
+ if ((flags & LIBNBD_CMD_FLAG_FUA) != 0 &&
+ nbd_unlocked_can_fua (h) != 1) {
+ set_error (EINVAL, "server does not support the FUA flag");
+ return -1;
+ }
- if ((flags & LIBNBD_CMD_FLAG_FAST_ZERO) != 0 &&
- nbd_unlocked_can_fast_zero (h) != 1) {
- set_error (EINVAL, "server does not support the fast zero flag");
- return -1;
+ if ((flags & LIBNBD_CMD_FLAG_FAST_ZERO) != 0 &&
+ nbd_unlocked_can_fast_zero (h) != 1) {
+ set_error (EINVAL, "server does not support the fast zero flag&qu...
2020 Sep 11
0
[libnbd PATCH v2 3/5] api: Add nbd_set_strict_mode
...t;);
- return -1;
- }
+ if ((flags & LIBNBD_CMD_FLAG_FUA) != 0 &&
+ nbd_unlocked_can_fua (h) != 1) {
+ set_error (EINVAL, "server does not support the FUA flag");
+ return -1;
+ }
- if ((flags & LIBNBD_CMD_FLAG_FAST_ZERO) != 0 &&
- nbd_unlocked_can_fast_zero (h) != 1) {
- set_error (EINVAL, "server does not support the fast zero flag");
- return -1;
+ if ((flags & LIBNBD_CMD_FLAG_FAST_ZERO) != 0 &&
+ nbd_unlocked_can_fast_zero (h) != 1) {
+ set_error (EINVAL, "server does not support the fast zero flag&qu...
2020 Sep 04
4
[RFC libnbd PATCH 0/2] Add knobs for client- vs. server-side validation
We have been inconsistent on how much we reject client-side without
even consulting the server, vs. how much we depend on the server to
detect failure (even if our request can be deemed undefined per NBD
protocol). I'd like to change it so that by default, we reject as
much as we can client-side for less traffic, but where the user can
also change things on the fly for server-side integration
2020 Sep 11
10
[libnbd PATCH v2 0/5] Add knobs for client- vs. server-side validation
In v2:
- now based on my proposal to add LIBNBD_SHUTDOWN_IMMEDIATE
- four flags instead of two: STRICT_FLAGS is new (patch 4),
and STRICT_BOUNDS is separate from STRICT_ZERO_SIZE (patch 5)
- various refactorings for more shared code and less duplication
Eric Blake (5):
api: Add xxx_MASK constant for each Flags type
generator: Refactor filtering of accepted OFlags
api: Add
2019 Aug 23
22
cross-project patches: Add NBD Fast Zero support
This is a cover letter to a series of patches being proposed in tandem
to four different projects:
- nbd: Document a new NBD_CMD_FLAG_FAST_ZERO command flag
- qemu: Implement the flag for both clients and server
- libnbd: Implement the flag for clients
- nbdkit: Implement the flag for servers, including the nbd passthrough
client
If you want to test the patches together, I've pushed a