Displaying 2 results from an estimated 2 matches for "nbd_set_request_sr".
2019 Sep 04
2
[libnbd PATCH] api: Add way to avoid structured replies
...our eflags test. Note that nbdkit does
not provide a 'can_df' callback in the sh script (so our key=value
override is silently ignored), rather, we control whether nbdkit
advertises df based on whether we request structured replies.
---
I'm open to renaming the API to the shorter 'nbd_set_request_sr' if
the existing name choice seems too long.
This is a counterpart to the recent addition of --no-sr in nbdkit 1.14
for server-side disable; but by doing it in the client side, we can
test lack of structured replies even while still using nbdkit 1.12.x.
lib/internal.h...
2019 Sep 05
0
Re: [libnbd PATCH] api: Add way to avoid structured replies
...dkit does
> not provide a 'can_df' callback in the sh script (so our key=value
> override is silently ignored), rather, we control whether nbdkit
> advertises df based on whether we request structured replies.
> ---
>
> I'm open to renaming the API to the shorter 'nbd_set_request_sr' if
> the existing name choice seems too long.
There's not really a limit on the length of API names, and in this
case the longer name explains what the option does more clearly.
Anyway this looks fine to me.
ACK
I have one comment unrelated to the patch:
> + "set_request_s...