search for: nbd_ready_to_write

...notify_read and nbd_notify_write (the functions used to signal to the state machine that the socket is ready for reading/writing). I wonder if we should rename something here. My suggestions are either of the following or both: (I) Rename nbd_notify_read / nbd_notify_write to nbd_ready_to_read / nbd_ready_to_write. (II) Rename nbd_aio_<CMD>_notify to nbd_aio_<CMD>_callback. What do you think? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without n...

...he functions used to signal > to the state machine that the socket is ready for reading/writing). > > I wonder if we should rename something here. My suggestions are > either of the following or both: > > (I) Rename nbd_notify_read / nbd_notify_write to nbd_ready_to_read / > nbd_ready_to_write. I'm still wondering if we want to add an nbd_notify_error for the I/O thread to inform libnbd about a POLLERR situation (as otherwise the libnbd state machine may not notice the error until much later). I don't think nbd_read_to_error() sounds good, so keeping the name nbd_notify_FOO for...

I still need to wire in the use of *_notify functions into nbdkit to prove whether it makes the code any faster or easier to maintain, but at least the added example shows one good use case for the new API. Eric Blake (6): api: Add nbd_aio_in_flight generator: Allow DEAD state actions to run generator: Allow Int64 in callbacks states: Prepare for aio notify callback api: Add new