Displaying 8 results from an estimated 8 matches for "nbd_new_handshake_finish".
2019 Sep 25
2
Re: [PATCH libnbd] lib: Copy nbd-protocol.h from nbdkit 1.15.3.
On Tue, Sep 24, 2019 at 05:24:34PM -0500, Eric Blake wrote:
> On 9/24/19 4:07 PM, Richard W.M. Jones wrote:
> > /* New-style handshake server reply when using NBD_OPT_EXPORT_NAME.
> > * Modern clients use NBD_OPT_GO instead of this.
> > @@ -167,7 +167,7 @@ struct nbd_new_handshake_finish {
> > uint64_t exportsize;
> > uint16_t eflags; /* per-export flags */
> > char zeroes[124]; /* must be sent as zero bytes */
> > -} __attribute__((packed));
> > +} NBD_ATTRIBUTE_PACKED;
>
> Redundant type.
Indeed, we don't act...
2019 Sep 24
2
[PATCH libnbd] lib: Copy nbd-protocol.h from nbdkit 1.15.3.
...; /* length of block */
uint32_t status_flags; /* block type (hole etc) */
-} __attribute__((packed));
+} NBD_ATTRIBUTE_PACKED;
/* New-style handshake server reply when using NBD_OPT_EXPORT_NAME.
* Modern clients use NBD_OPT_GO instead of this.
@@ -167,7 +167,7 @@ struct nbd_new_handshake_finish {
uint64_t exportsize;
uint16_t eflags; /* per-export flags */
char zeroes[124]; /* must be sent as zero bytes */
-} __attribute__((packed));
+} NBD_ATTRIBUTE_PACKED;
/* Request (client -> server). */
struct nbd_request {
@@ -177,14 +177,14 @@ struct nbd_request...
2019 Sep 24
0
[PATCH nbdkit 3/4] common/protocol: Update nbd-protocol.h so it matches libnbd’s copy.
...uint32_t status_flags; /* block type (hole etc) */
} __attribute__((packed));
@@ -144,14 +157,14 @@ struct block_descriptor {
/* New-style handshake server reply when using NBD_OPT_EXPORT_NAME.
* Modern clients use NBD_OPT_GO instead of this.
*/
-struct new_handshake_finish {
+struct nbd_new_handshake_finish {
uint64_t exportsize;
uint16_t eflags; /* per-export flags */
char zeroes[124]; /* must be sent as zero bytes */
} __attribute__((packed));
/* Request (client -> server). */
-struct request {
+struct nbd_request {
uint32_t magic; /* NBD_REQUEST...
2019 Sep 24
11
[PATCH nbdkit 0/4] common/protocol: Unify public <nbd-protocol.h>
We should have only one NBD protocol file. Let's make nbdkit's
version the canonical one, and use it in libnbd.
Rich.
2019 Sep 24
0
Re: [PATCH libnbd] lib: Copy nbd-protocol.h from nbdkit 1.15.3.
...IBNBD_FLAG_FIXED_NEWSTYLE (ie. that our generator produces public
constants in <libnbd.h> that match the NBD protocol constants).
> /* New-style handshake server reply when using NBD_OPT_EXPORT_NAME.
> * Modern clients use NBD_OPT_GO instead of this.
> @@ -167,7 +167,7 @@ struct nbd_new_handshake_finish {
> uint64_t exportsize;
> uint16_t eflags; /* per-export flags */
> char zeroes[124]; /* must be sent as zero bytes */
> -} __attribute__((packed));
> +} NBD_ATTRIBUTE_PACKED;
Redundant type.
>
> -/* Command flags. Exposed by the generator as...
2019 Sep 25
0
Re: [PATCH libnbd] lib: Copy nbd-protocol.h from nbdkit 1.15.3.
...Sep 24, 2019 at 05:24:34PM -0500, Eric Blake wrote:
> > On 9/24/19 4:07 PM, Richard W.M. Jones wrote:
> > > /* New-style handshake server reply when using NBD_OPT_EXPORT_NAME.
> > > * Modern clients use NBD_OPT_GO instead of this.
> > > @@ -167,7 +167,7 @@ struct nbd_new_handshake_finish {
> > > uint64_t exportsize;
> > > uint16_t eflags; /* per-export flags */
> > > char zeroes[124]; /* must be sent as zero bytes */
> > > -} __attribute__((packed));
> > > +} NBD_ATTRIBUTE_PACKED;
> >
> > Redund...
2019 Sep 25
0
[libnbd PATCH] lib: Synchronize nbd-protocol.h with nbdkit, again
...w_option_reply_info_export {
@@ -160,15 +166,6 @@ struct nbd_block_descriptor {
uint32_t status_flags; /* block type (hole etc) */
} NBD_ATTRIBUTE_PACKED;
-/* New-style handshake server reply when using NBD_OPT_EXPORT_NAME.
- * Modern clients use NBD_OPT_GO instead of this.
- */
-struct nbd_new_handshake_finish {
- uint64_t exportsize;
- uint16_t eflags; /* per-export flags */
- char zeroes[124]; /* must be sent as zero bytes */
-} NBD_ATTRIBUTE_PACKED;
-
/* Request (client -> server). */
struct nbd_request {
uint32_t magic; /* NBD_REQUEST_MAGIC. */
diff --git...
2019 Sep 24
0
[PATCH nbdkit 4/4] common/protocol: Install <nbd-protocol.h> as a public header.
...; /* length of block */
uint32_t status_flags; /* block type (hole etc) */
-} __attribute__((packed));
+} NBD_ATTRIBUTE_PACKED;
/* New-style handshake server reply when using NBD_OPT_EXPORT_NAME.
* Modern clients use NBD_OPT_GO instead of this.
@@ -161,7 +167,7 @@ struct nbd_new_handshake_finish {
uint64_t exportsize;
uint16_t eflags; /* per-export flags */
char zeroes[124]; /* must be sent as zero bytes */
-} __attribute__((packed));
+} NBD_ATTRIBUTE_PACKED;
/* Request (client -> server). */
struct nbd_request {
@@ -171,14 +177,14 @@ struct nbd_request...