search for: nbd_get_handshake_flag

...eave it as you wrote it. Rich. > Fortunately, it would not be an ABI change on any > of the platforms we compile on. So I can go ahead and return the > smarter type unless we have a strong reason not to (the API change > might affect anyone that was storing a function pointer to > nbd_get_handshake_flags, and more so in C++ than C). > > > > >The rest of the patch looks fine. > > > >Rich. > > > > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3226 > Virtualization: qemu.org | libvirt.org -- Richard Jones, Virtu...

...so not sure if there is a more > efficient way to avoid outputting Val_FOO() converters for types not > referenced in REnum/RFlags than my hack of __attribute__((unused)). > Hence I'll wait for a review on these. > > Now, for the future compatibility lesson, promised above. > nbd_get_handshake_flags is documented as potentially returning > additional bits from a newer libnbd than what the current client code > was compiled against. How? Let's say a future NBD protocol addition > adds LIBNBD_HANDSHAKE_FLAG_64BIT (as that one might actually be a way > that we implement 64-bit r...

...;; + "L<nbd_get_protocol(3)>"]; }; "set_handshake_flags", { @@ -1673,7 +1690,9 @@ be returned in the future. Most modern NBD servers use C<\"newstyle-fixed\">. " ^ non_blocking_test_call_description; - see_also = ["L<nbd_get_handshake_flags(3)>"]; + see_also = ["L<nbd_get_handshake_flags(3)>"; + "L<nbd_get_structured_replies_negotiated(3)>"; + "L<nbd_get_tls_negotiated(3)>"]; }; "get_size", { @@ -2654,6 +2673,7 @@ let first_versi...

On Sat, Sep 05, 2020 at 08:40:58PM -0500, Eric Blake wrote: > diff --git a/generator/API.mli b/generator/API.mli > index 712e837..e45b5c0 100644 > --- a/generator/API.mli > +++ b/generator/API.mli > @@ -78,6 +78,8 @@ and ret = > | RString (** return a newly allocated string, > caller frees, NULL for error *) > | RUInt

...LAG_MASK + 1) != -1) { fprintf (stderr, "%s: test failed: " "nbd_set_handshake_flags did not reject invalid bitmask\n", argv[0]); exit (EXIT_FAILURE); } - i = LIBNBD_HANDSHAKE_FLAG_FIXED_NEWSTYLE | LIBNBD_HANDSHAKE_FLAG_NO_ZEROES; - if (nbd_get_handshake_flags (nbd) != i) { + if (nbd_get_handshake_flags (nbd) != LIBNBD_HANDSHAKE_FLAG_MASK) { fprintf (stderr, "%s: test failed: " "nbd_get_handshake_flags not left at default value\n", argv[0]); @@ -247,7 +244,7 @@ main (int argc, char *argv[]) check...

...rn uint32_t makes sense, but is a minor API change. Fortunately, it would not be an ABI change on any of the platforms we compile on. So I can go ahead and return the smarter type unless we have a strong reason not to (the API change might affect anyone that was storing a function pointer to nbd_get_handshake_flags, and more so in C++ than C). > > The rest of the patch looks fine. > > Rich. > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

...r ran (see below). I'm also not sure if there is a more efficient way to avoid outputting Val_FOO() converters for types not referenced in REnum/RFlags than my hack of __attribute__((unused)). Hence I'll wait for a review on these. Now, for the future compatibility lesson, promised above. nbd_get_handshake_flags is documented as potentially returning additional bits from a newer libnbd than what the current client code was compiled against. How? Let's say a future NBD protocol addition adds LIBNBD_HANDSHAKE_FLAG_64BIT (as that one might actually be a way that we implement 64-bit requests...). Presuma...

...> = 2 + +If the client is forced to use C<NBD_OPT_EXPORT_NAME> instead of +the preferred C<NBD_OPT_GO>, this flag allows the server to send +fewer all-zero padding bytes over the connection. + +=back + +Future NBD extensions may add further flags. +"; + see_also = ["L<nbd_get_handshake_flags(3)>"; + "L<nbd_set_request_structured_replies(3)>"]; + }; + + "get_handshake_flags", { + default_call with + args = []; ret = RUInt; + may_set_error = false; + shortdesc = "see which handshake flags are supported"; + longd...

Well, the golang changes (patch 1 and 2/3 of v1) were already committed, all that was left was the OCaml changes. I'm a lot happier with how things turned out with an UNKNOWN constructor in the OCaml variants. Eric Blake (3): tests: Enhance coverage of enum/flag range checking ocaml: Support unknown values for Enum/Flags ocaml: Typesafe returns for REnum/RFlags generator/OCaml.ml

...onnect_systemd_socket_activation(3) nbd_aio_connect_systemd_socket_activation(3) Connect to local processes that support systemd socket activation. nbd_connect_vsock(3) nbd_aio_connect_vsock(3) Used to connect to servers over "AF_VSOCK". nbd_get_handshake_flags(3) nbd_set_handshake_flags(3) nbd_get_request_structured_replies(3) nbd_set_request_structured_replies(3) nbd_get_structured_replies_negotiated(3) Can be used when testing NBD servers to avoid various NBD features (Eric Blake). nbd_get_prot...

In v2: - now based on my proposal to add LIBNBD_SHUTDOWN_IMMEDIATE - four flags instead of two: STRICT_FLAGS is new (patch 4), and STRICT_BOUNDS is separate from STRICT_ZERO_SIZE (patch 5) - various refactorings for more shared code and less duplication Eric Blake (5): api: Add xxx_MASK constant for each Flags type generator: Refactor filtering of accepted OFlags api: Add